Bugzilla – Attachment 57448 Details for
Bug 17574
Remove LocalholdsPriority.t warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t
Bug-17574-Remove-itemtype-related-warnings-from-Lo.patch (text/plain), 2.44 KB, created by
Marcel de Rooy
on 2016-11-11 08:18:59 UTC
(
hide
)
Description:
Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-11-11 08:18:59 UTC
Size:
2.44 KB
patch
obsolete
>From d54ba63dd13c5c06f56bc1f96ba4a2c8e4f63ee7 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 7 Nov 2016 15:31:53 -0300 >Subject: [PATCH] Bug 17574: Remove itemtype-related warnings from > LocalHoldsPriority.t >Content-Type: text/plain; charset=utf-8 > >To test: >- Run: > $ prove t/db_dependent/Holds/LocalHoldsPriority.t >=> FAIL: Tests raise lots of warnings >- Apply the patch >- Run: > $ prove t/db_dependent/Holds/LocalHoldsPriority.t >=> SUCCESS: Tests pass, and no warnings! >- Sign off :-D > >Sponsored-by: ByWater Solutions > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Holds/LocalHoldsPriority.t | 33 ++++++++++++++++++------------- > 1 file changed, 19 insertions(+), 14 deletions(-) > >diff --git a/t/db_dependent/Holds/LocalHoldsPriority.t b/t/db_dependent/Holds/LocalHoldsPriority.t >index 7ccc843..ef40686 100755 >--- a/t/db_dependent/Holds/LocalHoldsPriority.t >+++ b/t/db_dependent/Holds/LocalHoldsPriority.t >@@ -25,26 +25,31 @@ $schema->storage->txn_begin; > > my $builder = t::lib::TestBuilder->new; > >-my $library1 = $builder->build({ >- source => 'Branch', >-}); >-my $library2 = $builder->build({ >- source => 'Branch', >-}); >-my $library3 = $builder->build({ >- source => 'Branch', >-}); >-my $library4 = $builder->build({ >- source => 'Branch', >-}); >+my $library1 = $builder->build({ source => 'Branch', }); >+my $library2 = $builder->build({ source => 'Branch', }); >+my $library3 = $builder->build({ source => 'Branch', }); >+my $library4 = $builder->build({ source => 'Branch', }); >+my $itemtype = $builder->build( >+ { source => 'Itemtype', >+ value => { notforloan => undef, rentalcharge => 0 } >+ } >+)->{itemtype}; >+ >+ > > my $borrowers_count = 5; > > # Create a helper biblio > my ( $bibnum, $title, $bibitemnum ) = create_helper_biblio(); > # Create a helper item for the biblio. >-my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = >- AddItem( { homebranch => $library4->{branchcode}, holdingbranch => $library3->{branchcode} }, $bibnum ); >+my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem( >+ { homebranch => $library4->{branchcode}, >+ holdingbranch => $library3->{branchcode}, >+ itype => $itemtype >+ }, >+ $bibnum >+); >+ > > my @branchcodes = ( $library1->{branchcode}, $library2->{branchcode}, $library3->{branchcode}, $library4->{branchcode}, $library3->{branchcode}, $library4->{branchcode} ); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17574
:
57277
|
57288
| 57448