Attachment 58468 Details for Bug 7533 – Bug 7533: Add a warning to the about page if template_cache_dir is not set

[patch] Bug 7533: Add a warning to the about page if template_cache_dir is not set

Bug-7533-Add-a-warning-to-the-about-page-if-templa.patch (text/plain), 3.87 KB, created by Jonathan Druart on 2016-12-28 13:53:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-12-28 13:53:17 UTC

Size: 3.87 KB

patch

obsolete

>From 931b274756977e21e4146935a3efac601da7196a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 28 Dec 2016 13:51:17 +0000
>Subject: [PATCH] Bug 7533: Add a warning to the about page if
> template_cache_dir is not set
>
>We need to tell the administrators that it would be great for them to
>set this config entry.
>
>Test plan:
>- Do not set template_cache_dir and confirm that you see the warning
>- Set template_cache_dir and confirm that you do not see the warning
>---
> about.pl                                         |  2 ++
> koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 10 ++++++++--
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/about.pl b/about.pl
>index fc16079..f0b0499 100755
>--- a/about.pl
>+++ b/about.pl
>@@ -128,6 +128,7 @@ my $errZebraConnection = C4::Context->Zconn("biblioserver",0)->errcode();
> my $warnIsRootUser   = (! $loggedinuser);
> 
> my $warnNoActiveCurrency = (! defined Koha::Acquisition::Currencies->get_active);
>+
> my @xml_config_warnings;
> 
> my $context = new C4::Context;
>@@ -307,6 +308,7 @@ $template->param(
>     errZebraConnection => $errZebraConnection,
>     warnIsRootUser => $warnIsRootUser,
>     warnNoActiveCurrency => $warnNoActiveCurrency,
>+    warnNoTemplateCaching => ( C4::Context->config('template_cache_dir') ? 0 : 1 ),
>     xml_config_warnings => \@xml_config_warnings,
>     warnStatisticsFieldsError => $warnStatisticsFieldsError,
> );
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>index ddba5fd..e4d8dbd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>@@ -138,7 +138,7 @@
> 
>         <div id="sysinfo">
>     [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron || warnPrefAnonymousPatron_PatronDoesNotExist ||
>-          warnNoActiveCurrency || QueryParserError || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError %]
>+          warnNoActiveCurrency || QueryParserError || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching %]
>         [% IF (warnIsRootUser) %]
>             <h2>Warning regarding current user</h2>
>             <p>You are logged in as the database administrative user. This is not recommended because some parts of Koha will not function as expected when using this account.</p>
>@@ -146,7 +146,7 @@
>         [% END %]
> 
>         [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron || warnPrefAnonymousPatron_PatronDoesNotExist ||
>-              warnNoActiveCurrency || QueryParserError || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError%]
>+              warnNoActiveCurrency || QueryParserError || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching %]
>             <h2>Warnings regarding the system configuration</h2>
>             <table>
>                 <caption>Preferences and parameters</caption>
>@@ -190,6 +190,12 @@
>                     The patron used for the self checkout module at the OPAC has too many permissions. They should only have circulate => self_checkout.
>                     </td></tr>
>                 [% END %]
>+                [% IF warnNoTemplateCaching %]
>+                    <tr><th scope="row"><b>Warning</b> </th><td>
>+                    You are missing the &lt;template_cache_dir&gt; entry in your koha-conf.xml file.
>+                    That will bring a performance boost to enable it.
>+                    </td></tr>
>+                [% END %]
>             </table>
>         [% END %]
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 7533: 58467 | 58468 | 58476 | 58477 | 59091 | 59092