Add an option to the command-line installer that will let the user choose to activate T::T during installation.
(In reply to Paul Poulain from comment #0) > Add an option to the command-line installer that will let the user choose to > activate T::T during installation. Hi Paul, do you think it would be better to enable this feature by default? It seems to good to just have it as an 'optional' choice :)
I always enable TT caching for new instances.
Created attachment 58467 [details] [review] Bug 7533: Add the template_cache_dir entry to koha-conf.xml And comment it, as we don't know what are the sysop's preferences
Created attachment 58468 [details] [review] Bug 7533: Add a warning to the about page if template_cache_dir is not set We need to tell the administrators that it would be great for them to set this config entry. Test plan: - Do not set template_cache_dir and confirm that you see the warning - Set template_cache_dir and confirm that you do not see the warning
I don't think it's a good idea to just ask during the install process if the administrators want this option. It's better to let them enable it if they want it and configure it following their preferences.
Created attachment 58476 [details] [review] [SIGNED-OFF] Bug 7533: Add the template_cache_dir entry to koha-conf.xml And comment it, as we don't know what are the sysop's preferences Signed-off-by: Magnus Enger <magnus@libriotech.no>
Created attachment 58477 [details] [review] [SIGNED-OFF] Bug 7533: Add a warning to the about page if template_cache_dir is not set We need to tell the administrators that it would be great for them to set this config entry. Test plan: - Do not set template_cache_dir and confirm that you see the warning - Set template_cache_dir and confirm that you do not see the warning Signed-off-by: Magnus Enger <magnus@libriotech.no> Both templates for koha-conf.xml are updated. After applying the patach a warning was correctly displayed. After adding template_cache_dir to koha-conf.xml and restarting memcached it went away.
I would prefer not to use /tmp as the template cache dir, but a subdir of /tmp in order to keep more control there. Also I am wondering if we should give each instance a separate cache dir or share it between instances. I have a slight preference for separating them, although it does not seem strictly necessary.
(In reply to Marcel de Rooy from comment #8) > I would prefer not to use /tmp as the template cache dir, but a subdir of > /tmp in order to keep more control there. > Also I am wondering if we should give each instance a separate cache dir or > share it between instances. I have a slight preference for separating them, > although it does not seem strictly necessary. The line is commented by default, I think it's the duty of the sys admin to configure it correctly. IIRC if the subdir does not exist, it will explode.
Created attachment 59091 [details] [review] Bug 7533: Add the template_cache_dir entry to koha-conf.xml And comment it, as we don't know what are the sysop's preferences Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 59092 [details] [review] Bug 7533: Add a warning to the about page if template_cache_dir is not set We need to tell the administrators that it would be great for them to set this config entry. Test plan: - Do not set template_cache_dir and confirm that you see the warning - Set template_cache_dir and confirm that you do not see the warning Signed-off-by: Magnus Enger <magnus@libriotech.no> Both templates for koha-conf.xml are updated. After applying the patach a warning was correctly displayed. After adding template_cache_dir to koha-conf.xml and restarting memcached it went away. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
I think we should fall back to /tmp, and take care of creating a per-instance directory in /var/somewhere for each instance. I think the patchset is incomplete!
(In reply to Tomás Cohen Arazi from comment #12) > I think we should fall back to /tmp, and take care of creating a > per-instance directory in /var/somewhere for each instance. > > I think the patchset is incomplete! I agree, but did not want to block this.
Pushed to master for 17.05, thanks Jonathan! Would you be able to add a followup bug to store the cache in /var/lib/koha/$site/template_cache or something like that for packages?
This won't get ported back to 16.11.x as it is an enhancement.
(In reply to Kyle M Hall from comment #14) > Pushed to master for 17.05, thanks Jonathan! Would you be able to add a > followup bug to store the cache in /var/lib/koha/$site/template_cache or > something like that for packages? Tomas opened bug 17951.
(In reply to Katrin Fischer from comment #15) > This won't get ported back to 16.11.x as it is an enhancement. I think this one should be backported to the stable branches, it will not hurt and could highlight performance boost.
(In reply to Jonathan Druart from comment #17) > (In reply to Katrin Fischer from comment #15) > > This won't get ported back to 16.11.x as it is an enhancement. > > I think this one should be backported to the stable branches, it will not > hurt and could highlight performance boost. I agree with Jonathan
After looking at the patches they seem safe, so I will probably push in the next few days.
Wow, it's hard to get from RESOLVED FIXED back to "Pushed to master"!
I've decided to make an exception here and backport this enh as it might be helpful for stable releases and it's quite safe not to break something. These patches have been pushed to 16.11.x and will be in 16.11.04.
Pushed to 16.05.x, for 16.05.10 release