Attachment 60633 Details for Bug 7663 – Bug 7663 (QA Followup)

[patch] Bug 7663 (QA Followup)

Bug-7663-QA-Followup.patch (text/plain), 1.05 KB, created by Jonathan Druart on 2017-02-24 07:46:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-02-24 07:46:57 UTC

Size: 1.05 KB

patch

obsolete

>From cdc151e20a3b655f41bcb50587eb2d5d76b0d30f Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 24 Feb 2017 01:29:22 +0000
>Subject: [PATCH] Bug 7663 (QA Followup)
>
>    Ignore empty entries
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> virtualshelves/shelves.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/virtualshelves/shelves.pl b/virtualshelves/shelves.pl
>index 3e03e6d..a6d04ce 100755
>--- a/virtualshelves/shelves.pl
>+++ b/virtualshelves/shelves.pl
>@@ -145,6 +145,7 @@ if ( $op eq 'add_form' ) {
>                 my @barcodes = split /\n/, $barcodes; # Entries are effectively passed in as a <cr> separated list
>                 foreach my $barcode (@barcodes){
>                     $barcode =~ s/\r$//; # strip any naughty return chars
>+                    next if $barcode eq '';
>                     my $item = GetItem( 0, $barcode);
>                     if (defined $item && $item->{itemnumber}) {
>                         my $biblio = GetBiblioFromItemNumber( $item->{itemnumber} );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 7663: 57855 | 57865 | 57868 | 60627 | 60628 | 60632 | 60633 | 60634