I would be nice if this page: /koha/virtualshelves/shelves.pl?viewshelf=13 had a bigger box so that you could add multiple barcodes at a time (like you can on label maker or the batch modification tool).
Well, it's only 4 years later but I was just asked for this again :) hehe
Created attachment 57855 [details] [review] Bug 7663 - batch add barcodes to a list This patch changes the barcode input on add list to a textarea and process multiples barcodes to allow for adding many items to a list at once To test: 1 - Create a list 2 - Add some items 3 - Verify items are added and success reported 4 - Add these items again 5 - Verify you are notified they were not added 6 - Type invalid barcodes into the text area and submit 7 - Verify you are notifed of failure to add 8 - Try going to a list that doesn't exist and adding barcodes i.e. http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=add_biblio&shelfnumber=9999&barcodes=4 9 - Verify correct error 10 - Try the above but with a list that exists while signed in as a patron without lists permission 11 - Verfiy correct error
Created attachment 57865 [details] [review] Bug 7663 - batch add barcodes to a list This patch changes the barcode input on add list to a textarea and process multiples barcodes to allow for adding many items to a list at once To test: 1 - Create a list 2 - Add some items 3 - Verify items are added and success reported 4 - Add these items again 5 - Verify you are notified they were not added 6 - Type invalid barcodes into the text area and submit 7 - Verify you are notifed of failure to add 8 - Try going to a list that doesn't exist and adding barcodes i.e. http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=add_biblio&shelfnumber=9999&barcodes=4 9 - Verify correct error 10 - Try the above but with a list that exists while signed in as a patron without lists permission: i.e. http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=3 11 - Verfiy correct error: "You do not have permission to view this list." Signed-off-by: Chris Kirby <chris.kirby@ilsleypubliclibrary.org> Works as advertised.
Created attachment 57868 [details] [review] Bug 7663 - batch add barcodes to a list This patch changes the barcode input on add list to a textarea and process multiples barcodes to allow for adding many items to a list at once To test: 1 - Create a list 2 - Add some items 3 - Verify items are added and success reported 4 - Add these items again 5 - Verify you are notified they were not added 6 - Type invalid barcodes into the text area and submit 7 - Verify you are notifed of failure to add 8 - Try going to a list that doesn't exist and adding barcodes i.e. http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=add_biblio&shelfnumber=9999&barcodes=4 9 - Verify correct error 10 - Try the above but with a list that exists while signed in as a patron without lists permission: i.e. http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=3 11 - Verify correct error: "You do not have permission to view this list." Signed-off-by: Chris Kirby <chris.kirby@ilsleypubliclibrary.org> Works as advertised.
Nick, just a small concern: if you end with an empty line, you get "The item () does not exist". It seems easy to handle it.
Created attachment 60627 [details] [review] Bug 7663 - batch add barcodes to a list This patch changes the barcode input on add list to a textarea and process multiples barcodes to allow for adding many items to a list at once To test: 1 - Create a list 2 - Add some items 3 - Verify items are added and success reported 4 - Add these items again 5 - Verify you are notified they were not added 6 - Type invalid barcodes into the text area and submit 7 - Verify you are notifed of failure to add 8 - Try going to a list that doesn't exist and adding barcodes i.e. http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=add_biblio&shelfnumber=9999&barcodes=4 9 - Verify correct error 10 - Try the above but with a list that exists while signed in as a patron without lists permission: i.e. http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=3 11 - Verify correct error: "You do not have permission to view this list." Signed-off-by: Chris Kirby <chris.kirby@ilsleypubliclibrary.org> Works as advertised.
Created attachment 60628 [details] [review] Bug 7663 (QA Followup) Ignore empty entries
Created attachment 60632 [details] [review] Bug 7663 - batch add barcodes to a list This patch changes the barcode input on add list to a textarea and process multiples barcodes to allow for adding many items to a list at once To test: 1 - Create a list 2 - Add some items 3 - Verify items are added and success reported 4 - Add these items again 5 - Verify you are notified they were not added 6 - Type invalid barcodes into the text area and submit 7 - Verify you are notifed of failure to add 8 - Try going to a list that doesn't exist and adding barcodes i.e. http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=add_biblio&shelfnumber=9999&barcodes=4 9 - Verify correct error 10 - Try the above but with a list that exists while signed in as a patron without lists permission: i.e. http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=3 11 - Verify correct error: "You do not have permission to view this list." Signed-off-by: Chris Kirby <chris.kirby@ilsleypubliclibrary.org> Works as advertised. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 60633 [details] [review] Bug 7663 (QA Followup) Ignore empty entries Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 60634 [details] [review] Bug 7663: Fix bad merge conflict with bug 15584 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Nick, Jonathan!
This won't get ported back to 16.11.x as it is an enhancement.
I Cant able to find file "a/virtualshelves/shelves.pl" KOHA version: 16.05.19.000 OS version: UBUNTU 16.04 LTS 32 BIT Perl version: 5.022001
(In reply to Nitesh Kumar Verma from comment #13) > I Cant able to find file "a/virtualshelves/shelves.pl" > > KOHA version: 16.05.19.000 > OS version: UBUNTU 16.04 LTS 32 BIT > Perl version: 5.022001 It's "virtualshelves/shelves.pl" You should either upgrade to a more recent version of Koha to get this change, or apply the patches using the command 'patch'