Attachment 60709 Details for Bug 16966 – Bug 16966: [QA Follow-up] Check count, not size in template

[patch] Bug 16966: [QA Follow-up] Check count, not size in template

Bug-16966-QA-Follow-up-Check-count-not-size-in-tem.patch (text/plain), 2.34 KB, created by Marcel de Rooy on 2017-02-27 12:46:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-02-27 12:46:15 UTC

Size: 2.34 KB

patch

obsolete

>From 951922c7fd1ac3c9dfa7980003ae04e85fbd36ca Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 27 Feb 2017 13:21:18 +0100
>Subject: [PATCH] Bug 16966: [QA Follow-up] Check count, not size in template
>Content-Type: text/plain; charset=utf-8
>
>The method size is not covered by tests at koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt line 163.
>The method size is not covered by tests at koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt line 183.
>
>Script cleanborrowers passes patrons_to_delete and patrons_to_anonymize to
>the template. One is an array ref where we should use 'size', the other is a
>Koha::Patrons object where we should use 'count'.
>If we don't, we will not anonymize a lot of records ;)
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt
>index e5bf24d..7da2ff7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt
>@@ -160,7 +160,7 @@
>         <legend>Warnings</legend>
>         <ul>
>             <li>[% patrons_to_delete.size || 0 %] patrons will be deleted</li>
>-            <li>[% patrons_to_anonymize.size || 0 %] patron's checkout histories will be anonymized</li>
>+            <li>[% patrons_to_anonymize.count || 0 %] patron's checkout histories will be anonymized</li>
>         </ul>
> 
>         <br />
>@@ -177,9 +177,9 @@
>                 <input type="hidden" name="do_delete" value="[% patrons_to_delete.size %]" /></fieldset>
> 
>             [% END %]
>-            [% IF patrons_to_anonymize.size %]
>-                Checkout history for [% patrons_to_anonymize.size %] patrons will be anonymized
>-                <input type="hidden" name="do_anonym" value="[% patrons_to_anonymize.size %]" />
>+            [% IF patrons_to_anonymize.count %]
>+                Checkout history for [% patrons_to_anonymize.count %] patrons will be anonymized
>+                <input type="hidden" name="do_anonym" value="[% patrons_to_anonymize.count %]" />
>             [% END %]
> 
>             <input type="hidden" name="step" value="3" />
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16966: 53658 | 53659 | 53660 | 53661 | 56376 | 56377 | 56378 | 56379 | 56639 | 56640 | 56641 | 56642 | 57170 | 57171 | 57172 | 57885 | 57886 | 57887 | 57924 | 57925 | 57926 | 58282 | 58283 | 58284 | 58285 | 58286 | 60377 | 60378 | 60379 | 60380 | 60381 | 60382 | 60648 | 60649 | 60650 | 60651 | 60652 | 60653 | 60701 | 60702 | 60703 | 60704 | 60705 | 60706 | 60707 | 60708 | 60709