Bugzilla – Attachment 61381 Details for
Bug 8603
Patron card creator - 'Barcode Type' doesn't stick in layouts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts
Bug-8603-Patron-card-creator---Barcode-Type-doesnt.patch (text/plain), 2.07 KB, created by
Kyle M Hall (khall)
on 2017-03-21 13:13:07 UTC
(
hide
)
Description:
Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-03-21 13:13:07 UTC
Size:
2.07 KB
patch
obsolete
>From d296271114bf8644708972faf2dbeb564e07dce7 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Sat, 11 Mar 2017 17:18:10 +0100 >Subject: [PATCH] Bug 8603: Patron card creator - 'Barcode Type' doesn't stick > in layouts > >To reproduce: > >1. Make a new layout >2. Tick "Print card number as barcode" >3. Change 'Barcode Type' to anything other than Code39 >4. Save >5. Edit it again >6. Its back to Code39 > >To test: >1. Apply patch >2. Repeat steps above >3. Verify that 'Barcode type' is selected as expected > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> > >https://bugs.koha-community.org/show_bug.cgi?id=18063 > >https://bugs.koha-community.org/show_bug.cgi?id=8063 > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > patroncards/edit-layout.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/patroncards/edit-layout.pl b/patroncards/edit-layout.pl >index 5d5d2df..81df878 100755 >--- a/patroncards/edit-layout.pl >+++ b/patroncards/edit-layout.pl >@@ -140,7 +140,7 @@ if ($op eq 'edit') { > # Handle barcodes... > my @barcode = (); > foreach my $barcode_param (keys %{$layout_xml->{'barcode'}->[0]}) { >- push @barcode, (($barcode_param eq 'type' ? ("barcode_" . $barcode_param => _set_selected($layout_xml->{'barcode'}->[0]->{'barcode_type'}, $barcode_types)) : ("barcode_" . $barcode_param => $layout_xml->{'barcode'}->[0]->{$barcode_param}))); >+ push @barcode, (($barcode_param eq 'type' ? ("barcode_" . $barcode_param => _set_selected($layout_xml->{'barcode'}->[0]->{'type'}, $barcode_types)) : ("barcode_" . $barcode_param => $layout_xml->{'barcode'}->[0]->{$barcode_param}))); > } > > foreach my $unit (@$units){ >@@ -156,7 +156,7 @@ if ($op eq 'edit') { > guide_box => $layout_xml->{'guide_box'}, > units => $units, > @barcode, >- barcode_type => get_barcode_types(), >+ barcode_type => _set_selected($layout_xml->{'barcode'}->[0]->{'type'}, $barcode_types), > @text_fields, > @images, > guidebox => 0, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8603
:
61010
|
61325
|
61381
|
61388