To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39
Created attachment 61010 [details] [review] Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39 To test: 1. Apply patch 2. Repeat steps above 3. Verify that 'Barcode type' is selected as expected
Still seeing the same behavior after the patch is applied. -JesseM
Hi Jesse, I re-tested with an existing and a new layout for Patron card creator, it works fine for me. Can you provide the steps you did for testing? Thanks Marc
Of course. I will retest now and document what happens. -Jesse
Created attachment 61325 [details] [review] Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39 To test: 1. Apply patch 2. Repeat steps above 3. Verify that 'Barcode type' is selected as expected Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=18063 https://bugs.koha-community.org/show_bug.cgi?id=8063
Created attachment 61381 [details] [review] Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39 To test: 1. Apply patch 2. Repeat steps above 3. Verify that 'Barcode type' is selected as expected Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=18063 https://bugs.koha-community.org/show_bug.cgi?id=8063 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Current status: Signed Off
Created attachment 61388 [details] [review] Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39 To test: 1. Apply patch 2. Repeat steps above 3. Verify that 'Barcode type' is selected as expected Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=18063 https://bugs.koha-community.org/show_bug.cgi?id=8063 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to Master - Should be in the 17.05 Release. Thanks
This patch has been pushed to 16.11.x and will be in 16.11.06.
Pushed to 3.22.x, will be in 3.22.19
Pushed to 16.05.x, for 16.05.12 release