Bugzilla – Attachment 61726 Details for
Bug 10357
Send email when serial received subscription link is hard to find
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10357: Adding link for email notification for new subscription issues to opac-detail
Bug-10357-Adding-link-for-email-notification-for-n.patch (text/plain), 4.95 KB, created by
Marc Véron
on 2017-03-30 06:43:50 UTC
(
hide
)
Description:
Bug 10357: Adding link for email notification for new subscription issues to opac-detail
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2017-03-30 06:43:50 UTC
Size:
4.95 KB
patch
obsolete
>From 4aa7c117993d9182ad530c32c76aad2212d56a62 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Mon, 6 Feb 2017 21:26:54 +0000 >Subject: [PATCH] Bug 10357: Adding link for email notification for new > subscription issues to opac-detail >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch adds the link to the opac-detail.pl page so it is less hard >to find. >Update: Fixing link to look like button, adding span ID around element >Update: Changing ID to Class > >To test: >1) Add a subscription, attach it to a record and select a notice under >'Patron notification'. Hit Next, fill in some fields and save the >subscription >2) Go to that record detail page in the OPAC. Go to the subscriptions >tab, click 'More details'. Notice how many clicks it takes to see the >'Subscribe' button >3) Apply patch and go back to the details page for the record >4) Notice now there is a 'subscribe' link >5) Confirm this link still works as expected > >Sponsored-by: Catalyst IT > >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> > >Followed test plan, works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 11 +++++++++++ > opac/opac-detail.pl | 10 +++++++++- > 2 files changed, 20 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index e4fb61f..519b341 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -810,6 +810,17 @@ > <p>[% subscription.subscriptionnotes FILTER html_line_break %] </p> > [% END %] > <p>Subscription from: [% subscription.histstartdate | $KohaDates %] to:[% IF ( subscription.histenddate ) %] [% subscription.histenddate | $KohaDates %] [% ELSE %] now (current)[% END %]</p> >+ <span class="email_notifications">[% IF ( subscription.letter ) %] >+ [% IF ( loggedinusername ) %] >+ [% IF ( subscription.hasalert ) %] >+ You have subscribed to email notification on new issues. <a class="btn" title="Cancel email notification" href="/cgi-bin/koha/opac-alert-subscribe.pl?op=cancel&externalid=[% subscription.subscriptionid %]&alerttype=issue&biblionumber=[% subscription.biblionumber %]">Cancel email notification</a> >+ [% ELSE %] >+ <a class="btn" title="Subscribe to email notification on new issues" href="/cgi-bin/koha/opac-alert-subscribe.pl?externalid=[% subscription.subscriptionid %]&alerttype=issue&biblionumber=[% subscription.biblionumber %]">Subscribe to email notification on new issues</a> >+ [% END %] >+ [% ELSE %] >+ You must log in if you want to subscribe to email notification on new issues >+ [% END %] >+ [% END %]</span> > [% IF ( subscription.missinglist ) %] > <p>Missing issues: [% subscription.missinglist %] </p> > [% END %] >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index a7e643c..10e8184 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -40,6 +40,7 @@ use C4::XSLT; > use C4::ShelfBrowser; > use C4::Reserves; > use C4::Charset; >+use C4::Letters; > use MARC::Record; > use MARC::Field; > use List::MoreUtils qw/any none/; >@@ -568,15 +569,22 @@ foreach my $subscription (@subscriptions) { > $cell{histstartdate} = $subscription->{histstartdate}; > $cell{histenddate} = $subscription->{histenddate}; > $cell{branchcode} = $subscription->{branchcode}; >- $cell{hasalert} = $subscription->{hasalert}; > $cell{callnumber} = $subscription->{callnumber}; > $cell{closed} = $subscription->{closed}; >+ $cell{letter} = $subscription->{letter}; >+ $cell{biblionumber} = $subscription->{biblionumber}; > #get the three latest serials. > $serials_to_display = $subscription->{opacdisplaycount}; > $serials_to_display = C4::Context->preference('OPACSerialIssueDisplayCount') unless $serials_to_display; > $cell{opacdisplaycount} = $serials_to_display; > $cell{latestserials} = > GetLatestSerials( $subscription->{subscriptionid}, $serials_to_display ); >+ if ( $borrowernumber ) { >+ my $sub = getalert($borrowernumber,'issue',$subscription->{subscriptionid}); >+ if (@$sub[0]) { >+ $cell{hasalert} = 1; >+ } >+ } > push @subs, \%cell; > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10357
:
59955
|
61531
|
61653
|
61723
|
61724
|
61726
|
61858
|
61869
|
62309
|
62310