The link to subscribe to be notified of a new issue of a serial is squirrelled away 3 clicks from the main view - it should be easier to find.
Created attachment 59955 [details] [review] Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' link 5) Confirm this link still works as expected Sponsored-by: Catalyst IT
The subscribe link now appears on the "Subscription" tab. It works the same way (confirmation, button to unsuscribe). However, as mail are not send when working on sandbox, I didn't check the notice is correcly send to the patron when receiving a new issue ; there is no "standing" mail on the "Notice" tab on the patron account. Thanks for this very useful patch !
Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 61531 [details] [review] Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' link 5) Confirm this link still works as expected Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Aleisha, I think we should use the same style as on the other page (button). It maybe also be good to add a span with id to make the element customizable (hidden?).
Created attachment 61653 [details] [review] Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' link 5) Confirm this link still works as expected Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Found folliwing while testing: 1) If more than one subscription is attached, <span id="email_notifications"> is repeated, but id's must be unique. I think it is better to have a class. 2) We have: - At Library: (Branch name missing, is fixed with Bug 18307) - Public note - Subscription details (date range) - Email notification handling (Subscribe, Unsubscribe, Note if not logged in) - Call number - Info about x latest issues (table) Can we move Call number up? (e.g. after "At library:", would be the same as in Staff client)
I'm not sure the call number part is really part of this bug? Cheers, Liz
(In reply to Liz Rea from comment #8) > I'm not sure the call number part is really part of this bug? > > Cheers, > Liz No problem for me. Maybe something for an other bug. Marc
Created attachment 61723 [details] [review] Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element Update: Changing ID to Class To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' link 5) Confirm this link still works as expected Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 61724 [details] [review] Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element Update: Changing ID to Class To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' link 5) Confirm this link still works as expected Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
(In reply to Marc Véron from comment #7) > Found folliwing while testing: > > 1) > If more than one subscription is attached, <span id="email_notifications"> > is repeated, but id's must be unique. > I think it is better to have a class. > Fixed in latest patch > 2) > We have: > > - At Library: (Branch name missing, is fixed with Bug 18307) > - Public note > - Subscription details (date range) > - Email notification handling (Subscribe, Unsubscribe, Note if not logged in) > - Call number > - Info about x latest issues (table) > > Can we move Call number up? > (e.g. after "At library:", would be the same as in Staff client) See Bug 18350
Created attachment 61726 [details] [review] Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element Update: Changing ID to Class To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' link 5) Confirm this link still works as expected Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Aleisha, sorry again some more things: 1/ The style of buttons is not exactly the same (text is blue vs black) 2/ <span class="email_notifications">[% IF ( subscription.letter ) %] should be [% IF ( subscription.letter ) %] <span class="email_notifications"> To avoid an empty span element 3/ I think we should be redirected to the detail page when we subscribe/unsubscribe from the detail page.
Created attachment 61858 [details] [review] Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element Update: Changing ID to Class Update: Comment 14 fixes To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' button 5) Confirm this button works as expected and you are redirected to the detail page 6) Confirm 'Cancel' works and redirect works too 7) Go down to 'More details' and confirm the buttons work and you are redirected back to the serial-issues plage from here Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 61869 [details] [review] Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element Update: Changing ID to Class Update: Comment 14 fixes To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' button 5) Confirm this button works as expected and you are redirected to the detail page 6) Confirm 'Cancel' works and redirect works too 7) Go down to 'More details' and confirm the buttons work and you are redirected back to the serial-issues plage from here Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Re-tested, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 62309 [details] [review] Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element Update: Changing ID to Class Update: Comment 14 fixes To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' button 5) Confirm this button works as expected and you are redirected to the detail page 6) Confirm 'Cancel' works and redirect works too 7) Go down to 'More details' and confirm the buttons work and you are redirected back to the serial-issues plage from here Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Re-tested, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 62310 [details] [review] Bug 10357: Do not change the alerttype Previous patch modified the alerttype from "issue" to "issue_det" or "issue_ser". This is wrong, we do not want to modify this value, especially because it's used in C4::Letters::SendAlerts This patch uses a $referer variable instead, like it is already used in other scripts for redirection. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Aleisha, Jonathan!
This won't get ported back to 16.11.x as it is an enhancement.