Attachment 62559 Details for Bug 13835 – Bug 13835: Popup with searches: results hidden by language menu in footer

[patch] Bug 13835: Popup with searches: results hidden by language menu in footer

Bug-13835-Popup-with-searches-results-hidden-by-la.patch (text/plain), 2.74 KB, created by Marc Véron on 2017-04-21 19:45:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2017-04-21 19:45:27 UTC

Size: 2.74 KB

patch

obsolete

>From 688bb3526fcec340c4a58df0fe2d63ede53328cd Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Fri, 21 Apr 2017 21:22:44 +0200
>Subject: [PATCH] Bug 13835: Popup with searches: results hidden by language
> menu in footer
>
>Language menus in pop up windows are not necessary and can hide the contents
>(especially search results) on a narrow screen.
>
>For an example, see screenshot in comment #3
>
>This patch allows to mark pop p menus not to display the language footer.
>
>To test:
>
>- Reproduce issue from comment #3
>- Apply patch
>- Try to reproduce issue from comment #3
>  -> language menu should no longer display
>- Verify that language menu is suppresed in 'Add to ist' as well
>  (from catalog search results, select an item, Add to:...)
>
>Note: There will be more pop-ups with unwnated language selector.
>      That can be resolved in follow up bugs.
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc            | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt         | 1 +
> .../intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt   | 2 +-
> 3 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc
>index 4d59da1..fb6ffbb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc
>@@ -1,6 +1,6 @@
>         </div>
> 
>-[% IF ( languages_loop ) %]
>+[% IF ( languages_loop && ! popup_window ) %]
>     [% UNLESS ( one_language_enabled ) %]
>         <div id="changelanguage" class="navbar navbar-default navbar-fixed-bottom">
>             <div class="container-fluid">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
>index 8b52cac..9fe6473 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
>@@ -252,4 +252,5 @@ function filterByFirstLetterSurname(letter) {
> <div id="closewindow"><a href="#" class="btn btn-default btn-default close">Close</a></div>
> </div>
> </div>
>+[% SET popup_window = 1 %]
> [% INCLUDE 'intranet-bottom.inc' %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
>index 63974a9..3635a7a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
>@@ -114,6 +114,6 @@
> 
> 
> </div>
>-
>+[% SET popup_window = 1 %]
> [% INCLUDE 'intranet-bottom.inc' %]
> [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 13835: 62557 | 62558 | 62559 | 62582 | 62626