Bugzilla – Attachment 62869 Details for
Bug 17993
Do not use modal authentication with CAS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17993 - Do not use modal authentication with CAS - tags bis
Bug-17993---Do-not-use-modal-authentication-with-C.patch (text/plain), 2.35 KB, created by
Nick Clemens (kidclamp)
on 2017-04-28 20:05:25 UTC
(
hide
)
Description:
Bug 17993 - Do not use modal authentication with CAS - tags bis
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-04-28 20:05:25 UTC
Size:
2.35 KB
patch
obsolete
>From 16bb57fb98448d51ab79d595e144485e16b8e026 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Mon, 27 Mar 2017 15:19:24 +0200 >Subject: [PATCH] Bug 17993 - Do not use modal authentication with CAS - tags > bis > >Bug 12046 corrected the fact that modal dialog does not allow to use the >CAS authentication in main authentication link. This must also be >corrected in link for tags in detail tags page: "Log in to see your own >saved tags." > >Test plan : >- Enable syspref casAuthentication >- Go to OPAC, not authenticated >- Click on "Tag cloud" >- Click on "Log in to see your own saved tags" >=> Without patch you get the modal login popup >=> With patch you go to the login page opac-user.pl > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >index 4d6a428..4deb916 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >@@ -87,7 +87,14 @@ > </div> > [% IF Koha.Preference( 'opacuserlogin' ) == 1 %] > [% UNLESS ( loggedinusername ) %] >- <p><a class="loginModal-trigger" href="/cgi-bin/koha/opac-user.pl">Log in to see your own saved tags.</a></p> >+ <p> >+ [% IF Koha.Preference('casAuthentication') %] >+ [%# CAS authentication is too complicated for modal window %] >+ <a href="/cgi-bin/koha/opac-user.pl">Log in to see your own saved tags.</a> >+ [% ELSE %] >+ <a class="loginModal-trigger" href="/cgi-bin/koha/opac-user.pl">Log in to see your own saved tags.</a> >+ [% END %] >+ </p> > [% END %] > [% END %] > </fieldset> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17993
:
59549
|
59550
|
59719
|
59720
|
61642
|
62296
|
62867
|
62868
| 62869