Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in other links leading to authentication like for lists and tags.
Created attachment 59549 [details] [review] Bug 17993 - Do not use modal authentication with CAS - lists Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link of lists popup : "Log in to create your own lists" Test plan : - Enable syspref casAuthentication - Go to OPAC - Click on Lists > Log in to create your own lists => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl
Created attachment 59550 [details] [review] Bug 17993 - Do not use modal authentication with CAS - tags Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail page : "Log in to add tags" Test plan : - Enable syspref casAuthentication - Go to OPAC - Go to a record detail page opac-detail.pl - Click on "Log in to add tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl
Created attachment 59719 [details] [review] Bug 17993 - Do not use modal authentication with CAS - lists Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link of lists popup : "Log in to create your own lists" Test plan : - Enable syspref casAuthentication - Go to OPAC - Click on Lists > Log in to create your own lists => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 59720 [details] [review] Bug 17993 - Do not use modal authentication with CAS - tags Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail page : "Log in to add tags" Test plan : - Enable syspref casAuthentication - Go to OPAC - Go to a record detail page opac-detail.pl - Click on "Log in to add tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Missed a spot: opac-tags.pl Is that fixed elsewhere, or should it be fixed here?
(In reply to M. Tompsett from comment #5) > Missed a spot: opac-tags.pl > Is that fixed elsewhere, or should it be fixed here? Indeed, I'll fix this
Created attachment 61642 [details] [review] Bug 17993 - Do not use modal authentication with CAS - tags bis Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail tags page : "Log in to see your own saved tags." Test plan : - Enable syspref casAuthentication - Go to OPAC, not authenticated - Click on "Tag cloud" - Click on "Log in to see your own saved tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl
"tags bis" needs sign off. Mark, thanks a lot for your help.
Created attachment 62296 [details] [review] [SIGNED-OFF] Bug 17993 - Do not use modal authentication with CAS - tags bis Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail tags page: "Log in to see your own saved tags." Test plan : - Enable syspref casAuthentication - Go to OPAC, not authenticated - Click on "Tag cloud" - Click on "Log in to see your own saved tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 62867 [details] [review] Bug 17993 - Do not use modal authentication with CAS - lists Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link of lists popup : "Log in to create your own lists" Test plan : - Enable syspref casAuthentication - Go to OPAC - Click on Lists > Log in to create your own lists => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 62868 [details] [review] Bug 17993 - Do not use modal authentication with CAS - tags Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail page : "Log in to add tags" Test plan : - Enable syspref casAuthentication - Go to OPAC - Go to a record detail page opac-detail.pl - Click on "Log in to add tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 62869 [details] [review] Bug 17993 - Do not use modal authentication with CAS - tags bis Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail tags page: "Log in to see your own saved tags." Test plan : - Enable syspref casAuthentication - Go to OPAC, not authenticated - Click on "Tag cloud" - Click on "Log in to see your own saved tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.05, thanks Frido!
These patches have been pushed to 16.11.x and will be in 16.11.08.
Pushed to 16.05.x, for 16.05.13 release