Bugzilla – Attachment 64273 Details for
Bug 18798
Use Koha.Preference in OPAC Reading Record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18798: Use Koha.Preference in OPAC Reading Record
Bug-18798-Use-KohaPreference-in-OPAC-Reading-Recor.patch (text/plain), 7.55 KB, created by
Aleisha Amohia
on 2017-06-13 22:21:29 UTC
(
hide
)
Description:
Bug 18798: Use Koha.Preference in OPAC Reading Record
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2017-06-13 22:21:29 UTC
Size:
7.55 KB
patch
obsolete
>From 5ab1feaa2599d10ac4b602c007efae4ea0670c2c Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Tue, 13 Jun 2017 22:15:13 +0000 >Subject: [PATCH] Bug 18798: Use Koha.Preference in OPAC Reading Record > >This patch uses the Koha.Preference plugin method for the following >sysprefs: > - OPACMySummaryHTML > - OPACAmazonCoverImages > - SyndeticsEnabled > - SyndeticsCoverImages > - SyndeticsClientCode > - GoogleJackets > - BakerTaylorEnabled (Bug 17896) > - BakerTaylorBookstoreURL (Bug 17896) > >To test, apply the patch from Bug 17896 and confirm that enabling and >disabling the above sysprefs does not break anything. > >Sponsored-by: Catalyst IT >--- > .../bootstrap/en/modules/opac-readingrecord.tt | 20 ++++++++++---------- > opac/opac-readingrecord.pl | 7 ------- > 2 files changed, 10 insertions(+), 17 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >index 5140221..eadaf45 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >@@ -60,7 +60,7 @@ > </p> > [% END %] > >- [% IF Koha.Preference( 'OnSiteCheckouts' ) == 1 %] >+ [% IF ( Koha.Preference( 'OnSiteCheckouts' ) == 1 ) %] > <div id="tabs" class="toptabs"> > <ul> > <li><a href="#tabs-container" id="tab_all">All</a></li> >@@ -78,7 +78,7 @@ > <th>Item type</th> > <th>Call no.</th> > <th class="title-string">Date</th> >- [% IF ( OPACMySummaryHTML ) %] >+ [% IF ( Koha.Preference('OPACMySummaryHTML') ) %] > <th>Links</th> > [% END %] > </tr> >@@ -93,7 +93,7 @@ > [% issuetype %] > </td> > <td> >- [% IF OPACAmazonCoverImages %] >+ [% IF ( Koha.Preference('OPACAmazonCoverImages') ) %] > [% IF issue.normalized_isbn %] > <a href="http://www.amazon.com/gp/reader/[% issue.normalized_isbn %][% AmazonAssocTag %]#reader-link"><img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% issue.normalized_isbn %].01.THUMBZZZ.jpg" alt="" class="item-thumbnail" /></a> > [% ELSE %] >@@ -118,16 +118,16 @@ > [% END %] > [% END %] > >- [% IF SyndeticsEnabled && SyndeticsCoverImages %] >- [% IF using_https %] >- <img src="https://secure.syndetics.com/index.aspx?isbn=[% issue.normalized_isbn %]/SC.GIF&client=[% SyndeticsClientCode %]&type=xw10&upc=[% issue.normalized_upc %]&oclc=[% issue.normalized_oclc %]" alt="" class="item-thumbnail" /> >+ [% IF ( Koha.Preference('SyndeticsEnabled') && Koha.Preference('SyndeticsCoverImages') ) %] >+ [% IF using_https %] >+ <img src="https://secure.syndetics.com/index.aspx?isbn=[% issue.normalized_isbn %]/SC.GIF&client=[% Koha.Preference('SyndeticsClientCode') %]&type=xw10&upc=[% issue.normalized_upc %]&oclc=[% issue.normalized_oclc %]" alt="" class="item-thumbnail" /> > [% ELSE %] >- <img src="http://www.syndetics.com/index.aspx?isbn=[% issue.normalized_isbn %]/SC.GIF&client=[% SyndeticsClientCode %]&type=xw10&upc=[% issue.normalized_upc %]&oclc=[% issue.normalized_oclc %]" alt="" class="item-thumbnail" /> >+ <img src="http://www.syndetics.com/index.aspx?isbn=[% issue.normalized_isbn %]/SC.GIF&client=[% Koha.Preference('SyndeticsClientCode') %]&type=xw10&upc=[% issue.normalized_upc %]&oclc=[% issue.normalized_oclc %]" alt="" class="item-thumbnail" /> > [% END %] > [% END %] > </td> > <td> >- [% IF issue.BiblioDefaultViewmarc %] >+ [% IF issue.BiblioDefaultViewmarc %] > <a class="title" href="/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=[% issue.biblionumber |url %]">[% issue.title |html %] [% IF issue.subtitle %][% FOREACH subtitl IN issue.subtitle %][% subtitl.subfield %][% END %][% END %]</a> > [% ELSIF issue.BiblioDefaultViewisbd %] > <a class="title" href="/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=[% issue.biblionumber |url %]">[% issue.title |html %] [% IF issue.subtitle %][% FOREACH subtitl IN issue.subtitle %][% subtitl.subfield %][% END %][% END %]</a> >@@ -156,7 +156,7 @@ > <span title="Checked out"><em>(Checked out)</em></span> > [% END %] > </td> >- [% IF OPACMySummaryHTML %] >+ [% IF ( Koha.Preference('OPACMySummaryHTML') ) %] > <td>[% issue.MySummaryHTML %]</td> > [% END %] > </tr> >@@ -181,7 +181,7 @@ > <script type="text/javascript"> > //<![CDATA[ > $(document).ready(function(){ >- [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %] >+ [% IF ( Koha.Preference('GoogleJackets') ) %]KOHA.Google.GetCoverFromIsbn();[% END %] > $('#sortsubmit').hide(); > $('#order').change(function() { > $('#sortform').submit(); >diff --git a/opac/opac-readingrecord.pl b/opac/opac-readingrecord.pl >index 681261e..142a4ef 100755 >--- a/opac/opac-readingrecord.pl >+++ b/opac/opac-readingrecord.pl >@@ -129,17 +129,10 @@ if (C4::Context->preference('BakerTaylorEnabled')) { > ); > } > >-for(qw(AmazonCoverImages GoogleJackets)) { # BakerTaylorEnabled handled above >- C4::Context->preference($_) or next; >- $template->param($_=>1); >- $template->param(JacketImages=>1); >-} >- > $template->param( > READING_RECORD => $issues, > limit => $limit, > readingrecview => 1, >- OPACMySummaryHTML => $opac_summary_html ? 1 : 0, > ); > > output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 }; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18798
:
64272
|
64273
|
65955
|
82992
|
82994
|
83003