Bug 18798 - Use Koha.Preference in OPAC Reading Record
Summary: Use Koha.Preference in OPAC Reading Record
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 17896
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-13 21:57 UTC by Aleisha Amohia
Modified: 2017-11-03 10:48 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18798: Use Koha.Preference in OPAC Reading Record (7.55 KB, patch)
2017-06-13 22:20 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 18798: Use Koha.Preference in OPAC Reading Record (7.55 KB, patch)
2017-06-13 22:21 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 18798: Use Koha.Preference in OPAC Reading Record (7.65 KB, patch)
2017-08-14 12:51 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2017-06-13 21:57:40 UTC
Should not be passing the preference from the pl file - can check the preference using template plugin Koha.Preference
Comment 1 Aleisha Amohia 2017-06-13 22:20:05 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2017-06-13 22:21:29 UTC
Created attachment 64273 [details] [review]
Bug 18798: Use Koha.Preference in OPAC Reading Record

This patch uses the Koha.Preference plugin method for the following
sysprefs:
 - OPACMySummaryHTML
 - OPACAmazonCoverImages
 - SyndeticsEnabled
 - SyndeticsCoverImages
 - SyndeticsClientCode
 - GoogleJackets
 - BakerTaylorEnabled (Bug 17896)
 - BakerTaylorBookstoreURL (Bug 17896)

To test, apply the patch from Bug 17896 and confirm that enabling and
disabling the above sysprefs does not break anything.

Sponsored-by: Catalyst IT
Comment 3 Owen Leonard 2017-08-14 12:51:25 UTC
Created attachment 65955 [details] [review]
[SIGNED-OFF] Bug 18798: Use Koha.Preference in OPAC Reading Record

This patch uses the Koha.Preference plugin method for the following
sysprefs:
 - OPACMySummaryHTML
 - OPACAmazonCoverImages
 - SyndeticsEnabled
 - SyndeticsCoverImages
 - SyndeticsClientCode
 - GoogleJackets
 - BakerTaylorEnabled (Bug 17896)
 - BakerTaylorBookstoreURL (Bug 17896)

To test, apply the patch from Bug 17896 and confirm that enabling and
disabling the above sysprefs does not break anything.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I'm not able to test Syndetics and BakerTaylor, but everything else
works correctly.
Comment 4 Marcel de Rooy 2017-11-03 10:48:30 UTC
[% IF GoogleJackets %]

Forgotten ?