Should not be passing the preference from the pl file - can check the preference using template plugin Koha.Preference
Created attachment 64272 [details] [review] Bug 18798: Use Koha.Preference in OPAC Reading Record This patch uses the Koha.Preference plugin method for the following sysprefs: - OPACMySummaryHTML - OPACAmazonCoverImages - SyndeticsEnabled - SyndeticsCoverImages - SyndeticsClientCode - GoogleJackets - BakerTaylorEnabled (Bug 17986) - BakerTaylorBookstoreURL (Bug 17986) To test, apply the patch from Bug 17986 and confirm that enabling and disabling the above sysprefs does not break anything. Sponsored-by: Catalyst IT
Created attachment 64273 [details] [review] Bug 18798: Use Koha.Preference in OPAC Reading Record This patch uses the Koha.Preference plugin method for the following sysprefs: - OPACMySummaryHTML - OPACAmazonCoverImages - SyndeticsEnabled - SyndeticsCoverImages - SyndeticsClientCode - GoogleJackets - BakerTaylorEnabled (Bug 17896) - BakerTaylorBookstoreURL (Bug 17896) To test, apply the patch from Bug 17896 and confirm that enabling and disabling the above sysprefs does not break anything. Sponsored-by: Catalyst IT
Created attachment 65955 [details] [review] [SIGNED-OFF] Bug 18798: Use Koha.Preference in OPAC Reading Record This patch uses the Koha.Preference plugin method for the following sysprefs: - OPACMySummaryHTML - OPACAmazonCoverImages - SyndeticsEnabled - SyndeticsCoverImages - SyndeticsClientCode - GoogleJackets - BakerTaylorEnabled (Bug 17896) - BakerTaylorBookstoreURL (Bug 17896) To test, apply the patch from Bug 17896 and confirm that enabling and disabling the above sysprefs does not break anything. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> I'm not able to test Syndetics and BakerTaylor, but everything else works correctly.
[% IF GoogleJackets %] Forgotten ?
Created attachment 82992 [details] [review] Bug 18798: Use Koha.Preference in OPAC Reading Record This patch uses the Koha.Preference plugin method for the following sysprefs: - OPACMySummaryHTML - OPACAmazonCoverImages - SyndeticsEnabled - SyndeticsCoverImages - SyndeticsClientCode - GoogleJackets - BakerTaylorEnabled (Bug 17896) - BakerTaylorBookstoreURL (Bug 17896) To test, apply the patch from Bug 17896 and confirm that enabling and disabling the above sysprefs does not break anything. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> I'm not able to test Syndetics and BakerTaylor, but everything else works correctly.
Created attachment 82994 [details] [review] Bug 18798: (follow-up) Use Koha.preference for GoogleJackets This patch converts the check for the GoogleJackets preference to use the Koha.preference() style. To test, apply the patch and log in to the OPAC as a user who has a checkout history. View the "your reading history" page with GoogleJackets both enabled and disabled. Everything should work correctly.
Created attachment 83003 [details] [review] Bug 18798: (follow-up) Use Koha.preference for GoogleJackets This patch converts the check for the GoogleJackets preference to use the Koha.preference() style. To test, apply the patch and log in to the OPAC as a user who has a checkout history. View the "your reading history" page with GoogleJackets both enabled and disabled. Everything should work correctly. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Blocked by bug 17896.