Attachment 65340 Details for Bug 18857 – Bug 18857 - Add buttons to left hand side of circ rules table

[patch] Bug 18857 - Add buttons to left hand side of circ rules table

Bug-18857---Add-buttons-to-left-hand-side-of-circ-.patch (text/plain), 4.88 KB, created by Nick Clemens (kidclamp) on 2017-07-31 12:52:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-07-31 12:52:41 UTC

Size: 4.88 KB

patch

obsolete

>From 57a577c815ee0c4e313de8eaf64e076a062aec42 Mon Sep 17 00:00:00 2001
>From: Liz Rea <liz@catalyst.net.nz>
>Date: Tue, 27 Jun 2017 11:42:44 +1200
>Subject: [PATCH] Bug 18857 - Add buttons to left hand side of circ rules table
>
>To test:
>* Apply this patch
>* Define some rules in the interface using the left hand buttons
>* Define some rules in the interface using the right hand buttons (scroll to see)
>* Delete some rules in the interface using the left hand buttons
>* Delete some rules in the interface using the right hand buttons (scroll to see)
>* Choose a rule to edit using the left hand buttons
>* Edit the rule, saving using the left hand button
>* Edit a rule, but clear the values using the left hand buttons
>* Choose a rule to edit using the right hand buttons (scroll to see)
>* Edit the rule, saving using the right hand buttons (scroll to see)
>* Edit a rule, but clear the values using the right hand buttons (scroll to see)
>
>Signed-off-by: Guillaume <guillaume_lair@ville-limoges.fr>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt  | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 0283d80..484aba0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -168,6 +168,7 @@ $(document).ready(function() {
>             <tr>
>                 <th>Patron category</th>
>                 <th>Item type</th>
>+                <th>Actions</th>
>                 <th>Current checkouts allowed</th>
>                 <th>Current on-site checkouts allowed</th>
>                 <th>Loan period</th>
>@@ -211,6 +212,11 @@ $(document).ready(function() {
> 									[% rule.translated_description %]
> 								[% END %]
> 							</td>
>+                                                        <td class="actions">
>+                                                          <a href="#" class="editrule btn btn-default btn-xs"><i class="fa fa-pencil"></i> Edit</a>
>+                                                          <a class="btn btn-default btn-xs delete" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete&amp;itemtype=[% rule.itemtype %]&amp;categorycode=[% rule.categorycode %]&amp;branch=[% rule.current_branch %]"><i class="fa fa-trash"></i> Delete</a>
>+                                                        </td>
>+
> 							<td>[% IF ( rule.unlimited_maxissueqty ) %]
> 									Unlimited
> 								[% ELSE %]
>@@ -295,7 +301,8 @@ $(document).ready(function() {
>                                                         <td class="actions">
>                                                           <a href="#" class="editrule btn btn-default btn-xs"><i class="fa fa-pencil"></i> Edit</a>
>                                                           <a class="btn btn-default btn-xs delete" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete&amp;itemtype=[% rule.itemtype %]&amp;categorycode=[% rule.categorycode %]&amp;branch=[% rule.current_branch %]"><i class="fa fa-trash"></i> Delete</a>
>-							</td>
>+                                                        </td>
>+
>                 	</tr>
>             	[% END %]
>                 <tr id="edit_row">
>@@ -315,6 +322,11 @@ $(document).ready(function() {
>                         [% END %]
>                         </select>
>                     </td>
>+                    <td class="actions">
>+                        <input type="hidden" name="branch" value="[% current_branch %]"/>
>+                        <button type="submit" class="btn btn-default btn-xs"><i class="fa fa-save"></i> Save</button>
>+                        <button name="cancel" class="clear_edit btn btn-default btn-xs"><i class="fa fa-undo"></i> Clear</button>
>+                    </td>
>                     <td><input type="text" name="maxissueqty" id="maxissueqty" size="3" /></td>
>                     <td><input type="text" name="maxonsiteissueqty" id="maxonsiteissueqty" size="3" /></td>
>                     <td><input type="text" name="issuelength" id="issuelength" size="3" /> </td>
>@@ -395,6 +407,7 @@ $(document).ready(function() {
>                     <tr>
>                       <th>Patron category</th>
>                       <th>Item type</th>
>+                      <th>&nbsp;</th>
>                       <th>Current checkouts allowed</th>
>                       <th>Current on-site checkouts allowed</th>
>                       <th>Loan period</th>
>@@ -420,7 +433,7 @@ $(document).ready(function() {
>                       <th>Item level holds</th>
>                       <th>Article requests</th>
>                       <th>Rental discount (%)</th>
>-                      <th colspan="2">&nbsp;</th>
>+                      <th>&nbsp;</th>
>                     </tr>
>                   </tfoot>
>                 </tbody>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18857: 64663 | 64700 | 65340 | 65341