System with lots of circulation rules face an unreasonable level of frustration when wanting to edit a rule they have already defined. Usually, a staff user will know which rule they want to edit without scrolling to the end of the table, and they often lose track of which row they are looking for before clicking edit (or delete). We should provide them buttons that they don't have to scroll to see. My reason for suggesting this is based on observations of librarians trying to work quickly with the rules. The short story is: they can't, because of the frustrating scrolling.
Created attachment 64663 [details] [review] Bug 18857 - Add buttons to left hand side of circ rules table To test: * Apply this patch * Define some rules in the interface using the left hand buttons * Define some rules in the interface using the right hand buttons (scroll to see) * Delete some rules in the interface using the left hand buttons * Delete some rules in the interface using the right hand buttons (scroll to see) * Choose a rule to edit using the left hand buttons * Edit the rule, saving using the left hand button * Edit a rule, but clear the values using the left hand buttons * Choose a rule to edit using the right hand buttons (scroll to see) * Edit the rule, saving using the right hand buttons (scroll to see) * Edit a rule, but clear the values using the right hand buttons (scroll to see)
On circ rules table we have used successfully buttons to left hand side to change some existing values, add and delete a new patron category.
Patch tested with a sandbox, by Guillaume <guillaume_lair@ville-limoges.fr>
Created attachment 64700 [details] [review] Bug 18857 - Add buttons to left hand side of circ rules table To test: * Apply this patch * Define some rules in the interface using the left hand buttons * Define some rules in the interface using the right hand buttons (scroll to see) * Delete some rules in the interface using the left hand buttons * Delete some rules in the interface using the right hand buttons (scroll to see) * Choose a rule to edit using the left hand buttons * Edit the rule, saving using the left hand button * Edit a rule, but clear the values using the left hand buttons * Choose a rule to edit using the right hand buttons (scroll to see) * Edit the rule, saving using the right hand buttons (scroll to see) * Edit a rule, but clear the values using the right hand buttons (scroll to see) Signed-off-by: Guillaume <guillaume_lair@ville-limoges.fr>
Created attachment 65340 [details] [review] Bug 18857 - Add buttons to left hand side of circ rules table To test: * Apply this patch * Define some rules in the interface using the left hand buttons * Define some rules in the interface using the right hand buttons (scroll to see) * Delete some rules in the interface using the left hand buttons * Delete some rules in the interface using the right hand buttons (scroll to see) * Choose a rule to edit using the left hand buttons * Edit the rule, saving using the left hand button * Edit a rule, but clear the values using the left hand buttons * Choose a rule to edit using the right hand buttons (scroll to see) * Edit the rule, saving using the right hand buttons (scroll to see) * Edit a rule, but clear the values using the right hand buttons (scroll to see) Signed-off-by: Guillaume <guillaume_lair@ville-limoges.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 65341 [details] [review] Bug 18857 (QA Followup) Add title to lower 'Action' header These were showing as blank, for consistency seems like we should label as 'Actions'
I disagree with Nick's change, it isn't how the column is labelled currently and I don't see the point to having it in the table footer. Consistency is usually good, there doesn't seem to be much point to it in this case. Cheers, Liz
Comment on attachment 65341 [details] [review] Bug 18857 (QA Followup) Add title to lower 'Action' header Will not be pushed, move to its own bug report if you want to discuss more about it.
Pushed to master for 17.11, thanks to everybody involved!
awesome thank you Jonathan!
Enhancement not pushed to 17.05.x