Bugzilla – Attachment 68722 Details for
Bug 19274
Translatability: Fix new splitting problems related to database warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19274: Translatability: Fix new splitting problems related to database warnings
Bug-19274-Translatability-Fix-new-splitting-proble.patch (text/plain), 5.53 KB, created by
Kyle M Hall (khall)
on 2017-10-27 14:20:40 UTC
(
hide
)
Description:
Bug 19274: Translatability: Fix new splitting problems related to database warnings
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-10-27 14:20:40 UTC
Size:
5.53 KB
patch
obsolete
>From 725649b4fe8b77f2e59faaa9c439ae8de225d4e6 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Thu, 7 Sep 2017 17:31:12 +0200 >Subject: [PATCH] Bug 19274: Translatability: Fix new splitting problems > related to database warnings > >The warnings about database problems introduce new translatability problems, >mostly related to sentence splitting by html tags. > >To test: >- Verify that text changes make sense >- Apply patch, verify that messages properly. > Note: To force display you might want to add '1 ||' to the related > if statements, including line 134, e.g. [% IF 1 || has_ai_issues %] >- Bonus test: Go through an translation cicle and verify that fragemts as > mentioned in initial comment are gone. > >(Amended to fix tiny typo) > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 33 ++++++++++++------------ > 1 file changed, 16 insertions(+), 17 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index 11e390c..13357e1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -1,3 +1,4 @@ >+[% USE HtmlTags %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › About Koha</title> >@@ -139,40 +140,38 @@ > > [% IF has_ai_issues %] > <h2>Data problems</h2> >- <p> >- Some of your tables have problems with their auto_increment values which may lead to data loss. <strong>You should not ignore this warning</strong>. >- The problem is that InnoDB does not keep auto_increment across SQL server restarts (it is only set in memory). >- So on server startup the auto_increment values are set to max(table.id)+1. >- </p> >- <p> >- See the <a href="https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix">related wiki page</a> to know how to avoid this problem. >+ <p>Some of your tables have problems with their auto_increment values which may lead to data loss.</p> >+ <p><strong>You should not ignore this warning.</strong></p> >+ <p>The problem is that InnoDB does not keep auto_increment across SQL server restarts (it is only set in memory). So on server startup the auto_increment values are set to max(table.id)+1.</p> >+ <p>To know how to avoid this problem see the related wiki page: >+ <a href="https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix">DBMS auto increment fix</a> > </p> > > <h3>Problems found</h3> > [% IF ai_patrons %] > <h4>Patrons</h4> >- <p>The following ids exist in both <strong>borrowers</strong> and <strong>deletedborrowers</strong> tables: >- [% FOR p IN ai_patrons %][% p.borrowernumber %][% UNLESS loop.last %], [% END %][% END %]</p> >+ <p>The following ids exist in both tables [% "borrowers" | $HtmlTags tag="strong" %] and [% "deletedborrowers" | $HtmlTags tag="strong" %]:</p> >+ <p>[% FOR p IN ai_patrons %][% p.borrowernumber %][% UNLESS loop.last %], [% END %][% END %]</p> > [% END %] > [% IF ai_biblios %] > <h4>Biblios</h4> >- <p>The following ids exist in both <strong>biblio</strong> and <strong>deletedbiblio</strong> tables: >- [% FOR b IN ai_biblios %][% b.biblionumber %][% UNLESS loop.last %], [% END %][% END %]</p> >+ <p>The following ids exist in both tables [% "biblio" | $HtmlTags tag="strong" %] and [% "deletedbiblio" | $HtmlTags tag="strong" %]:</p> >+ <p>[% FOR b IN ai_biblios %][% b.biblionumber %][% UNLESS loop.last %], [% END %][% END %]</p> > [% END %] > [% IF ai_items %] > <h4>Items</h4> >- <p>The following ids exist in both <strong>items</strong> and <strong>deleteditems</strong> tables: >- [% FOR i IN ai_items %][% i.itemnumber %][% UNLESS loop.last %], [% END %][% END %]</p> >+ <p>The following ids exist in both tables [% "items" | $HtmlTags tag="strong" %] and [% "deleteditems" | $HtmlTags tag="strong" %]:</p> >+ <p>[% FOR i IN ai_items %][% i.itemnumber %][% UNLESS loop.last %], [% END %][% END %]</p> > [% END %] > [% IF ai_checkouts %] > <h4>Checkouts</h4> >- <p>The following ids exist in both <strong>issues</strong> and <strong>old_issues</strong> tables: >- [% FOR c IN ai_checkouts %][% c.issue_id %][% UNLESS loop.last %], [% END %][% END %]</p> >+ <p>The following ids exist in both tables [% "issues" | $HtmlTags tag="strong" %] and [% "old_issues" | $HtmlTags tag="strong" %]:</p> >+ <p>[% FOR c IN ai_checkouts %][% c.issue_id %][% UNLESS loop.last %], [% END %][% END %]</p> > [% END %] > [% IF ai_holds %] > <h4>Holds</h4> >- <p>The following ids exist in both <strong>holds</strong> and <strong>old_reserves</strong> table: >- [% FOR h IN ai_holds %][% h.reserve_id %][% UNLESS loop.last %], [% END %][% END %]</p> >+ <p>The following ids exist in both tables [% "holds" | $HtmlTags tag="strong" %] and [% "old_reserves" | $HtmlTags tag="strong" %]:</p> >+ <p>[% FOR h IN ai_holds %][% h.reserve_id %][% UNLESS loop.last %], [% END %][% END %]</p> > [% END %] > <br/> > [% END %] >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19274
:
66941
|
66942
|
67803
| 68722