Bug 19274 - Translatability: Fix new splitting problems related to database warnings
Summary: Translatability: Fix new splitting problems related to database warnings
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 18931
Blocks:
  Show dependency treegraph
 
Reported: 2017-09-07 15:18 UTC by Marc Véron
Modified: 2017-10-27 19:12 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19274: Translatability: Fix new splitting problems related to database warnings (5.43 KB, patch)
2017-09-07 15:41 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 19274: Translatability: Fix new splitting problems related to database warnings (5.42 KB, patch)
2017-09-07 15:44 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 19274: Translatability: Fix new splitting problems related to database warnings (5.48 KB, patch)
2017-10-07 14:17 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 19274: Translatability: Fix new splitting problems related to database warnings (5.53 KB, patch)
2017-10-27 14:20 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2017-09-07 15:18:24 UTC
The warnings about database problems introduce new translatability problems, mostly related to sentence splitting by html tags.
Examples for isolated fragments in Pootle:
See the
The following ids exist in both
biblio
(...)
Comment 1 Marc Véron 2017-09-07 15:41:00 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2017-09-07 15:44:30 UTC
Created attachment 66942 [details] [review]
Bug 19274: Translatability: Fix new splitting problems related to database warnings

The warnings about database problems introduce new translatability problems,
mostly related to sentence splitting by html tags.

To test:
- Verify that text changes make sense
- Apply patch, verify that messages properly.
  Note: To force display you might want to add '1 ||' to the related
  if statements, including line 134,  e.g. [% IF 1 || has_ai_issues %]
- Bonus test: Go through an translation cicle and verify that fragemts as
  mentioned in initial comment are gone.

(Amended to fix tiny typo)
Comment 3 Katrin Fischer 2017-10-07 14:17:30 UTC
Created attachment 67803 [details] [review]
Bug 19274: Translatability: Fix new splitting problems related to database warnings

The warnings about database problems introduce new translatability problems,
mostly related to sentence splitting by html tags.

To test:
- Verify that text changes make sense
- Apply patch, verify that messages properly.
  Note: To force display you might want to add '1 ||' to the related
  if statements, including line 134,  e.g. [% IF 1 || has_ai_issues %]
- Bonus test: Go through an translation cicle and verify that fragemts as
  mentioned in initial comment are gone.

(Amended to fix tiny typo)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall 2017-10-27 14:20:40 UTC
Created attachment 68722 [details] [review]
Bug 19274: Translatability: Fix new splitting problems related to database warnings

The warnings about database problems introduce new translatability problems,
mostly related to sentence splitting by html tags.

To test:
- Verify that text changes make sense
- Apply patch, verify that messages properly.
  Note: To force display you might want to add '1 ||' to the related
  if statements, including line 134,  e.g. [% IF 1 || has_ai_issues %]
- Bonus test: Go through an translation cicle and verify that fragemts as
  mentioned in initial comment are gone.

(Amended to fix tiny typo)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Jonathan Druart 2017-10-27 19:12:00 UTC
Pushed to master for 17.11, thanks to everybody involved!