Bugzilla – Attachment 68800 Details for
Bug 19536
Odd number of elements in anonymous hash in svc/bib
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19536: Odd number of elements in anonymous hash in svc/bib
Bug-19536-Odd-number-of-elements-in-anonymous-hash.patch (text/plain), 2.21 KB, created by
Katrin Fischer
on 2017-10-28 11:08:27 UTC
(
hide
)
Description:
Bug 19536: Odd number of elements in anonymous hash in svc/bib
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-10-28 11:08:27 UTC
Size:
2.21 KB
patch
obsolete
>From 2c3728af29211ac9bc10834dba22e8a6442280e1 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 27 Oct 2017 11:38:31 +0200 >Subject: [PATCH] Bug 19536: Odd number of elements in anonymous hash in > svc/bib > >Resolve: >Odd number of elements in anonymous hash at svc/bib line 69. >Odd number of elements in anonymous hash at svc/bib line 118. > >You can see such warnings when testing the Rancor editor. > >Replacing url_param by param in fetch_bib since it is a GET call. >Not sure about doing the same in update_bib since that is a POST. >The scalar context will resolve the odd number warns. > >Adding a scalar in svc/new_bib too. > >Test plan: >Try URL /cgi-bin/koha/svc/bib/[number] with and without the patch. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > svc/bib | 4 ++-- > svc/new_bib | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/svc/bib b/svc/bib >index 2e5f38d..0b9d621 100755 >--- a/svc/bib >+++ b/svc/bib >@@ -68,7 +68,7 @@ sub fetch_bib { > my $biblionumber = shift; > my $record = GetMarcBiblio({ > biblionumber => $biblionumber, >- embed_items => $query->url_param('items') }); >+ embed_items => scalar $query->param('items') }); > if (defined $record) { > print $query->header(-type => 'text/xml',-charset => 'utf-8',); > print $record->as_xml_record(); >@@ -117,7 +117,7 @@ sub update_bib { > ModBiblio( $record, $biblionumber, '' ); > my $new_record = GetMarcBiblio({ > biblionumber => $biblionumber, >- embed_items => $query->url_param('items') }); >+ embed_items => scalar $query->url_param('items') }); > > $result->{'status'} = "ok"; > $result->{'biblionumber'} = $biblionumber; >diff --git a/svc/new_bib b/svc/new_bib >index fc9be48..4f44d7e 100755 >--- a/svc/new_bib >+++ b/svc/new_bib >@@ -86,7 +86,7 @@ sub add_bib { > > $new_record = GetMarcBiblio({ > biblionumber => $biblionumber, >- embed_items => $query->url_param('items') }); >+ embed_items => scalar $query->url_param('items') }); > $result->{'status'} = "ok"; > $result->{'biblionumber'} = $biblionumber; > my $xml = $new_record->as_xml_record(); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19536
:
68673
|
68800
|
69128