Bug 19536 - Odd number of elements in anonymous hash in svc/bib
Summary: Odd number of elements in anonymous hash in svc/bib
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Marcel de Rooy
QA Contact: Nick Clemens
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-27 09:34 UTC by Marcel de Rooy
Modified: 2017-11-26 16:26 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19536: Odd number of elements in anonymous hash in svc/bib (2.19 KB, patch)
2017-10-27 09:57 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 19536: Odd number of elements in anonymous hash in svc/bib (2.21 KB, patch)
2017-10-28 11:08 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 19536: Odd number of elements in anonymous hash in svc/bib (2.26 KB, patch)
2017-11-13 16:00 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2017-10-27 09:34:05 UTC
Testing Rancor gave me:
Odd number of elements in anonymous hash at /usr/share/koha/masterclone/svc/bib line 69.
Odd number of elements in anonymous hash at /usr/share/koha/masterclone/svc/bib line 118.
Odd number of elements in anonymous hash at /usr/share/koha/masterclone/svc/bib line 69.

Called in koha-tmpl/intranet-tmpl/lib/koha/cateditor/koha-backend.js
Comment 1 Marcel de Rooy 2017-10-27 09:57:07 UTC
Created attachment 68673 [details] [review]
Bug 19536: Odd number of elements in anonymous hash in svc/bib

Resolve:
Odd number of elements in anonymous hash at svc/bib line 69.
Odd number of elements in anonymous hash at svc/bib line 118.

You can see such warnings when testing the Rancor editor.

Replacing url_param by param in fetch_bib since it is a GET call.
Not sure about doing the same in update_bib since that is a POST.
The scalar context will resolve the odd number warns.

Adding a scalar in svc/new_bib too.

Test plan:
Try URL /cgi-bin/koha/svc/bib/[number] with and without the patch.
Comment 2 Katrin Fischer 2017-10-28 11:08:27 UTC
Created attachment 68800 [details] [review]
Bug 19536: Odd number of elements in anonymous hash in svc/bib

Resolve:
Odd number of elements in anonymous hash at svc/bib line 69.
Odd number of elements in anonymous hash at svc/bib line 118.

You can see such warnings when testing the Rancor editor.

Replacing url_param by param in fetch_bib since it is a GET call.
Not sure about doing the same in update_bib since that is a POST.
The scalar context will resolve the odd number warns.

Adding a scalar in svc/new_bib too.

Test plan:
Try URL /cgi-bin/koha/svc/bib/[number] with and without the patch.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Nick Clemens 2017-11-13 16:00:03 UTC
Created attachment 69128 [details] [review]
Bug 19536: Odd number of elements in anonymous hash in svc/bib

Resolve:
Odd number of elements in anonymous hash at svc/bib line 69.
Odd number of elements in anonymous hash at svc/bib line 118.

You can see such warnings when testing the Rancor editor.

Replacing url_param by param in fetch_bib since it is a GET call.
Not sure about doing the same in update_bib since that is a POST.
The scalar context will resolve the odd number warns.

Adding a scalar in svc/new_bib too.

Test plan:
Try URL /cgi-bin/koha/svc/bib/[number] with and without the patch.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Jonathan Druart 2017-11-26 16:26:28 UTC
Pushed to master for 17.11, thanks to everybody involved!