Bugzilla – Attachment 69439 Details for
Bug 19729
Lists pages in OPAC are missing an HTML link element in last breadcrumb
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC
Bug-19729-Adds-link-elements-in-HTML-to-lists-page.patch (text/plain), 3.01 KB, created by
Simon Pouchol
on 2017-12-01 16:08:35 UTC
(
hide
)
Description:
Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC
Filename:
MIME Type:
Creator:
Simon Pouchol
Created:
2017-12-01 16:08:35 UTC
Size:
3.01 KB
patch
obsolete
>From c147159960c784baa12dd971d50e70330f83c5f5 Mon Sep 17 00:00:00 2001 >From: Simon Pouchol <simon.pouchol@biblibre.com> >Date: Fri, 1 Dec 2017 16:59:38 +0100 >Subject: [PATCH] Bug 19729: Adds link elements in HTML to lists pages > breadcrumbs in OPAC > >To match every other page in the OPAC and ease CSS styling, there should be links to current page on last breadcrumbs in lists pages. > >Test plan: >1-Go to /cgi-bin/koha/opac-shelves.pl >2-Notice that there are no links on the last breadcrumb in every page (my lists, public lists, create list, individual list page) >3-Apply patch >4-Reload page, and notice there are now links, pointing to current page (#) >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index e6e81ab..c6e2511 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -41,33 +41,33 @@ > [% IF op != 'list' %] > <li><a href="/cgi-bin/koha/opac-shelves.pl">Lists</a></li> > [% ELSE %] >- <li>Lists</li> >+ <li><a href="#">Lists</a></li> > [% END %] > > [% IF shelf and shelf.is_private %] > [% IF op == 'view' OR op == 'edit_form' %] > <li><span class="divider">›</span> <a href="/cgi-bin/koha/opac-shelves.pl?op=list&category=[% PRIVATE %]">Your lists</a></li> > [% ELSE %] >- <li><span class="divider">›</span> Your lists</li> >+ <li><span class="divider">›</span> <a href="#">Your lists</a></li> > [% END %] > [% ELSIF shelf AND shelf.is_public %] > [% IF op == 'view' %] > <li><span class="divider">›</span> <a href="/cgi-bin/koha/opac-shelves.pl?op=list&category=[% PUBLIC %]">Public lists</a></li> > [% ELSE %] >- <li><span class="divider">›</span> Public lists</li> >+ <li><span class="divider">›</span> <a href="#">Public lists</a></li> > [% END %] > [% END %] > > [% IF op == 'view' %] >- <li><span class="divider">›</span> Contents of <i>[% shelf.shelfname | html %]</i></li> >+ <li><span class="divider">›</span> <a href="#">Contents of <i>[% shelf.shelfname | html %]</i></a></li> > [% END %] > > [% IF op == 'add_form' %] >- <li><span class="divider">›</span> Create new list</li> >+ <li><span class="divider">›</span> <a href="#">Create new list</a></li> > [% END %] > > [% IF op == 'edit_form' %] >- <li><span class="divider">›</span> Edit list <i>[% shelf.shelfname | html %]</i></li> >+ <li><span class="divider">›</span> <a href="#">Edit list <i>[% shelf.shelfname | html %]</i></a></li> > [% END %] > > </ul> <!-- / .breadcrumb --> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19729
:
69439
|
69456
|
70061