Bug 19729 - Lists pages in OPAC are missing an HTML link element in last breadcrumb
Summary: Lists pages in OPAC are missing an HTML link element in last breadcrumb
Status: RESOLVED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Simon Pouchol
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-01 15:47 UTC by Simon Pouchol
Modified: 2023-10-01 14:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC (3.01 KB, patch)
2017-12-01 16:08 UTC, Simon Pouchol
Details | Diff | Splinter Review
Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC (3.06 KB, patch)
2017-12-01 20:20 UTC, Dominic Pichette
Details | Diff | Splinter Review
Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC (3.12 KB, patch)
2017-12-21 16:04 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pouchol 2017-12-01 15:47:59 UTC

    
Comment 1 Simon Pouchol 2017-12-01 16:08:35 UTC Comment hidden (obsolete)
Comment 2 Dominic Pichette 2017-12-01 20:20:19 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2017-12-21 16:04:59 UTC
Created attachment 70061 [details] [review]
Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC

To match every other page in the OPAC and ease CSS styling, there should be links to current page on last breadcrumbs in lists pages.

Test plan:
1-Go to /cgi-bin/koha/opac-shelves.pl
2-Notice that there are no links on the last breadcrumb in every page (my lists, public lists, create list, individual list page)
3-Apply patch
4-Reload page, and notice there are now links, pointing to current page (#)

Signed-off-by: Dominic Pichette <dominic@inlibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Jonathan Druart 2017-12-21 18:02:07 UTC
on href="#" we need to call preventDefault() or the scrollback will hit the top of the page.
Apparently other pages have the same problem.

Owen, do we need to take care of that?
Comment 5 Owen Leonard 2017-12-21 18:32:26 UTC
To be perfectly honest I'm not sure why the last breadcrumb was ever a link. How is it useful to make it a dummy link? That seems very confusing. I don't know why 2013 me did that.

I would prefer to remove all the links, and perhaps wrap the inactive last breadcrumb in a <span> with a consistent class.
Comment 6 Katrin Fischer 2018-02-08 06:48:19 UTC
I like Owen's suggestion, it makes sense to me. Should we move this onto a bug to change this globally?
Comment 7 Katrin Fischer 2023-10-01 14:30:02 UTC
It looks like we resolved this when re-working the breadcrumbs fro accessibility.