Created attachment 69439 [details] [review] Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC To match every other page in the OPAC and ease CSS styling, there should be links to current page on last breadcrumbs in lists pages. Test plan: 1-Go to /cgi-bin/koha/opac-shelves.pl 2-Notice that there are no links on the last breadcrumb in every page (my lists, public lists, create list, individual list page) 3-Apply patch 4-Reload page, and notice there are now links, pointing to current page (#)
Created attachment 69456 [details] [review] Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC To match every other page in the OPAC and ease CSS styling, there should be links to current page on last breadcrumbs in lists pages. Test plan: 1-Go to /cgi-bin/koha/opac-shelves.pl 2-Notice that there are no links on the last breadcrumb in every page (my lists, public lists, create list, individual list page) 3-Apply patch 4-Reload page, and notice there are now links, pointing to current page (#) Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Created attachment 70061 [details] [review] Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC To match every other page in the OPAC and ease CSS styling, there should be links to current page on last breadcrumbs in lists pages. Test plan: 1-Go to /cgi-bin/koha/opac-shelves.pl 2-Notice that there are no links on the last breadcrumb in every page (my lists, public lists, create list, individual list page) 3-Apply patch 4-Reload page, and notice there are now links, pointing to current page (#) Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
on href="#" we need to call preventDefault() or the scrollback will hit the top of the page. Apparently other pages have the same problem. Owen, do we need to take care of that?
To be perfectly honest I'm not sure why the last breadcrumb was ever a link. How is it useful to make it a dummy link? That seems very confusing. I don't know why 2013 me did that. I would prefer to remove all the links, and perhaps wrap the inactive last breadcrumb in a <span> with a consistent class.
I like Owen's suggestion, it makes sense to me. Should we move this onto a bug to change this globally?
It looks like we resolved this when re-working the breadcrumbs fro accessibility.