Bugzilla – Attachment 74825 Details for
Bug 20592
updateitem.pl causes database errors when empty non-public item notes updated
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20592: Checks for itemnumber sooner
Bug-20592-Checks-for-itemnumber-sooner.patch (text/plain), 1.22 KB, created by
Jonathan Druart
on 2018-04-24 18:55:14 UTC
(
hide
)
Description:
Bug 20592: Checks for itemnumber sooner
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-04-24 18:55:14 UTC
Size:
1.22 KB
patch
obsolete
>From 5121a7907d275c3ddad9d19ed83d30c6c4758f2d Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 17 Apr 2018 23:59:58 +0000 >Subject: [PATCH] Bug 20592: Checks for itemnumber sooner > >Two lines of code and move them earlier. >Add a check to make sure there are changes. >--- > C4/Items.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index e7279ff8a1..d2c66f8e6f 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -557,6 +557,9 @@ sub ModItem { > my $log_action = $additional_params->{log_action} // 1; > my $unlinked_item_subfields = $additional_params->{unlinked_item_subfields}; > >+ return unless %$item; >+ $item->{'itemnumber'} = $itemnumber or return; >+ > # if $biblionumber is undefined, get it from the current item > unless (defined $biblionumber) { > $biblionumber = _get_single_item_column('biblionumber', $itemnumber); >@@ -566,8 +569,6 @@ sub ModItem { > $item->{'more_subfields_xml'} = _get_unlinked_subfields_xml($unlinked_item_subfields); > }; > >- $item->{'itemnumber'} = $itemnumber or return; >- > my @fields = qw( itemlost withdrawn damaged ); > > # Only call GetItem if we need to set an "on" date field >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20592
:
74286
|
74399
|
74400
|
74824
|
74825
|
74826
|
78453
|
78454
|
80728
|
80731
|
80732