Attachment 75624 Details for Bug 20832 – Bug 20832: Fix opac user profile page when there is overdue fine and no rental charge

[patch] Bug 20832: Fix opac user profile page when there is overdue fine and no rental charge

Bug-20832-Fix-opac-user-profile-page-when-there-is.patch (text/plain), 1.46 KB, created by Josef Moravec on 2018-05-29 11:50:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2018-05-29 11:50:24 UTC

Size: 1.46 KB

patch

obsolete

>From cf30c81e65fe18dab1c542a40ed97eb7ab2ef6af Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Tue, 29 May 2018 11:48:14 +0000
>Subject: [PATCH] Bug 20832: Fix opac user profile page when there is overdue
> fine and no rental charge
>
>Test plan:
>0) Do not apply the patch
>1) Have an overdue fine linked with specific item currently checked out
>to your patron
>2) Do not have any unpaid rental fees
>3) Go to this patron profile in opac - page opac-user.pl
>4) The page crashes with "Can't call method "get_column" on an undefined
>value at
>/usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217" in log
>5) Apply the patch
>6) Restart plack
>7) The page should working and show the right amounts for fines
>---
> opac/opac-user.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-user.pl b/opac/opac-user.pl
>index 60a5df9..4e54afc 100755
>--- a/opac/opac-user.pl
>+++ b/opac/opac-user.pl
>@@ -214,7 +214,7 @@ if ( $pending_checkouts->count ) { # Useless test
>                 as     => ['rental_fines']
>             }
>         );
>-        $issue->{rentalfines} = $charges->count ? $charges->next->get_column('rental_fines') : 0;
>+        $issue->{rentalfines} = $rental_fines->count ? $rental_fines->next->get_column('rental_fines') : 0;
> 
>         my $marcrecord = GetMarcBiblio({ biblionumber => $issue->{'biblionumber'} });
>         $issue->{'subtitle'} = GetRecordValue('subtitle', $marcrecord, GetFrameworkCode($issue->{'biblionumber'}));
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20832: 75624 | 75945 | 75969