Attachment 76482 Details for Bug 17240 – Bug 17240: (followup 4) Allow processes that rely on background jobs run in Plack mode

[patch] Bug 17240: (followup 4) Allow processes that rely on background jobs run in Plack mode

Bug-17240-followup-4-Allow-processes-that-rely-on-.patch (text/plain), 2.50 KB, created by Fridolin Somers on 2018-06-27 10:08:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2018-06-27 10:08:37 UTC

Size: 2.50 KB

patch

obsolete

>From 53b107be6052dfce842cfbc846b318d8437431d3 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Wed, 27 Jun 2018 11:59:35 +0200
>Subject: [PATCH] Bug 17240: (followup 4) Allow processes that rely on
> background jobs run in Plack mode
>
>Items batch deletion failed because after action, unlike batch modification, items are not displayed so code must not call BuildItemsData().
>---
> tools/batchMod.pl | 32 +++++++++++++++++---------------
> 1 file changed, 17 insertions(+), 15 deletions(-)
>
>diff --git a/tools/batchMod.pl b/tools/batchMod.pl
>index 1fa621a..ee102ca 100755
>--- a/tools/batchMod.pl
>+++ b/tools/batchMod.pl
>@@ -201,21 +201,23 @@ if ($op eq "action") {
>     }
>     if ( $completedJobID || !$runinbackground ) {
>         # Once the job is done
>-        # If we have a reasonable amount of items, we display them
>-        if (scalar(@itemnumbers) <= ( C4::Context->preference("MaxItemsToDisplayForBatchDel") // 1000 ) ) {
>-            $items_display_hashref=BuildItemsData(@itemnumbers);
>-        } else {
>-            # Else, we only display the barcode
>-            my @simple_items_display = map {
>-                my $itemnumber = $_;
>-                my $item = Koha::Items->find($itemnumber);
>-                {
>-                    itemnumber   => $itemnumber,
>-                    barcode      => $item ? ( $item->barcode // q{} ) : q{},
>-                    biblionumber => $item ? $item->biblio->biblionumber : q{},
>-                };
>-            } @itemnumbers;
>-            $template->param("simple_items_display" => \@simple_items_display);
>+        unless ($del) {
>+            # If we have a reasonable amount of items, we display them
>+            if (scalar(@itemnumbers) <= ( C4::Context->preference("MaxItemsToDisplayForBatchDel") // 1000 ) ) {
>+                $items_display_hashref=BuildItemsData(@itemnumbers);
>+            } else {
>+                # Else, we only display the barcode
>+                my @simple_items_display = map {
>+                    my $itemnumber = $_;
>+                    my $item = Koha::Items->find($itemnumber);
>+                    {
>+                        itemnumber   => $itemnumber,
>+                        barcode      => $item ? ( $item->barcode // q{} ) : q{},
>+                        biblionumber => $item ? $item->biblio->biblionumber : q{},
>+                    };
>+                } @itemnumbers;
>+                $template->param("simple_items_display" => \@simple_items_display);
>+            }
>         }
> 
>         if ($runinbackground) {
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 17240: 55110 | 55111 | 55129 | 55130 | 55137 | 55138 | 55257 | 58461 | 63291 | 63459 | 63862 | 76477 | 76478 | 76479 | 76480 | 76481 | 76482