Bugzilla – Attachment 77736 Details for
Bug 21199
Patron's attributes are displayed on GetPatronInfo's ILSDI output regardless opac_display
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21199: Hide patron's attributes from ILSDI if required
Bug-21199-Hide-patrons-attributes-from-ILSDI-if-re.patch (text/plain), 3.68 KB, created by
Martin Renvoize (ashimema)
on 2018-08-13 08:57:56 UTC
(
hide
)
Description:
Bug 21199: Hide patron's attributes from ILSDI if required
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-08-13 08:57:56 UTC
Size:
3.68 KB
patch
obsolete
>From f775b884d2659b125224305c13f9ddb30555438f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 9 Aug 2018 19:34:58 -0300 >Subject: [PATCH] Bug 21199: Hide patron's attributes from ILSDI if required > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/ILSDI/Services.pm | 2 +- > t/db_dependent/ILSDI_Services.t | 35 ++++++++++++++++++++++++--------- > 2 files changed, 27 insertions(+), 10 deletions(-) > >diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm >index 5534d3ccbc..189aa726c6 100644 >--- a/C4/ILSDI/Services.pm >+++ b/C4/ILSDI/Services.pm >@@ -476,7 +476,7 @@ sub GetPatronInfo { > } > > if ( $cgi->param('show_attributes') eq "1" ) { >- my $attrs = GetBorrowerAttributes( $borrowernumber, 0, 1 ); >+ my $attrs = GetBorrowerAttributes( $borrowernumber, 1 ); > $borrower->{'attributes'} = $attrs; > } > >diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t >index 1eca594137..9b6908ff12 100644 >--- a/t/db_dependent/ILSDI_Services.t >+++ b/t/db_dependent/ILSDI_Services.t >@@ -140,12 +140,21 @@ subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes > my $attr_type = $builder->build( { > source => 'BorrowerAttributeType', > value => { >- code => 'DOORCODE', >+ code => 'HIDEME', > opac_display => 0, > authorised_value_category => '', > class => '', > } > } ); >+ my $attr_type_visible = $builder->build( { >+ source => 'BorrowerAttributeType', >+ value => { >+ code => 'SHOWME', >+ opac_display => 1, >+ authorised_value_category => '', >+ class => '', >+ } >+ } ); > > # Create a new user: > my $brwr = $builder->build( { >@@ -165,12 +174,20 @@ subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes > } ); > > # Set the new attribute for our user: >- my $attr = $builder->build( { >+ my $attr_hidden = $builder->build( { > source => 'BorrowerAttribute', > value => { > borrowernumber => $brwr->{'borrowernumber'}, > code => $attr_type->{'code'}, >- attribute => '1337', >+ attribute => '1337 hidden', >+ } >+ } ); >+ my $attr_shown = $builder->build( { >+ source => 'BorrowerAttribute', >+ value => { >+ borrowernumber => $brwr->{'borrowernumber'}, >+ code => $attr_type_visible->{'code'}, >+ attribute => '1337 shown', > } > } ); > >@@ -196,12 +213,12 @@ subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes > > # Build a structure for comparison: > my $cmp = { >- category_code => $attr_type->{'category_code'}, >- class => $attr_type->{'class'}, >- code => $attr->{'code'}, >- description => $attr_type->{'description'}, >- display_checkout => $attr_type->{'display_checkout'}, >- value => $attr->{'attribute'}, >+ category_code => $attr_type_visible->{'category_code'}, >+ class => $attr_type_visible->{'class'}, >+ code => $attr_shown->{'code'}, >+ description => $attr_type_visible->{'description'}, >+ display_checkout => $attr_type_visible->{'display_checkout'}, >+ value => $attr_shown->{'attribute'}, > value_description => undef, > }; > >-- >2.18.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21199
:
77639
|
77727
| 77736 |
77737