There is a flag opac_display that is used to show or hide patron's attributes at the OPAC. ILSDI is supposed to deal with it, but the call to GetBorrowerAttributes is wrong, flag is passed as 3rd parameter whereas it should be the 2nd. How bad is that?
Created attachment 77639 [details] [review] Bug 21199: Hide patron's attributes from ILSDI if required
Created attachment 77727 [details] [review] Bug 21199: Hide patron's attributes from ILSDI if required Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77736 [details] [review] Bug 21199: Hide patron's attributes from ILSDI if required Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 77737 [details] [review] Bug 21199: (QA follow-up) Add show_attributes to perldoc
Passing QA, no obvious failure during testing. I've added some missing preldoc.. show_attributes wasn't documented at all in the perldoc, now it is documented and states that staff only attributes will be missing. This is in fact a possible breaking change if someone relies of staff side attributes being returned in the response. I however feel that for security reasons this is a positive move and should go through with a note in the release notes warning about the change.
Pushed to 18.05.x for 18.05.03
Awesome work all! Pushed to master for 18.11
Pushed to stable for 17.11.09
Pushed to 17.05.x for 17.05.14