Attachment 80333 Details for Bug 15494 – Bug 15494: (follow-up) Update tests to generate their own data (no delete)

[patch] Bug 15494: (follow-up) Update tests to generate their own data (no delete)

Bug-15494-follow-up-Update-tests-to-generate-their.patch (text/plain), 2.28 KB, created by Nick Clemens (kidclamp) on 2018-10-10 11:01:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2018-10-10 11:01:01 UTC

Size: 2.28 KB

patch

obsolete

>From 71222ef561d940894a1a89c2c7f68eb36ac53733 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 24 Sep 2018 11:06:47 +0000
>Subject: [PATCH] Bug 15494: (follow-up) Update tests to generate their own
> data (no delete)
>
>---
> t/db_dependent/Circulation.t | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index f493e4e..5c90644 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -2216,16 +2216,14 @@ subtest 'ItemsDeniedRenewal preference' => sub {
> 
>     C4::Context->set_preference('ItemsDeniedRenewal','');
> 
>-    $dbh->do('DELETE FROM issues');
>-    $dbh->do('DELETE FROM items');
>-    $dbh->do('DELETE FROM issuingrules');
>+    my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'});
>     $dbh->do(
>         q{
>         INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, maxissueqty, issuelength, lengthunit, renewalsallowed, renewalperiod,
>                     norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )
>         },
>         {},
>-        '*', '*', '*', 25,
>+        '*', $idr_lib->branchcode, '*', 25,
>         20,  14,  'days',
>         10,   7,
>         undef,  0,
>@@ -2233,6 +2231,7 @@ subtest 'ItemsDeniedRenewal preference' => sub {
>     );
> 
>     my $deny_book = $builder->build_object({ class => 'Koha::Items', value => {
>+        homebranch => $idr_lib->branchcode,
>         withdrawn => 1,
>         itype => 'HIDE',
>         location => 'PROC',
>@@ -2241,13 +2240,17 @@ subtest 'ItemsDeniedRenewal preference' => sub {
>         }
>     });
>     my $allow_book = $builder->build_object({ class => 'Koha::Items', value => {
>+        homebranch => $idr_lib->branchcode,
>         withdrawn => 0,
>         itype => 'NOHIDE',
>         location => 'NOPROC'
>         }
>     });
> 
>-    my $idr_borrower = $builder->build_object({ class => 'Koha::Patrons'});
>+    my $idr_borrower = $builder->build_object({ class => 'Koha::Patrons', value=> {
>+        branchcode => $idr_lib->branchcode,
>+        }
>+    });
>     my $future = dt_from_string->add( days => 1 );
>     my $deny_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
>         returndate => undef,
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15494: 63700 | 63701 | 63702 | 63703 | 67886 | 67887 | 67888 | 67889 | 68146 | 68147 | 68148 | 68149 | 70295 | 70629 | 70630 | 70631 | 70632 | 71129 | 71130 | 71131 | 71132 | 71133 | 71134 | 71135 | 71136 | 71137 | 71138 | 79249 | 79250 | 79251 | 79252 | 79253 | 79254 | 79293 | 80327 | 80328 | 80329 | 80330 | 80331 | 80332 | 80333 | 81411 | 81412 | 81413 | 81414 | 81415 | 81416 | 81417