Bug 15494 - Block renewals by arbitrary item values
Summary: Block renewals by arbitrary item values
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL: http://devs.bywatersolutions.com/proj...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-06 16:27 UTC by Nicole C. Engard
Modified: 2017-05-24 14:46 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 15494 - Unit tests (5.62 KB, patch)
2017-05-24 14:46 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed (2.20 KB, patch)
2017-05-24 14:46 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15494 - Update display of renewal errors (7.03 KB, patch)
2017-05-24 14:46 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15494 - Add syspref (3.60 KB, patch)
2017-05-24 14:46 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2016-01-06 16:27:14 UTC
This development would allow a library to prevent the renewal of items based on the values of any field in the items table including but not limited to any itemlost value.

Work to be done:
1) Add new system preference ItemsDeniedRenewal patterned after OpacHiddenItems
2) Modify C4::Circulation::CanBookBeRenewed to check this system preference


Seeking Co-sponsors: http://devs.bywatersolutions.com/projects/make-longoverduelost-items-not-renewable/
Comment 1 Nick Clemens 2017-05-24 14:46:16 UTC
Created attachment 63700 [details] [review]
Bug 15494 - Unit tests

prove t/db_dependent/Circulation.t
Comment 2 Nick Clemens 2017-05-24 14:46:19 UTC
Created attachment 63701 [details] [review]
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed
Comment 3 Nick Clemens 2017-05-24 14:46:22 UTC
Created attachment 63702 [details] [review]
Bug 15494 - Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable
Comment 4 Nick Clemens 2017-05-24 14:46:25 UTC
Created attachment 63703 [details] [review]
Bug 15494 - Add syspref