Attachment 80520 Details for Bug 21553 – Bug 21553: Remove JS error on the Rota view

[patch] Bug 21553: Remove JS error on the Rota view

Bug-21553-Remove-JS-error-on-the-Rota-view.patch (text/plain), 1.61 KB, created by Martin Renvoize (ashimema) on 2018-10-12 15:32:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-10-12 15:32:56 UTC

Size: 1.61 KB

patch

obsolete

>From d0258bbad98bf9f8b478416bd2ee136375696454 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 12 Oct 2018 11:18:17 -0300
>Subject: [PATCH] Bug 21553: Remove JS error on the Rota view
>
>JS error was:
> ReferenceError: _ is not defined
>
>The strings after staff-global.js (for the function _)
>
>Test plan:
>Turn on StockRotation system preference
>
>1) Go to a staff detail page
>2) Switch to rota page
>3) Check web developer tools
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt    | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt
>index 88c7ed2ef4..ca6e142714 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt
>@@ -6,7 +6,6 @@
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Catalog &rsaquo; Stock rotation details for [% biblio.title | html %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
>-[% INCLUDE 'browser-strings.inc' %]
> </head>
> <body id="catalog_stockrotation" class="catalog">
> [% USE KohaDates %]
>@@ -166,6 +165,7 @@
> </div>
> 
> [% MACRO jsinclude BLOCK %]
>+    [% INCLUDE 'browser-strings.inc' %]
>     [% Asset.js("js/browser.js") | $raw %]
>     <script type="text/javascript">
>         var browser = KOHA.browser('[% searchid | html %]', parseInt('[% biblionumber | html %]', 10));
>-- 
>2.19.1

Actions: View | Diff | Splinter Review

Attachments on bug 21553: 80506 | 80514 | 80520