Bugzilla – Attachment 81127 Details for
Bug 21658
Renew requests fail if a fee attached
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch to suppress runtime warning
0002-Bug-21658-Define-string-to-avoid-run-time-warnings.patch (text/plain), 1.08 KB, created by
Colin Campbell
on 2018-10-25 10:20:11 UTC
(
hide
)
Description:
patch to suppress runtime warning
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2018-10-25 10:20:11 UTC
Size:
1.08 KB
patch
obsolete
>From e9b1173c5bbb5185b2de50279c596124712df433 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 25 Oct 2018 10:06:43 +0100 >Subject: [PATCH 2/3] Bug 21658 Define string to avoid run time warnings > >In addition to an explicit error a renewal may be >rejected because a fee is due and has not yet been flagged >as paid. In this case define the error message as empty string >to avoid runtime errors in the regexes performed >on the standard error messages >--- > C4/SIP/ILS/Transaction/Renew.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/C4/SIP/ILS/Transaction/Renew.pm b/C4/SIP/ILS/Transaction/Renew.pm >index 7e1e9b7496..83b87ea67b 100644 >--- a/C4/SIP/ILS/Transaction/Renew.pm >+++ b/C4/SIP/ILS/Transaction/Renew.pm >@@ -40,6 +40,8 @@ sub do_renew_for { > $self->{fee_amount} = sprintf '%.2f',$fee; > if ($self->{fee_ack} eq 'N') { > $renewokay = 0; >+ $renewerror = q{}; # define error string to avoid runtime warnings >+ # in regexes below > } > } > >-- >2.17.2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21658
:
81126
|
81127
|
81128
|
89487
|
89488