Attachment 81414 Details for Bug 15494 – Bug 15494: Add syspref

[patch] Bug 15494: Add syspref

Bug-15494-Add-syspref.patch (text/plain), 4.01 KB, created by Katrin Fischer on 2018-10-28 16:05:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2018-10-28 16:05:02 UTC

Size: 4.01 KB

patch

obsolete

>From c431f0c07fb95a86a35287042f3e50b2e37a87b5 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 24 May 2017 09:47:34 -0400
>Subject: [PATCH] Bug 15494: Add syspref
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> installer/data/mysql/atomicupdate/bug_15494.perl | 16 ++++++++++++++++
> installer/data/mysql/sysprefs.sql                |  1 +
> .../modules/admin/preferences/circulation.pref   | 11 +++++++++++
> 3 files changed, 28 insertions(+)
> create mode 100644 installer/data/mysql/atomicupdate/bug_15494.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_15494.perl b/installer/data/mysql/atomicupdate/bug_15494.perl
>new file mode 100644
>index 0000000000..fbc7f3c017
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_15494.perl
>@@ -0,0 +1,16 @@
>+$DBversion = 'XXX';  # will be replaced by the RM
>+if( CheckVersion( $DBversion ) ) {
>+    # you can use $dbh here like:
>+    # $dbh->do( "ALTER TABLE biblio ADD COLUMN badtaste int" );
>+
>+    $dbh->do( "INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('ItemsDeniedRenewal','','','This syspref allows to define custom rules for denying renewal of specific items.','Textarea')" );
>+
>+    # or perform some test and warn
>+    # if( !column_exists( 'biblio', 'biblionumber' ) ) {
>+    #    warn "There is something wrong";
>+    # }
>+
>+    # Always end with this (adjust the bug info)
>+    SetVersion( $DBversion );
>+    print "Upgrade to $DBversion done (Bug 15494 - Block renewals by arbitrary item values)\n";
>+}
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index 0f86627024..5b3fccdc33 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -248,6 +248,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('itemBarcodeFallbackSearch','',NULL,'If set, uses scanned item barcodes as a catalogue search if not found as barcodes','YesNo'),
> ('itemBarcodeInputFilter','','whitespace|T-prefix|cuecat|libsuite8|EAN13','If set, allows specification of a item barcode input filter','Choice'),
> ('itemcallnumber','082ab',NULL,'The MARC field/subfield that is used to calculate the itemcallnumber (Dewey would be 082ab or 092ab; LOC would be 050ab or 090ab) could be 852hi from an item record','free'),
>+('ItemsDeniedRenewal','','','This syspref allows to define custom rules for denying renewal of specific items.','Textarea'),
> ('KohaAdminEmailAddress','root@localhost','','Define the email address where patron modification requests are sent','free'),
> ('KohaManualBaseURL','https://koha-community.org/manual/','','Where is the Koha manual/documentation located?','Free'),
> ('KohaManualLanguage','en','en|ar|cs|de|es|fr|it|pt_BR|tr|zh_TW','What is the language of the online manual you want to use?','Choice'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index 2407b6c681..3124bc4235 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -476,6 +476,17 @@ Circulation:
>                   yes: Block
>                   no: Allow
>             - his/her auto renewals.
>+        -
>+            - pref: ItemsDeniedRenewal
>+              type: textarea
>+              class: code
>+            - Define custom rules to deny specific items from renewal.
>+            - "<br />Can name any field in the items table followed by a colon then a space then"
>+            - "a bracketed list of values separated by commas."
>+            - "e.g."
>+            - "<br />ccode: [NEWFIC,NULL,DVD]"
>+            - "<br />itype: [NEWBK,\"\"]"
>+            - "<br /> Note: the word 'NULL' can be used to block renewal on undefined fields, while an empty string \"\" will block on an empty (but defined) field."
>     Checkin Policy:
>         -
>             - pref: HoldsAutoFill
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 15494: 63700 | 63701 | 63702 | 63703 | 67886 | 67887 | 67888 | 67889 | 68146 | 68147 | 68148 | 68149 | 70295 | 70629 | 70630 | 70631 | 70632 | 71129 | 71130 | 71131 | 71132 | 71133 | 71134 | 71135 | 71136 | 71137 | 71138 | 79249 | 79250 | 79251 | 79252 | 79253 | 79254 | 79293 | 80327 | 80328 | 80329 | 80330 | 80331 | 80332 | 80333 | 81411 | 81412 | 81413 | 81414 | 81415 | 81416 | 81417