Bugzilla – Attachment 81506 Details for
Bug 21706
Editing subfields in authority frameworks is broken (TT filter)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21706: (follow-up) Fix subfield delete button
Bug-21706-follow-up-Fix-subfield-delete-button.patch (text/plain), 2.61 KB, created by
Tomás Cohen Arazi (tcohen)
on 2018-10-29 14:26:17 UTC
(
hide
)
Description:
Bug 21706: (follow-up) Fix subfield delete button
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2018-10-29 14:26:17 UTC
Size:
2.61 KB
patch
obsolete
>From b8391cc14214e66ae448208f6d86e95276beaf5a Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 29 Oct 2018 11:25:58 -0300 >Subject: [PATCH] Bug 21706: (follow-up) Fix subfield delete button > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > admin/auth_subfields_structure.pl | 1 - > .../prog/en/modules/admin/auth_subfields_structure.tt | 4 ++-- > 2 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/admin/auth_subfields_structure.pl b/admin/auth_subfields_structure.pl >index 14408594f3..1c1624d049 100755 >--- a/admin/auth_subfields_structure.pl >+++ b/admin/auth_subfields_structure.pl >@@ -315,7 +315,6 @@ if ($op eq 'add_form') { > $row_data{value_builder} = $results->[$i]{'value_builder'}; > $row_data{hidden} = $results->[$i]{'hidden'} if($results->[$i]{'hidden'} gt "000") ; > $row_data{isurl} = $results->[$i]{'isurl'}; >- $row_data{delete} = "$script_name?op=delete_confirm&tagfield=$tagfield&tagsubfield=".$results->[$i]{'tagsubfield'}."&authtypecode=$authtypecode"; > if ($row_data{tab} eq -1) { > $row_data{subfield_ignored} = 1; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >index 14bc1b5aa7..e09a45a6f7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >@@ -301,7 +301,7 @@ > [% IF ( loo.value_builder ) %] | <strong>Plugin:</strong>[% loo.value_builder | html %],[% END %] > [% END %] > </td> >- <td><a href="[% loo.delete | uri %]" class="btn btn-default btn-xs"><i class="fa fa-trash"></i> Delete</a></td> >+ <td><a href="?op=delete_confirm&tagfield=[% loo.tagfield | uri %]&tagsubfield=[% loo.tagsubfield | uri %]&authtypecode=[% authtypecode | uri %]" class="btn btn-default btn-xs"><i class="fa fa-trash"></i> Delete</a></td> > </tr> > [% END %] > </table> >@@ -311,7 +311,7 @@ > <input type="hidden" name="tagfield" value="[% edit_tagfield | html %]" /> > <input type="hidden" name="authtypecode" value="[% edit_authtypecode | html %]" /> > <input type="submit" value="Edit subfields" /> >- <a class="cancel" href="auth_tag_structure.pl?searchfield=[% tagfield | uri%]&authtypecode=[% authtypecode | uri %]">Cancel</a></fieldset> >+ <a class="cancel" href="auth_tag_structure.pl?searchfield=[% tagfield | uri %]&authtypecode=[% authtypecode | uri %]">Cancel</a></fieldset> > </form> > > [% IF ( previous ) %] >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21706
:
81500
|
81501
|
81506
|
81729
|
81765
|
81766
|
81767
|
81768
|
82004
|
82005
|
82006
|
82007
|
82245
|
82246
|
82247
|
82248