Possibly the same problem as on bug 21704.
Created attachment 81500 [details] [review] Bug 21706: Make authority framework subfield links work (TT filter) This patch removes URL building from the controller and does it on the templates, using the right 'uri' filter for the query parameters. To test: - Go to Home > Administration > Athority types - On any of the listed frameworks, pick the 'MARC structure' action in the dropdown - On any subfield, hover on the actions dropdown => FAIL: The URLs are wrongly formed - Click on the links => FAIL: You get errors because of the bad URL - Apply this patch - Reload the 'MARC structure' page - On any subfield, hover on the actions dropdown => SUCCESS: LInks look correct - Click on any of them => SUCCESS: They work! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 81501 [details] [review] Bug 21706: (follow-up) remove unused template params The original patch removed the need to add URLs to the template variables. This patch removes that in the controller. Bonus: fixes 'html' filter in URL replacing it by 'uri'. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 81506 [details] [review] Bug 21706: (follow-up) Fix subfield delete button Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I can't add a new subfield with these patches. When clicking on "New" nothing happens. I notice there is also a little error with the tabs on top, there is a gab between them and the form below.
See bug 21526 comment 19. There are plenty to fix.
(In reply to Katrin Fischer from comment #4) > I can't add a new subfield with these patches. When clicking on "New" > nothing happens. > > I notice there is also a little error with the tabs on top, there is a gab > between them and the form below. It works for me, Katrina.
(In reply to Jonathan Druart from comment #5) > See bug 21526 comment 19. There are plenty to fix. I got rid of the URL build step in the controller, it is now clear text, and the param's are URI-filtered as they should.
Hi Tomas, I retested, try this: 000 authority TOPIC_TERM It works for fields with more than one subfield or outside of 000 - some of that.
Created attachment 81729 [details] [review] Bug 21706: (QA follow-up) Fix tabs Not all href's should have parameters URI encoded. Because sometimes they are just where for use by JavaScript libraries which fail in that situations. For fixed-lenght fields we use @ as the subfield code and it breaks the bootstrap tabs if we URI encode the '@'. This fixes the tabs issues on fixed-lenght fields in the authority type editing pages. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(In reply to Katrin Fischer from comment #8) > Hi Tomas, I retested, try this: > > 000 authority TOPIC_TERM > > It works for fields with more than one subfield or outside of 000 - some of > that. Ok, I reproduced it in clean master. This was due to the TT filters too. It doesn't show on the bibliographic framworks edit only because they use a (bad) trick to use '_' instead of '@' when editing the subfield. I'm filing a separate bug for that.
Created attachment 81765 [details] [review] Bug 21706: Make authority framework subfield links work (TT filter) This patch removes URL building from the controller and does it on the templates, using the right 'uri' filter for the query parameters. To test: - Go to Home > Administration > Athority types - On any of the listed frameworks, pick the 'MARC structure' action in the dropdown - On any subfield, hover on the actions dropdown => FAIL: The URLs are wrongly formed - Click on the links => FAIL: You get errors because of the bad URL - Apply this patch - Reload the 'MARC structure' page - On any subfield, hover on the actions dropdown => SUCCESS: LInks look correct - Click on any of them => SUCCESS: They work! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81766 [details] [review] Bug 21706: (follow-up) remove unused template params The original patch removed the need to add URLs to the template variables. This patch removes that in the controller. Bonus: fixes 'html' filter in URL replacing it by 'uri'. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81767 [details] [review] Bug 21706: (follow-up) Fix subfield delete button Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81768 [details] [review] Bug 21706: (QA follow-up) Fix tabs Not all href's should have parameters URI encoded. Because sometimes they are just where for use by JavaScript libraries which fail in that situations. For fixed-lenght fields we use @ as the subfield code and it breaks the bootstrap tabs if we URI encode the '@'. This fixes the tabs issues on fixed-lenght fields in the authority type editing pages. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Note that html_entities is not needed at first glance, but already used in a similar place (marc frameworks). Also the href attribute are not prefixed by /cgi-bin/koha as we usually do but not important.
(In reply to Jonathan Druart from comment #15) > Note that html_entities is not needed => Could be "html", that's what I meant.
Created attachment 82004 [details] [review] Bug 21706: Make authority framework subfield links work (TT filter) This patch removes URL building from the controller and does it on the templates, using the right 'uri' filter for the query parameters. To test: - Go to Home > Administration > Athority types - On any of the listed frameworks, pick the 'MARC structure' action in the dropdown - On any subfield, hover on the actions dropdown => FAIL: The URLs are wrongly formed - Click on the links => FAIL: You get errors because of the bad URL - Apply this patch - Reload the 'MARC structure' page - On any subfield, hover on the actions dropdown => SUCCESS: LInks look correct - Click on any of them => SUCCESS: They work! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 82005 [details] [review] Bug 21706: (follow-up) remove unused template params The original patch removed the need to add URLs to the template variables. This patch removes that in the controller. Bonus: fixes 'html' filter in URL replacing it by 'uri'. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 82006 [details] [review] Bug 21706: (follow-up) Fix subfield delete button Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 82007 [details] [review] Bug 21706: (QA follow-up) Fix tabs Not all href's should have parameters URI encoded. Because sometimes they are just where for use by JavaScript libraries which fail in that situations. For fixed-lenght fields we use @ as the subfield code and it breaks the bootstrap tabs if we URI encode the '@'. This fixes the tabs issues on fixed-lenght fields in the authority type editing pages. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 82245 [details] [review] Bug 21706: Make authority framework subfield links work (TT filter) This patch removes URL building from the controller and does it on the templates, using the right 'uri' filter for the query parameters. To test: - Go to Home > Administration > Athority types - On any of the listed frameworks, pick the 'MARC structure' action in the dropdown - On any subfield, hover on the actions dropdown => FAIL: The URLs are wrongly formed - Click on the links => FAIL: You get errors because of the bad URL - Apply this patch - Reload the 'MARC structure' page - On any subfield, hover on the actions dropdown => SUCCESS: LInks look correct - Click on any of them => SUCCESS: They work! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 82246 [details] [review] Bug 21706: (follow-up) remove unused template params The original patch removed the need to add URLs to the template variables. This patch removes that in the controller. Bonus: fixes 'html' filter in URL replacing it by 'uri'. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 82247 [details] [review] Bug 21706: (follow-up) Fix subfield delete button Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 82248 [details] [review] Bug 21706: (QA follow-up) Fix tabs Not all href's should have parameters URI encoded. Because sometimes they are just where for use by JavaScript libraries which fail in that situations. For fixed-lenght fields we use @ as the subfield code and it breaks the bootstrap tabs if we URI encode the '@'. This fixes the tabs issues on fixed-lenght fields in the authority type editing pages. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Debased against 21526 to ease integration.
Pushed for 18.11. Thanks all!
Dependencies not in 18.05.x series.