Bugzilla – Attachment 85289 Details for
Bug 22014
Add ability to send "00" in SIP CV field on checkin success
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22014: Unit tests
Bug-22014-Unit-tests.patch (text/plain), 2.04 KB, created by
Kyle M Hall (khall)
on 2019-02-19 17:41:48 UTC
(
hide
)
Description:
Bug 22014: Unit tests
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2019-02-19 17:41:48 UTC
Size:
2.04 KB
patch
obsolete
>From 4612b7dd8f6c9845bf3f68d3644480f9d7f1e36a Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 19 Feb 2019 12:41:30 -0500 >Subject: [PATCH] Bug 22014: Unit tests > >--- > t/db_dependent/SIP/Message.t | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/SIP/Message.t b/t/db_dependent/SIP/Message.t >index 44fef285d5..75ea32c0c8 100755 >--- a/t/db_dependent/SIP/Message.t >+++ b/t/db_dependent/SIP/Message.t >@@ -67,7 +67,7 @@ subtest 'Testing Patron Info Request V2' => sub { > subtest 'Checkin V2' => sub { > my $schema = Koha::Database->new->schema; > $schema->storage->txn_begin; >- plan tests => 21; >+ plan tests => 23; > $C4::SIP::Sip::protocol_version = 2; > test_checkin_v2(); > $schema->storage->txn_rollback; >@@ -354,6 +354,22 @@ sub test_checkin_v2 { > check_field( $respcode, $response, FID_SCREEN_MSG, undef, 'No screen msg' ); > $server->{account}->{checked_in_ok} = 0; > >+ $server->{account}->{checked_in_ok} = 1; >+ $server->{account}->{cv_send_00_on_success} = 0; >+ undef $response; >+ $msg = C4::SIP::Sip::MsgType->new( $siprequest, 0 ); >+ $msg->handle_checkin( $server ); >+ $respcode = substr( $response, 0, 2 ); >+ check_field( $respcode, $response, FID_ALERT_TYPE, undef, 'No FID_ALERT_TYPE (CV) field' ); >+ $server->{account}->{cv_send_00_on_success} = 1; >+ undef $response; >+ $msg = C4::SIP::Sip::MsgType->new( $siprequest, 0 ); >+ $msg->handle_checkin( $server ); >+ $respcode = substr( $response, 0, 2 ); >+ check_field( $respcode, $response, FID_ALERT_TYPE, '00', 'FID_ALERT_TYPE (CV) field is 00' ); >+ $server->{account}->{checked_in_ok} = 0; >+ $server->{account}->{cv_send_00_on_success} = 0; >+ > # Checkin at wrong branch: issue item and switch branch, and checkin > my $issue = Koha::Checkout->new({ branchcode => $branchcode, borrowernumber => $patron1->{borrowernumber}, itemnumber => $item->{itemnumber} })->store; > $branchcode = $builder->build({ source => 'Branch' })->{branchcode}; >-- >2.17.2 (Apple Git-113)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22014
:
83308
|
83309
|
83346
|
85146
| 85289