Bugzilla – Attachment 85448 Details for
Bug 22386
Importing using attributes as matchpoint broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22386: Define patron variable when matchign on extended attributes
Bug-22386-Define-patron-variable-when-matchign-on-.patch (text/plain), 1.18 KB, created by
Nick Clemens (kidclamp)
on 2019-02-21 14:33:15 UTC
(
hide
)
Description:
Bug 22386: Define patron variable when matchign on extended attributes
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-02-21 14:33:15 UTC
Size:
1.18 KB
patch
obsolete
>From f3996f589c6e77ae5c10112439e129fd30a8143a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 21 Feb 2019 14:30:22 +0000 >Subject: [PATCH] Bug 22386: Define patron variable when matchign on extended > attributes > >For all other methods we define a patron object and check the userid, >we just need to define the $patron here > >To test: >0 - Apply unit test patch alone >1 - prove t/db_dependent/Koha/Patrons/Import.t >2 - It dies >3 - Apply this patch >4 - repeat tests >5 - It passes! >--- > Koha/Patrons/Import.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm >index 8311126ef3..fe63b9567e 100644 >--- a/Koha/Patrons/Import.pm >+++ b/Koha/Patrons/Import.pm >@@ -176,6 +176,7 @@ sub import_patrons { > if ( $attr->{code} eq $matchpoint and $attr->{value} ne '' ) { > my @borrowernumbers = $matchpoint_attr_type->get_patrons( $attr->{value} ); > $borrowernumber = $borrowernumbers[0] if scalar(@borrowernumbers) == 1; >+ $patron = Koha::Patrons->find( $borrowernumber ); > last; > } > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22386
:
85447
|
85448
|
85449
|
85450
|
85454
|
85455
|
85456