Attempting to import patrons and matching on extended attributes fails with a software error when matching borrower found
Created attachment 85447 [details] [review] Bug 22386: Unit tests
Created attachment 85448 [details] [review] Bug 22386: Define patron variable when matchign on extended attributes For all other methods we define a patron object and check the userid, we just need to define the $patron here To test: 0 - Apply unit test patch alone 1 - prove t/db_dependent/Koha/Patrons/Import.t 2 - It dies 3 - Apply this patch 4 - repeat tests 5 - It passes!
Created attachment 85449 [details] [review] Bug 22386: Unit tests Signed-off-by: Devlyn Courtier <dcourtier@hccc.edu>
Created attachment 85450 [details] [review] Bug 22386: Define patron variable when matchign on extended attributes For all other methods we define a patron object and check the userid, we just need to define the $patron here To test: 0 - Apply unit test patch alone 1 - prove t/db_dependent/Koha/Patrons/Import.t 2 - It dies 3 - Apply this patch 4 - repeat tests 5 - It passes! Signed-off-by: Devlyn Courtier <dcourtier@hccc.edu>
Error is: Can't call method "userid" on an undefined value at /home/vagrant/kohaclone/Koha/Patrons/Import.pm line 205, <$handle_4> line 4.
Created attachment 85454 [details] [review] Bug 22386: Unit tests Signed-off-by: Devlyn Courtier <dcourtier@hccc.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 85455 [details] [review] Bug 22386: Define patron variable when matchign on extended attributes For all other methods we define a patron object and check the userid, we just need to define the $patron here To test: 0 - Apply unit test patch alone 1 - prove t/db_dependent/Koha/Patrons/Import.t 2 - It dies 3 - Apply this patch 4 - repeat tests 5 - It passes! Signed-off-by: Devlyn Courtier <dcourtier@hccc.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 85456 [details] [review] Bug 22386: Remove debug statements Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
backported to 18.05.x for 18.05.11
Depends on Bug 19936 not in 17.11.x