Bugzilla – Attachment 86081 Details for
Bug 18925
Move maxissueqty and maxonsiteissueqty to circulation_rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18925: (QA follow-up) Fix Circulation.t
Bug-18925-QA-follow-up-Fix-Circulationt.patch (text/plain), 3.06 KB, created by
Josef Moravec
on 2019-03-05 14:12:03 UTC
(
hide
)
Description:
Bug 18925: (QA follow-up) Fix Circulation.t
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2019-03-05 14:12:03 UTC
Size:
3.06 KB
patch
obsolete
>From cad03415847568a830430176271b50696c1c396a Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Tue, 5 Mar 2019 14:08:34 +0000 >Subject: [PATCH] Bug 18925: (QA follow-up) Fix Circulation.t > >Test plan: >t/db_dependent/Circulation.t > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > t/db_dependent/Circulation.t | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index eafc2d8e46..1312a6051b 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -1730,7 +1730,6 @@ subtest 'AddReturn + suspension_chargeperiod' => sub { > categorycode => '*', > itemtype => '*', > branchcode => '*', >- maxissueqty => 99, > issuelength => 1, > firstremind => 0, # 0 day of grace > finedays => 2, # 2 days of fine per day of overdue >@@ -1896,7 +1895,6 @@ subtest 'AddReturn | is_overdue' => sub { > categorycode => '*', > itemtype => '*', > branchcode => '*', >- maxissueqty => 99, > issuelength => 6, > lengthunit => 'days', > fine => 1, # Charge 1 every day of overdue >@@ -2500,12 +2498,12 @@ subtest 'CanBookBeIssued | is_overdue' => sub { > $dbh->do('DELETE FROM issuingrules'); > $dbh->do( > q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, >- maxissueqty, issuelength, lengthunit, >+ issuelength, lengthunit, > renewalsallowed, renewalperiod, > norenewalbefore, auto_renew, > fine, chargeperiod) > VALUES (?, ?, ?, ?, >- ?, ?, ?, >+ ?, ?, > ?, ?, > ?, ?, > ?, ? >@@ -2513,7 +2511,7 @@ subtest 'CanBookBeIssued | is_overdue' => sub { > }, > {}, > '*', '*', '*', 25, >- 1, 14, 'days', >+ 14, 'days', > 1, 7, > undef, 0, > .10, 1 >@@ -2555,12 +2553,12 @@ subtest 'ItemsDeniedRenewal preference' => sub { > my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'}); > $dbh->do( > q{ >- INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, maxissueqty, issuelength, lengthunit, renewalsallowed, renewalperiod, >- norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? ) >+ INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, issuelength, lengthunit, renewalsallowed, renewalperiod, >+ norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? ) > }, > {}, > '*', $idr_lib->branchcode, '*', 25, >- 20, 14, 'days', >+ 14, 'days', > 10, 7, > undef, 0, > .10, 1 >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18925
:
65238
|
65239
|
65240
|
67024
|
67025
|
67026
|
67621
|
70992
|
70993
|
70994
|
70995
|
70996
|
71032
|
71033
|
71043
|
71044
|
71045
|
71046
|
71047
|
72225
|
72226
|
72227
|
72228
|
72229
|
77225
|
77226
|
77227
|
77228
|
77229
|
78881
|
78882
|
78883
|
78884
|
78885
|
78886
|
79642
|
79643
|
79644
|
79645
|
79646
|
81091
|
81092
|
81093
|
81094
|
81095
|
82927
|
82928
|
82929
|
82930
|
82931
|
85480
|
85481
|
85482
|
85483
|
85484
|
85485
|
85486
|
85939
|
85940
|
85941
|
85942
|
85943
|
85944
|
85945
|
85946
|
85947
|
85948
|
85949
|
85950
|
85951
|
85953
|
85954
|
85955
|
85956
|
85957
|
85958
|
85959
|
85960
|
85961
|
85962
|
85963
|
85964
|
85965
|
86068
|
86069
|
86070
|
86071
|
86072
|
86073
|
86074
|
86075
|
86076
|
86077
|
86078
|
86079
|
86080
| 86081 |
86121
|
86165
|
86206
|
86207