Attachment 87498 Details for Bug 15326 – Bug 15326: (follow-up) Don't make links to unpublished pages in opac

[patch] Bug 15326: (follow-up) Don't make links to unpublished pages in opac

Bug-15326-follow-up-Dont-make-links-to-unpublished.patch (text/plain), 1.81 KB, created by Martin Renvoize (ashimema) on 2019-04-08 11:16:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-04-08 11:16:30 UTC

Size: 1.81 KB

patch

obsolete

>From fe28b30f800273470ef734d88373b7f1b6073453 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 8 Apr 2019 12:14:13 +0100
>Subject: [PATCH] Bug 15326: (follow-up) Don't make links to unpublished pages
> in opac
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>Signed-off-by: Michal Denar <black23@gmail.com>
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>Rebased-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> opac/opac-cmspages.pl | 2 +-
> opac/opac-main.pl     | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/opac/opac-cmspages.pl b/opac/opac-cmspages.pl
>index 37d5e9fccb..1cc68d0c4f 100755
>--- a/opac/opac-cmspages.pl
>+++ b/opac/opac-cmspages.pl
>@@ -46,7 +46,7 @@ my ( $theme, $news_lang, $availablethemes ) = C4::Templates::themelanguage(
> # List all pages, if id is set generate parent page list and data.
> my ( $page_list, $parent_list, $page_data ) = Koha::CmsPages->list( $id );
> 
>-my $links = Koha::CmsPages->search( {}, { order_by => 'sortorder' } );
>+my $links = Koha::CmsPages->search( { publish => 1 }, { order_by => 'sortorder' } );
> my $cms_data = Koha::CmsPages->find( $id );
> $template->param(
>     links       => $links,
>diff --git a/opac/opac-main.pl b/opac/opac-main.pl
>index b3429a7ae8..c0c4c8c8b0 100755
>--- a/opac/opac-main.pl
>+++ b/opac/opac-main.pl
>@@ -112,8 +112,8 @@ $template->param(
> 
> my $id = scalar $input->param( 'id' ) // '';
> my ( $page_list, $parent_list, $page_data ) = Koha::CmsPages->list( $id );
>-my $links = Koha::CmsPages->search( {}, { order_by => 'parent' } );
>-my $cms_data = Koha::CmsPages->page( $id );
>+my $links = Koha::CmsPages->search( { publish => 1 }, { order_by => 'parent' } );
>+my $cms_data = Koha::CmsPages->find( $id );
> $template->param(
>     links       => $links,
>     cms_page    => $cms_data,
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 15326: 45621 | 58272 | 58607 | 58608 | 58609 | 58787 | 63904 | 63905 | 64241 | 64941 | 64942 | 66255 | 70866 | 70867 | 70868 | 70869 | 70870 | 70871 | 76387 | 76388 | 76389 | 76390 | 76391 | 76392 | 78232 | 78233 | 78234 | 78235 | 78236 | 78237 | 78238 | 78240 | 79269 | 83318 | 83319 | 83320 | 83321 | 83322 | 83323 | 83324 | 83325 | 83326 | 83404 | 83405 | 83406 | 83407 | 83408 | 83409 | 83410 | 83411 | 83412 | 84682 | 84683 | 84684 | 84685 | 84686 | 84687 | 84688 | 84689 | 84690 | 84691 | 87494 | 87495 | 87496 | 87497 | 87498 | 87499 | 87500 | 87501 | 87502 | 87503 | 87608 | 87609 | 87610 | 87617 | 96084 | 96085 | 96086 | 96087 | 96088 | 96089 | 96090 | 96091 | 96092 | 96093 | 96094 | 96095 | 96096 | 96097 | 96098 | 97237 | 101565 | 101566 | 101567 | 101568 | 101569 | 101570 | 101571 | 101572 | 101573 | 101574 | 101575 | 101576 | 101577 | 101578 | 101579 | 101580 | 128341 | 128342 | 128343 | 128344 | 128345 | 128346 | 128347 | 128348 | 128349 | 128350 | 128351 | 128352 | 128353 | 128354 | 128355 | 128356 | 128357 | 128585 | 128642 | 136432 | 136757 | 136768 | 138489 | 138493 | 139028 | 139029 | 139030 | 139031 | 139111 | 139123 | 139124 | 139125 | 139172 | 139173 | 139174