Bug 15326 - Add CMS feature
Summary: Add CMS feature
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low new feature (vote)
Assignee: Aleisha Amohia
QA Contact: Kyle M Hall
URL:
Keywords: Manual
: 12806 (view as bug list)
Depends on:
Blocks: 7840 31385 32020 32021 32023
  Show dependency treegraph
 
Reported: 2015-12-07 14:53 UTC by Martin Persson
Modified: 2022-11-24 20:54 UTC (History)
28 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Medium patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/597
Text to go in the release notes:
This enhancement utilises the additional contents feature to add custom pages to the staff interface and the OPAC in the user's desired language.
Version(s) released in:
22.11.00


Attachments
Bug 15326: Add CMS feature (42.25 KB, patch)
2015-12-13 21:07 UTC, Martin Persson
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] Add CMS feature (55.50 KB, patch)
2016-12-19 03:50 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (42.30 KB, patch)
2017-01-05 01:03 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (42.30 KB, patch)
2017-01-05 01:04 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] Add CMS feature (55.46 KB, patch)
2017-01-05 01:05 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] Add CMS feature (54.71 KB, patch)
2017-01-10 22:02 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (42.28 KB, patch)
2017-06-02 04:16 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] Add CMS feature (53.86 KB, patch)
2017-06-02 04:17 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] Many fixes (15.53 KB, patch)
2017-06-12 23:54 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] More fixes (2.69 KB, patch)
2017-07-10 01:32 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] adding and editing fixes (1.35 KB, patch)
2017-07-10 01:53 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing (3.53 KB, patch)
2017-08-20 23:17 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (42.12 KB, patch)
2018-01-24 01:40 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] Add CMS feature (54.37 KB, patch)
2018-01-24 01:40 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] Many fixes (15.53 KB, patch)
2018-01-24 01:40 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] More fixes (2.69 KB, patch)
2018-01-24 01:40 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] adding and editing fixes (1.35 KB, patch)
2018-01-24 01:41 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing (3.53 KB, patch)
2018-01-24 01:41 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (42.15 KB, patch)
2018-06-25 15:32 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 15326: (follow-up) Add CMS feature (62.32 KB, patch)
2018-06-25 15:32 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 15326: (follow-up) utf8 to utf8mb4 (3.40 KB, patch)
2018-06-25 15:32 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 15326: (follow-up) Move js to footer, use Asset plugin (5.65 KB, patch)
2018-06-25 15:32 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 15326: (follow-up) Don't make links to unpublished pages in opac (1.63 KB, patch)
2018-06-25 15:32 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix tools menu highlighting (2.39 KB, patch)
2018-06-25 15:32 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (96.80 KB, patch)
2018-08-28 22:53 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Add CMS feature (62.38 KB, patch)
2018-08-28 22:54 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) utf8 to utf8mb4 (3.40 KB, patch)
2018-08-28 22:54 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Move js to footer, use Asset plugin (5.65 KB, patch)
2018-08-28 22:54 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Don't make links to unpublished pages in opac (1.63 KB, patch)
2018-08-28 22:54 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix tools menu highlighting (2.39 KB, patch)
2018-08-28 22:54 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Code review fixes (1.91 KB, patch)
2018-08-28 23:38 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Interface fixes (7.19 KB, patch)
2018-08-29 03:21 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Pages navigation fixes (6.16 KB, patch)
2018-09-24 03:01 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (96.82 KB, patch)
2018-12-17 21:16 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Add CMS feature (62.51 KB, patch)
2018-12-17 21:16 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) utf8 to utf8mb4 (3.40 KB, patch)
2018-12-17 21:16 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Move js to footer, use Asset plugin (5.65 KB, patch)
2018-12-17 21:16 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Don't make links to unpublished pages in opac (1.63 KB, patch)
2018-12-17 21:17 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix tools menu highlighting (903 bytes, patch)
2018-12-17 21:17 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Code review fixes (1.91 KB, patch)
2018-12-17 21:17 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Interface fixes (7.19 KB, patch)
2018-12-17 21:17 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Pages navigation fixes (6.16 KB, patch)
2018-12-17 21:17 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (96.97 KB, patch)
2018-12-20 09:22 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 15326: (follow-up) Add CMS feature (62.70 KB, patch)
2018-12-20 09:22 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 15326: (follow-up) utf8 to utf8mb4 (3.51 KB, patch)
2018-12-20 09:22 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 15326: (follow-up) Move js to footer, use Asset plugin (5.75 KB, patch)
2018-12-20 09:22 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 15326: (follow-up) Don't make links to unpublished pages in opac (1.74 KB, patch)
2018-12-20 09:23 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix tools menu highlighting (1007 bytes, patch)
2018-12-20 09:23 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 15326: (follow-up) Code review fixes (2.01 KB, patch)
2018-12-20 09:23 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 15326: (follow-up) Interface fixes (7.31 KB, patch)
2018-12-20 09:23 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 15326: (follow-up) Pages navigation fixes (6.29 KB, patch)
2018-12-20 09:23 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (96.87 KB, patch)
2019-02-03 23:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Add CMS feature (58.97 KB, patch)
2019-02-03 23:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) utf8 to utf8mb4 (3.49 KB, patch)
2019-02-03 23:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Move js to footer, use Asset plugin (5.74 KB, patch)
2019-02-03 23:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Don't make links to unpublished pages in opac (1.73 KB, patch)
2019-02-03 23:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix tools menu highlighting (1000 bytes, patch)
2019-02-03 23:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Code review fixes (2.00 KB, patch)
2019-02-03 23:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Interface fixes (7.29 KB, patch)
2019-02-03 23:38 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Pages navigation fixes (6.25 KB, patch)
2019-02-03 23:38 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Schema changes (4.16 KB, patch)
2019-02-03 23:39 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (96.87 KB, patch)
2019-04-08 11:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 15326: (follow-up) Add CMS feature (59.11 KB, patch)
2019-04-08 11:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 15326: (follow-up) utf8 to utf8mb4 (3.55 KB, patch)
2019-04-08 11:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 15326: (follow-up) Move js to footer, use Asset plugin (5.80 KB, patch)
2019-04-08 11:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 15326: (follow-up) Don't make links to unpublished pages in opac (1.81 KB, patch)
2019-04-08 11:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix tools menu highlighting (1.04 KB, patch)
2019-04-08 11:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 15326: (follow-up) Code review fixes (2.08 KB, patch)
2019-04-08 11:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 15326: (follow-up) Interface fixes (7.35 KB, patch)
2019-04-08 11:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 15326: (follow-up) Pages navigation fixes (6.32 KB, patch)
2019-04-08 11:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 15326: Schema changes (4.17 KB, patch)
2019-04-08 11:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 15326: (follow-up) Redindent new CMS page templates (47.54 KB, patch)
2019-04-09 14:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15326: (follow-up) Corrections to staff client templates (47.00 KB, patch)
2019-04-09 14:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters (59.94 KB, patch)
2019-04-09 14:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters (59.96 KB, patch)
2019-04-09 15:07 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (97.06 KB, patch)
2019-12-09 12:08 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Add CMS feature (59.23 KB, patch)
2019-12-09 12:08 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) utf8 to utf8mb4 (3.57 KB, patch)
2019-12-09 12:08 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Move js to footer, use Asset plugin (5.81 KB, patch)
2019-12-09 12:08 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Don't make links to unpublished pages in opac (1.81 KB, patch)
2019-12-09 12:08 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix tools menu highlighting (1.04 KB, patch)
2019-12-09 12:08 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Code review fixes (2.08 KB, patch)
2019-12-09 12:08 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Interface fixes (7.38 KB, patch)
2019-12-09 12:08 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Pages navigation fixes (6.36 KB, patch)
2019-12-09 12:08 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Redindent new CMS page templates (47.57 KB, patch)
2019-12-09 12:08 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Corrections to staff client templates (47.03 KB, patch)
2019-12-09 12:09 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters (59.98 KB, patch)
2019-12-09 12:09 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: Schema changes (4.34 KB, patch)
2019-12-09 12:09 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: Fix QA errors (873 bytes, patch)
2019-12-09 12:09 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: Fix filters and adjust tiny_mce assets (9.16 KB, patch)
2019-12-09 12:09 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Template tweaks (45.96 KB, patch)
2020-01-10 23:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (97.06 KB, patch)
2020-03-24 13:39 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Add CMS feature (59.48 KB, patch)
2020-03-24 13:39 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) utf8 to utf8mb4 (3.57 KB, patch)
2020-03-24 13:39 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Move js to footer, use Asset plugin (5.81 KB, patch)
2020-03-24 13:39 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Don't make links to unpublished pages in opac (1.81 KB, patch)
2020-03-24 13:39 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix tools menu highlighting (1.04 KB, patch)
2020-03-24 13:39 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Code review fixes (2.08 KB, patch)
2020-03-24 13:39 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Interface fixes (7.38 KB, patch)
2020-03-24 13:39 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Pages navigation fixes (6.36 KB, patch)
2020-03-24 13:39 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Redindent new CMS page templates (47.57 KB, patch)
2020-03-24 13:40 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Corrections to staff client templates (47.03 KB, patch)
2020-03-24 13:40 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters (59.98 KB, patch)
2020-03-24 13:40 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: Fix QA errors (873 bytes, patch)
2020-03-24 13:40 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: Fix filters and adjust tiny_mce assets (9.16 KB, patch)
2020-03-24 13:40 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: (follow-up) Template tweaks (45.96 KB, patch)
2020-03-24 13:40 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: DO NOT PUSH - Schema changes (4.24 KB, patch)
2020-03-24 13:40 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 15326: Add CMS feature (97.31 KB, patch)
2021-12-08 04:56 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Add CMS feature (58.47 KB, patch)
2021-12-08 04:56 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) utf8 to utf8mb4 (3.53 KB, patch)
2021-12-08 04:56 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Move js to footer, use Asset plugin (5.81 KB, patch)
2021-12-08 04:56 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Don't make links to unpublished pages in opac (1.81 KB, patch)
2021-12-08 04:56 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix tools menu highlighting (1.04 KB, patch)
2021-12-08 04:56 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Code review fixes (1.59 KB, patch)
2021-12-08 04:56 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Interface fixes (7.46 KB, patch)
2021-12-08 04:56 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Pages navigation fixes (6.40 KB, patch)
2021-12-08 04:56 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Redindent new CMS page templates (47.75 KB, patch)
2021-12-08 04:57 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Corrections to staff client templates (47.03 KB, patch)
2021-12-08 04:57 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters (58.32 KB, patch)
2021-12-08 04:57 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Fix QA errors (873 bytes, patch)
2021-12-08 04:57 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Fix filters and adjust tiny_mce assets (9.16 KB, patch)
2021-12-08 04:57 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Template tweaks (45.96 KB, patch)
2021-12-08 04:57 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) WIP (19.39 KB, patch)
2021-12-08 04:57 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Schema updates (4.23 KB, patch)
2021-12-08 04:57 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: WIP: Using AdditionalContents for custom pages on OPAC (8.33 KB, patch)
2021-12-16 04:18 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Using AdditionalContents for custom pages on OPAC (26.89 KB, patch)
2021-12-17 02:27 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Using AdditionalContents for custom pages on OPAC (28.18 KB, patch)
2022-06-22 22:05 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Using AdditionalContents for custom pages on OPAC (22.49 KB, patch)
2022-06-30 00:47 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Using AdditionalContents for custom pages on OPAC (22.49 KB, patch)
2022-06-30 13:04 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 15326: (follow-up) Hide RSS feed if no news items (1012 bytes, patch)
2022-08-02 00:41 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: (follow-up) Hide RSS feed if no news items (1.03 KB, patch)
2022-08-02 05:01 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Using AdditionalContents for custom pages on OPAC (22.55 KB, patch)
2022-08-11 20:42 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 15326: Using AdditionalContents for custom pages on OPAC (22.62 KB, patch)
2022-08-11 20:42 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 15326: (follow-up) Hide RSS feed if no news items (1.09 KB, patch)
2022-08-11 20:42 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 15326: (follow-up) Hide RSS feed if no news items (1.15 KB, patch)
2022-08-11 20:43 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix staff permissions and consider library limits (2.70 KB, patch)
2022-08-15 05:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15326: Using AdditionalContents for custom pages on OPAC (22.67 KB, patch)
2022-08-15 12:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15326: (follow-up) Hide RSS feed if no news items (1.14 KB, patch)
2022-08-15 12:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix staff permissions and consider library limits (2.75 KB, patch)
2022-08-15 12:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15326: Using AdditionalContents for custom pages on OPAC (22.72 KB, patch)
2022-08-16 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15326: (follow-up) Hide RSS feed if no news items (1.20 KB, patch)
2022-08-16 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15326: (follow-up) Fix staff permissions and consider library limits (2.80 KB, patch)
2022-08-16 10:54 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Persson 2015-12-07 14:53:42 UTC
As part of the sponsored project at Region Halland in Sweden we have added simple CMS functionality to Koha. This allows a library to add content pages without having to do any manual work. The content of the pages can be edited from the Staff client in WYSIWYG mode and navigation links are automatically added to OPAC and the staff client. Pages can be specific to branches, languages or OPAC and/or the staff interface. Several levels of pages are supported.
Comment 1 Martin Persson 2015-12-13 21:07:36 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-12-19 03:50:08 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-12-19 07:50:02 UTC
Applying: Bug 15326: Add CMS feature
fatal: sha1 information is lacking or useless (Koha/CmsPage.pm).

We seem to miss patches here?
Comment 4 Viktor Sarge 2016-12-28 07:57:22 UTC
Tried it on a freshly installed kohadevbox with jessie with the same result as Marcel.
Comment 5 Aleisha Amohia 2017-01-05 01:03:51 UTC Comment hidden (obsolete)
Comment 6 Aleisha Amohia 2017-01-05 01:04:58 UTC Comment hidden (obsolete)
Comment 7 Aleisha Amohia 2017-01-05 01:05:05 UTC Comment hidden (obsolete)
Comment 8 Aleisha Amohia 2017-01-05 01:06:31 UTC
The patch was not applying because I accidentally obsoleted Martin's initial patch, which is required! I have fixed any merge conflicts. This should apply cleanly and is now ready to test.
Comment 9 Aleisha Amohia 2017-01-10 22:02:38 UTC Comment hidden (obsolete)
Comment 10 Marcel de Rooy 2017-05-17 14:52:28 UTC
Applying: Bug 15326: [FOLLOW-UP] Add CMS feature
fatal: sha1 information is lacking or useless (Koha/CmsPages.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Comment 11 Aleisha Amohia 2017-06-02 04:16:58 UTC Comment hidden (obsolete)
Comment 12 Aleisha Amohia 2017-06-02 04:17:05 UTC Comment hidden (obsolete)
Comment 13 Aleisha Amohia 2017-06-02 04:17:53 UTC
Merge conflicts fixed, ready for testing
Comment 14 Josef Moravec 2017-06-06 10:28:16 UTC
It basically works, but need more improvements:

- the action buttons should be in dropdown and contain also delete button
- both test fail
- there are also many issues from koha qa test tool:

 FAIL	Koha/CmsPages.pm
   FAIL	  critic
		"return" statement with explicit "undef" at line 93, column 17. See page 199 of PBP.
		"return" statement with explicit "undef" at line 80, column 13. See page 199 of PBP.
   FAIL	  pod
		*** ERROR: 
		 
		
		Apparent command =cut not preceded by blank line
		 in file Koha/CmsPages.pm
   FAIL	  spelling
		 paramters  ==> parameters


 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/tools/cmspages.tt
   FAIL	  forbidden patterns
		forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 284)
		forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 286)
		forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 288)
		forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 281)
		forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 283)
		forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 92)


 FAIL	t/db_dependent/Pages.t
   FAIL	  forbidden patterns
		forbidden pattern: tab char (line 78)
		forbidden pattern: tab char (line 49)
		forbidden pattern: tab char (line 85)
		forbidden pattern: tab char (line 54)
		forbidden pattern: tab char (line 72)
		forbidden pattern: tab char (line 84)
		forbidden pattern: tab char (line 62)
		forbidden pattern: tab char (line 82)
		forbidden pattern: tab char (line 68)
		forbidden pattern: tab char (line 70)
		forbidden pattern: tab char (line 73)
		forbidden pattern: tab char (line 50)
		forbidden pattern: tab char (line 59)
		forbidden pattern: tab char (line 52)
		forbidden pattern: tab char (line 71)
		forbidden pattern: tab char (line 79)
		forbidden pattern: tab char (line 61)
		forbidden pattern: tab char (line 75)
		forbidden pattern: tab char (line 58)
		forbidden pattern: tab char (line 60)
		forbidden pattern: tab char (line 63)
		forbidden pattern: tab char (line 48)
		forbidden pattern: tab char (line 64)
		forbidden pattern: tab char (line 53)
		forbidden pattern: tab char (line 55)
		forbidden pattern: tab char (line 83)
		forbidden pattern: tab char (line 74)
		forbidden pattern: tab char (line 81)
		forbidden pattern: tab char (line 80)
		forbidden pattern: tab char (line 69)
		forbidden pattern: tab char (line 65)
		forbidden pattern: tab char (line 51)
Comment 15 Aleisha Amohia 2017-06-12 23:54:03 UTC Comment hidden (obsolete)
Comment 16 Josef Moravec 2017-06-20 17:44:16 UTC
Not ok yet, sorry:

Test t/Pages.t:

There is no C4::Content module in Koha...

#   Failed test 'use C4::Content;'
#   at t/Pages.t line 9.
#     Tried to use 'C4::Content'.
#     Error:  Can't locate C4/Content.pm in @INC (you may need to install the C4::Content module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at t/Pages.t line 9.
# BEGIN failed--compilation aborted at t/Pages.t line 9.
Undefined subroutine &C4::Content::_SQLToPerl called at t/Pages.t line 30.
# Looks like your test exited with 255 just after 1.

also, when using this tool - adding and editing does not work after last patch - some values are not saved (publish status), some are not populated to form when editing (library)... when I set page for all libraries, i get ISE with this log:

DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`cms_pages`, CONSTRAINT `cmspages_branchcode_ibfk` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `cms_pages` ( `branchcode`, `content`, `id`, `lang`, `location`, `parent`, `publish`, `sortorder`, `title`, `title_link`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="", 1="<p>asdasdasd</p>", 2="", 3="", 4="", 5="", 6="on", 7="10", 8="asdasd", 9="asdfasd"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`cms_pages`, CONSTRAINT `cmspages_branchcode_ibfk` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE) at /home/vagrant/kohaclone/Koha/CmsPages.pm line 94
Comment 17 Aleisha Amohia 2017-07-10 01:32:17 UTC Comment hidden (obsolete)
Comment 18 Aleisha Amohia 2017-07-10 01:53:03 UTC Comment hidden (obsolete)
Comment 19 Josef Moravec 2017-07-10 11:07:21 UTC
The library field is still not populated corectly to the form when editing existing page...

No page is accesible via opac now - everypage just says "This page has not been published", even if I have it published for all librarias, interfaces and languages...
Comment 20 Aleisha Amohia 2017-08-20 23:17:20 UTC Comment hidden (obsolete)
Comment 21 Hugo Agud 2017-08-22 09:21:48 UTC
Hi, this is a nice feature..

just a couple of questions

a super user always is able to see all pages right? at least this is what it happens to us.

be aware of children pages should have a greater order than parents if not, they will be published as children of other links... for example we have 3 pages 2 root and one children... if the order of children is lower than parent. it appears as children of the other like this

root1
 . children_of_root_2
root2

I can't see where pages are published in staff. in opac we see them in opacnav

The links are not published in opac account page, right?
Comment 22 Caroline Cyr La Rose 2017-09-22 21:16:32 UTC
Great job so far!

Things I didn't find or that I'm not sure about (please note that I am still new to Koha, so there might be some things I'm just missing because of inexperience):

- I didn't find the pages in the staff interface (I found the tool to create the pages, but from the tool I could see all the pages, even the ones restricted to OPAC)

- If your OPAC and staff interface are in different languages, do you have to create all the pages in double/triple/quadruple (one limited to the first language, the second limited to the second language, etc.)?

- in OPAC, am I supposed to see the pages for all sites, or just the ones of my home library (if I'm connected)? Right now, even though I'm connected, I see all pages.


Things that work A1!:

- I don't see the "staff only pages" in the OPAC

- The WYSIWYG interface is good. I didn't test everything, but headers, bold and lists work as they usually do.


Things to work on :

- The links for the pages don't appear on the main OPAC page unless I put something (anything) in the OpacNav system preference. I put some text there, no html, and the list of pages appeared. Otherwise, it was invisible.

- Also, on the home page, the links seem to appear in the following order: first, all the parent pages in the order they were created, next, the child pages in the order they were created (not under their parent, but at the end of the list). After I click on one of the links, the links rearrange themselves so that the child pages are under their parent. The pages still appear in the order they were created even though I put different values in the "Appear in position" field.

- When I click on a parent page, the child pages dissapear from the navigation list

- When there's an error when creating a page, the page is just deleted, so you lose all the work you just did instead of being able to modify the error. For example, on the second page I created, I got an error message (I think it was that the link wasn't unique) and was directed back to the list of pages (and lost all the text I had put in the contents field), instead of the link field being highlighted so I could just change it so that it was unique and resave the page.
Comment 23 Aleisha Amohia 2018-01-24 01:40:35 UTC Comment hidden (obsolete)
Comment 24 Aleisha Amohia 2018-01-24 01:40:42 UTC Comment hidden (obsolete)
Comment 25 Aleisha Amohia 2018-01-24 01:40:49 UTC Comment hidden (obsolete)
Comment 26 Aleisha Amohia 2018-01-24 01:40:56 UTC Comment hidden (obsolete)
Comment 27 Aleisha Amohia 2018-01-24 01:41:02 UTC Comment hidden (obsolete)
Comment 28 Aleisha Amohia 2018-01-24 01:41:08 UTC Comment hidden (obsolete)
Comment 29 Josef Moravec 2018-06-25 15:32:03 UTC Comment hidden (obsolete)
Comment 30 Josef Moravec 2018-06-25 15:32:08 UTC Comment hidden (obsolete)
Comment 31 Josef Moravec 2018-06-25 15:32:13 UTC Comment hidden (obsolete)
Comment 32 Josef Moravec 2018-06-25 15:32:18 UTC Comment hidden (obsolete)
Comment 33 Josef Moravec 2018-06-25 15:32:23 UTC Comment hidden (obsolete)
Comment 34 Josef Moravec 2018-06-25 15:32:28 UTC Comment hidden (obsolete)
Comment 35 Josef Moravec 2018-06-25 15:42:23 UTC
I squashed the original patches for better readability, but then added 4 new follow-ups ;) I tried to reflect the last changes in codebase and coding guidelines. (things are changing quickly).

Note for QA: the feature is working OK, but there are definitely some areas where the code could be improved.
Comment 36 Katrin Fischer 2018-07-08 12:04:05 UTC
Trying to tackle this:

1) QA scripts
Only the second looks valid, as this class is new and added by the patch set:

 FAIL	Koha/CmsPage.pm
   FAIL	  pod coverage
		POD coverage was greater before, try perl

 FAIL	Koha/CmsPages.pm
   FAIL	  pod coverage
		POD is missing for 'object_class'

 FAIL	Koha/Schema/Result/CmsPage.pm
   FAIL	  pod coverage
		POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666

Can you please fix?

2) Code review

a) Schema patches would be much better in a separate patch. Ok for now as the patch still applies. For a rebase separating those change might be good.

b) In opac-cmspages there is:
+        flagsrequired   => { borrow => 1 },
The borrow permission has been removed since. (blocker)

c) Comment was removed unnecessarily, just needs to be moved into its right spot below again:
-# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens

d) One file uses qw( -utf-8) but another does not:
+use CGI;
+use CGI qw( -utf8 );  (blocker)


3) Unit tests
... all passing!

4) Feature tests

OPAC

a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below)

b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed.

c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here.

d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future.

e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker)

f) Navigation looks strange when working with multiple levels. Repeating the level before seems unnecessary and only takes up space?

    Level 1
    Level 1 › Level 2
    Level 2 › Level 3

Also, clicking on the different links, sometimes a part of the navigation disappears. I think this is a little too wonky to pass. Can you take another look please? (blocker)

Intranet

Where do the pages appear in the intranet?



Generally I think this will be a great and really helpful addition and looking forward to return to this!
Comment 37 Aleisha Amohia 2018-08-28 22:53:51 UTC Comment hidden (obsolete)
Comment 38 Aleisha Amohia 2018-08-28 22:54:00 UTC Comment hidden (obsolete)
Comment 39 Aleisha Amohia 2018-08-28 22:54:08 UTC Comment hidden (obsolete)
Comment 40 Aleisha Amohia 2018-08-28 22:54:15 UTC Comment hidden (obsolete)
Comment 41 Aleisha Amohia 2018-08-28 22:54:22 UTC Comment hidden (obsolete)
Comment 42 Aleisha Amohia 2018-08-28 22:54:29 UTC Comment hidden (obsolete)
Comment 43 Aleisha Amohia 2018-08-28 22:55:00 UTC Comment hidden (obsolete)
Comment 44 Aleisha Amohia 2018-08-28 23:38:25 UTC Comment hidden (obsolete)
Comment 45 Aleisha Amohia 2018-08-29 03:21:31 UTC Comment hidden (obsolete)
Comment 46 Aleisha Amohia 2018-09-24 03:01:21 UTC Comment hidden (obsolete)
Comment 47 Aleisha Amohia 2018-12-17 21:16:32 UTC Comment hidden (obsolete)
Comment 48 Aleisha Amohia 2018-12-17 21:16:40 UTC Comment hidden (obsolete)
Comment 49 Aleisha Amohia 2018-12-17 21:16:47 UTC Comment hidden (obsolete)
Comment 50 Aleisha Amohia 2018-12-17 21:16:55 UTC Comment hidden (obsolete)
Comment 51 Aleisha Amohia 2018-12-17 21:17:02 UTC Comment hidden (obsolete)
Comment 52 Aleisha Amohia 2018-12-17 21:17:19 UTC Comment hidden (obsolete)
Comment 53 Aleisha Amohia 2018-12-17 21:17:29 UTC Comment hidden (obsolete)
Comment 54 Aleisha Amohia 2018-12-17 21:17:36 UTC Comment hidden (obsolete)
Comment 55 Aleisha Amohia 2018-12-17 21:17:43 UTC Comment hidden (obsolete)
Comment 56 Aleisha Amohia 2018-12-17 21:18:38 UTC
This has been rebased and can be tested. Navigation could still use work.
Comment 57 Michal Denar 2018-12-20 09:22:22 UTC Comment hidden (obsolete)
Comment 58 Michal Denar 2018-12-20 09:22:32 UTC Comment hidden (obsolete)
Comment 59 Michal Denar 2018-12-20 09:22:40 UTC Comment hidden (obsolete)
Comment 60 Michal Denar 2018-12-20 09:22:50 UTC Comment hidden (obsolete)
Comment 61 Michal Denar 2018-12-20 09:23:02 UTC Comment hidden (obsolete)
Comment 62 Michal Denar 2018-12-20 09:23:13 UTC Comment hidden (obsolete)
Comment 63 Michal Denar 2018-12-20 09:23:32 UTC Comment hidden (obsolete)
Comment 64 Michal Denar 2018-12-20 09:23:44 UTC Comment hidden (obsolete)
Comment 65 Michal Denar 2018-12-20 09:23:55 UTC Comment hidden (obsolete)
Comment 66 Katrin Fischer 2019-02-02 20:45:33 UTC
Conflicts in the Schema changes part (should be a separate patch) Can you please fix and maybe separate these changes out?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15326: Add CMS feature
Applying: Bug 15326: (follow-up) Add CMS feature
Using index info to reconstruct a base tree...
M	Koha/Schema/Result/Branch.pm
Falling back to patching base and 3-way merge...
Removing t/Pages.t
Auto-merging Koha/Schema/Result/Branch.pm
CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 15326: (follow-up) Add CMS feature
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-15326-follow-up-Add-CMS-feature-E4XbRe.patch
Comment 67 Aleisha Amohia 2019-02-03 23:37:14 UTC Comment hidden (obsolete)
Comment 68 Aleisha Amohia 2019-02-03 23:37:24 UTC Comment hidden (obsolete)
Comment 69 Aleisha Amohia 2019-02-03 23:37:31 UTC Comment hidden (obsolete)
Comment 70 Aleisha Amohia 2019-02-03 23:37:37 UTC Comment hidden (obsolete)
Comment 71 Aleisha Amohia 2019-02-03 23:37:45 UTC Comment hidden (obsolete)
Comment 72 Aleisha Amohia 2019-02-03 23:37:52 UTC Comment hidden (obsolete)
Comment 73 Aleisha Amohia 2019-02-03 23:37:59 UTC Comment hidden (obsolete)
Comment 74 Aleisha Amohia 2019-02-03 23:38:06 UTC Comment hidden (obsolete)
Comment 75 Aleisha Amohia 2019-02-03 23:38:13 UTC Comment hidden (obsolete)
Comment 76 Aleisha Amohia 2019-02-03 23:39:22 UTC Comment hidden (obsolete)
Comment 77 Aleisha Amohia 2019-02-03 23:39:52 UTC
(In reply to Katrin Fischer from comment #66)
> Conflicts in the Schema changes part (should be a separate patch) Can you
> please fix and maybe separate these changes out?
> 
> Apply? [(y)es, (n)o, (i)nteractive] y
> Applying: Bug 15326: Add CMS feature
> Applying: Bug 15326: (follow-up) Add CMS feature
> Using index info to reconstruct a base tree...
> M	Koha/Schema/Result/Branch.pm
> Falling back to patching base and 3-way merge...
> Removing t/Pages.t
> Auto-merging Koha/Schema/Result/Branch.pm
> CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm
> error: Failed to merge in the changes.
> Patch failed at 0001 Bug 15326: (follow-up) Add CMS feature
> The copy of the patch that failed is found in: .git/rebase-apply/patch
> When you have resolved this problem run "git bz apply --continue".
> If you would prefer to skip this patch, instead run "git bz apply --skip".
> To restore the original branch and stop patching run "git bz apply --abort".
> Patch left in /tmp/Bug-15326-follow-up-Add-CMS-feature-E4XbRe.patch

Rebased and moved schema fixes into a separate patch
Comment 78 Katrin Fischer 2019-02-04 06:50:41 UTC
Hi Aleisha, you can usually set back to "Signed off" after a rebase if it was before (unless you feel the changes were too heavy and should be retested)
Comment 79 Aleisha Amohia 2019-02-04 19:39:59 UTC
(In reply to Katrin Fischer from comment #78)
> Hi Aleisha, you can usually set back to "Signed off" after a rebase if it
> was before (unless you feel the changes were too heavy and should be
> retested)

Set back to Signed off!
Comment 80 Katrin Fischer 2019-03-12 00:07:29 UTC
*** Bug 12806 has been marked as a duplicate of this bug. ***
Comment 81 Marcel de Rooy 2019-03-22 06:44:24 UTC Comment hidden (obsolete)
Comment 82 Martin Renvoize 2019-04-08 11:16:10 UTC Comment hidden (obsolete)
Comment 83 Martin Renvoize 2019-04-08 11:16:16 UTC Comment hidden (obsolete)
Comment 84 Martin Renvoize 2019-04-08 11:16:20 UTC Comment hidden (obsolete)
Comment 85 Martin Renvoize 2019-04-08 11:16:25 UTC Comment hidden (obsolete)
Comment 86 Martin Renvoize 2019-04-08 11:16:30 UTC Comment hidden (obsolete)
Comment 87 Martin Renvoize 2019-04-08 11:16:34 UTC Comment hidden (obsolete)
Comment 88 Martin Renvoize 2019-04-08 11:16:39 UTC Comment hidden (obsolete)
Comment 89 Martin Renvoize 2019-04-08 11:16:44 UTC Comment hidden (obsolete)
Comment 90 Martin Renvoize 2019-04-08 11:16:48 UTC Comment hidden (obsolete)
Comment 91 Martin Renvoize 2019-04-08 11:16:53 UTC Comment hidden (obsolete)
Comment 92 Martin Renvoize 2019-04-08 11:17:32 UTC
Rebased to get this moving again.
Comment 93 Owen Leonard 2019-04-08 15:56:33 UTC
A quick look shows a few issues which need to be addressed: YUI grids in the staff client, LESS in the OPAC, previously deleted JS in tools-menu.inc. I'm going to submit a follow-up, but marking failed until then.
Comment 94 Owen Leonard 2019-04-09 14:53:40 UTC Comment hidden (obsolete)
Comment 95 Owen Leonard 2019-04-09 14:53:45 UTC Comment hidden (obsolete)
Comment 96 Owen Leonard 2019-04-09 14:53:50 UTC Comment hidden (obsolete)
Comment 97 Owen Leonard 2019-04-09 14:55:03 UTC
I fixed template issues reported by the QA tool, but not Perl errors. I'm leaving this in 'failed QA' because of that.
Comment 98 Owen Leonard 2019-04-09 15:06:33 UTC
One thing that I would really like to see improved:

I think the navigation menu in the OPAC doesn't work the way it should. For example, this menu based on pages I was testing with:

- About us
  - About us › Nelsonville Public Library
  - About us › Athens Public Library
  - About us › The Plains Public Library

Why is "About us" repeated for each sub-page? Why aren't sub-pages displayed as a list nested inside the list containing the parent link? Based on other CMS navigation menus I would have expected this:

<ul>
    <li>About us
        <ul>
            <li>Nelsonville Public Library</li>
            <li>Athens Public Library</li>
            <li>The Plains Public Library</li>
        </ul>
    </li>
</ul>

This is semantically more correct and provides more flexibility for CSS styling because you can leverage element nesting.

The other thing I see which seems wrong is that if I'm looking at the parent page ("About us" in the example above) I don't see the sub-pages. I would expect them to either be shown all the time or only when viewing the parent page or its sub-pages.
Comment 99 Owen Leonard 2019-04-09 15:07:29 UTC Comment hidden (obsolete)
Comment 100 Nick Clemens 2019-12-09 12:08:15 UTC Comment hidden (obsolete)
Comment 101 Nick Clemens 2019-12-09 12:08:21 UTC Comment hidden (obsolete)
Comment 102 Nick Clemens 2019-12-09 12:08:26 UTC Comment hidden (obsolete)
Comment 103 Nick Clemens 2019-12-09 12:08:31 UTC Comment hidden (obsolete)
Comment 104 Nick Clemens 2019-12-09 12:08:36 UTC Comment hidden (obsolete)
Comment 105 Nick Clemens 2019-12-09 12:08:41 UTC Comment hidden (obsolete)
Comment 106 Nick Clemens 2019-12-09 12:08:45 UTC Comment hidden (obsolete)
Comment 107 Nick Clemens 2019-12-09 12:08:50 UTC Comment hidden (obsolete)
Comment 108 Nick Clemens 2019-12-09 12:08:55 UTC Comment hidden (obsolete)
Comment 109 Nick Clemens 2019-12-09 12:08:59 UTC Comment hidden (obsolete)
Comment 110 Nick Clemens 2019-12-09 12:09:04 UTC Comment hidden (obsolete)
Comment 111 Nick Clemens 2019-12-09 12:09:10 UTC Comment hidden (obsolete)
Comment 112 Nick Clemens 2019-12-09 12:09:15 UTC Comment hidden (obsolete)
Comment 113 Nick Clemens 2019-12-09 12:09:20 UTC Comment hidden (obsolete)
Comment 114 Nick Clemens 2019-12-09 12:09:25 UTC Comment hidden (obsolete)
Comment 115 Nick Clemens 2019-12-09 12:21:06 UTC
I did what I could to move this along, rebased, cleared QA errors, fixed filters

Issues I had:
1 - The content field is hidden when I try to make a new page
2 - I cannot add a page under strict mode - the call to update_or_create doesn't like id as '' - if i try ot make it undef when not set, then the dbix gets upset about using key primary with no values

It appears that title_link is enforced as unique in the module, though not in the table.

If we do enforce this we can add a new constraint on that and use if for update/create but it requires more work

https://metacpan.org/pod/DBIx::Class::ResultSet#update_or_create
Note: Take care when using update_or_create with a table having columns with default values that you intend to be automatically supplied by the database (e.g. an auto_increment primary key column). In normal usage, the value of such columns should NOT be included at all in the call to update_or_create, even when set to undef.
Comment 116 Owen Leonard 2020-01-10 21:29:25 UTC
Shouldn't hitting an unpublished page return a 404 error?
Comment 117 Owen Leonard 2020-01-10 23:38:16 UTC Comment hidden (obsolete)
Comment 118 Owen Leonard 2020-01-10 23:39:33 UTC
These patches still apply, so it's a great time for more testing and fixes!

(In reply to Nick Clemens from comment #115)
> 1 - The content field is hidden when I try to make a new page

I think my patch fixes this issue.
Comment 119 Nick Clemens 2020-03-24 13:39:15 UTC Comment hidden (obsolete)
Comment 120 Nick Clemens 2020-03-24 13:39:20 UTC Comment hidden (obsolete)
Comment 121 Nick Clemens 2020-03-24 13:39:25 UTC Comment hidden (obsolete)
Comment 122 Nick Clemens 2020-03-24 13:39:31 UTC Comment hidden (obsolete)
Comment 123 Nick Clemens 2020-03-24 13:39:36 UTC Comment hidden (obsolete)
Comment 124 Nick Clemens 2020-03-24 13:39:42 UTC Comment hidden (obsolete)
Comment 125 Nick Clemens 2020-03-24 13:39:47 UTC Comment hidden (obsolete)
Comment 126 Nick Clemens 2020-03-24 13:39:53 UTC Comment hidden (obsolete)
Comment 127 Nick Clemens 2020-03-24 13:39:58 UTC Comment hidden (obsolete)
Comment 128 Nick Clemens 2020-03-24 13:40:03 UTC Comment hidden (obsolete)
Comment 129 Nick Clemens 2020-03-24 13:40:08 UTC Comment hidden (obsolete)
Comment 130 Nick Clemens 2020-03-24 13:40:14 UTC Comment hidden (obsolete)
Comment 131 Nick Clemens 2020-03-24 13:40:19 UTC Comment hidden (obsolete)
Comment 132 Nick Clemens 2020-03-24 13:40:24 UTC Comment hidden (obsolete)
Comment 133 Nick Clemens 2020-03-24 13:40:30 UTC Comment hidden (obsolete)
Comment 134 Nick Clemens 2020-03-24 13:40:35 UTC Comment hidden (obsolete)
Comment 135 Nick Clemens 2020-03-24 13:49:08 UTC
Rebased, found issues:

Parent child links are a confusing:
 List display parent name needlessly
 Cannot see children from parent in breadcrumbs

Can access unpublished pages

Library specific pages are listed for all branches

Staff side link should use link title not page title

Can view staff pages on opac
Comment 136 Aleisha Amohia 2021-12-08 04:56:00 UTC Comment hidden (obsolete)
Comment 137 Aleisha Amohia 2021-12-08 04:56:08 UTC Comment hidden (obsolete)
Comment 138 Aleisha Amohia 2021-12-08 04:56:16 UTC Comment hidden (obsolete)
Comment 139 Aleisha Amohia 2021-12-08 04:56:23 UTC Comment hidden (obsolete)
Comment 140 Aleisha Amohia 2021-12-08 04:56:30 UTC Comment hidden (obsolete)
Comment 141 Aleisha Amohia 2021-12-08 04:56:36 UTC Comment hidden (obsolete)
Comment 142 Aleisha Amohia 2021-12-08 04:56:42 UTC Comment hidden (obsolete)
Comment 143 Aleisha Amohia 2021-12-08 04:56:49 UTC Comment hidden (obsolete)
Comment 144 Aleisha Amohia 2021-12-08 04:56:56 UTC Comment hidden (obsolete)
Comment 145 Aleisha Amohia 2021-12-08 04:57:03 UTC Comment hidden (obsolete)
Comment 146 Aleisha Amohia 2021-12-08 04:57:10 UTC Comment hidden (obsolete)
Comment 147 Aleisha Amohia 2021-12-08 04:57:18 UTC Comment hidden (obsolete)
Comment 148 Aleisha Amohia 2021-12-08 04:57:25 UTC Comment hidden (obsolete)
Comment 149 Aleisha Amohia 2021-12-08 04:57:32 UTC Comment hidden (obsolete)
Comment 150 Aleisha Amohia 2021-12-08 04:57:38 UTC Comment hidden (obsolete)
Comment 151 Aleisha Amohia 2021-12-08 04:57:44 UTC Comment hidden (obsolete)
Comment 152 Aleisha Amohia 2021-12-08 04:57:50 UTC Comment hidden (obsolete)
Comment 153 Jonathan Druart 2021-12-08 09:34:13 UTC
Aleisha, with the recent "additional contents" changes we could have a new type of content "page". They would be stored in the same DB table and would profit from the other possibilities (translation, etc.)

Is it something that could work for you?
Comment 154 Marcel de Rooy 2021-12-08 12:04:20 UTC
(In reply to Jonathan Druart from comment #153)
> Aleisha, with the recent "additional contents" changes we could have a new
> type of content "page". They would be stored in the same DB table and would
> profit from the other possibilities (translation, etc.)
> 
> Is it something that could work for you?

Yes, I was thinking the same. Actually I am already using the news database as a simple cms for some local pages.
Perhaps some of the additional features(?) here could be incorporated.
Comment 155 Aleisha Amohia 2021-12-16 04:18:06 UTC Comment hidden (obsolete)
Comment 156 Aleisha Amohia 2021-12-17 02:27:39 UTC Comment hidden (obsolete)
Comment 157 Lucas Gass 2021-12-21 18:45:17 UTC
Aleisha,

This is a very nice looking feature! A couple things I noticed while testing:

1. If I make a page for the OPAC or both and click the 'View' link I get a 404 error at: http://localhost:8080/cgi-bin/koha/page.pl?page_id=7
In the OPACMoreSearches line the link is build correctly as http://localhost:8080/cgi-bin/koha/opac-page.pl?page_id=7 and I can see it without 404.

2. IF I click on the dropdown-toggle arrow next to the view button I see the 2 options 'View on OPAC' and 'View on staff client'. They work good. However, if the page is set for staff only or OPAC only when I click the button nothing happens.

Thanks for working on this.
Comment 158 Aleisha Amohia 2022-06-22 22:05:42 UTC Comment hidden (obsolete)
Comment 159 David Nind 2022-06-23 02:55:10 UTC
1. Actions menu for pages: "View on staff client" should be "View on staff interface" (see terminology list).

2. If I have a default version and an English version, when the English version has a different title:
   - View - without selecting from the drop down list, View on OPAC, and View on staff client: get a "This page does not exist." error, but the title  is listed under the pages heading - the URLs are different (for example in the OPAC the page opens to this URL http://127.0.0.1:8080/cgi-bin/koha/opac-page.pl?page_id=3 and for the link under Pages it is http://127.0.0.1:8080/cgi-bin/koha/opac-page.pl?page_id=4)
   - If the titles are the same, it appears as expected.

3. The bulleted list of pages is not indetned/aligned under "Write custom pages"

Just some thoughts:*
1. Is it necessary to list the pages under Tools > Additional tools > Pages? (Unless this is the only way to view them.) Couldn't these just be accessed from the filter like you see when you go into the pages page?
2. When viewing the pages from the bulleted list under Pages, I found the listing of pages in the left side bar as well a bit confusing. Is this the only way to see the pages targeted for the staff interface?
3. Preview - it just shows the default, should the other languages be shown?
4. If you have a lot of pages, being listed in the OPAC in the masthead could get rather long.

* Just some additional things I noticed - I'm not tied to them in any way, just some first impressions!

I didn't install and test with another language installed.
Comment 160 Aleisha Amohia 2022-06-30 00:47:52 UTC Comment hidden (obsolete)
Comment 161 Aleisha Amohia 2022-06-30 00:49:46 UTC
Thanks for testing David. I changed 'View on staff client' to 'View on librarian interface' to match the language used elsewhere in the Additional Contents tools.

I decided to remove the navigation for pages as, you're right, they didn't really make sense. I also removed the View buttons. Instead I added a new column to the Pages table to include the new Page URLs so they can be inserted where the library chooses, and be used to View.
Comment 162 Biblibre Sandboxes 2022-06-30 13:04:16 UTC Comment hidden (obsolete)
Comment 163 Lucas Gass 2022-06-30 14:30:21 UTC
When I add a custom page for the 'OPAC' or 'Librarian and OPAC' I do not see a news item but I do see the empty news container and the RSS container (.rssnews-container) and words like "RSS feed for Centerville and system-wide library news".

Can that be removed if we have no actual news items?
Comment 164 Aleisha Amohia 2022-08-02 00:41:34 UTC Comment hidden (obsolete)
Comment 165 Aleisha Amohia 2022-08-02 05:01:56 UTC Comment hidden (obsolete)
Comment 166 ByWater Sandboxes 2022-08-11 20:42:50 UTC Comment hidden (obsolete)
Comment 167 ByWater Sandboxes 2022-08-11 20:42:58 UTC
Created attachment 139029 [details] [review]
Bug 15326: Using AdditionalContents for custom pages on OPAC

This page utilises the Additional Contents feature to add custom pages
to the staff client and the OPAC in the user's desired language.

To test:
1. Apply patch and restart services
2. In the staff client, go to Tools, then go to the new 'Pages' page
3. Add a new page to display on both the staff client and OPAC.
4. Confirm the URLs in the Page URL column work as expected.
5. Confirm that any pages made for the staff client only do not show in
the OPAC, and that any pages made for the OPAC only do not show in the
staff client.
6. Confirm that pages do not show on the OPAC main page where news items
show. Confirm news items show on the OPAC main page as expected.

Sponsored-by: Chartered Accountants Australia and New Zealand

Signed-off-by: Thibault Kero <thibault.keromnes@univ-paris8.fr>

Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com>

Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com>
Comment 168 ByWater Sandboxes 2022-08-11 20:42:59 UTC
Created attachment 139030 [details] [review]
Bug 15326: (follow-up) Hide RSS feed if no news items

If there are pages but no news items showing on the OPAC, the RSS feed container
should not show.

Sponsored-by: Horowhenua Libraries Trust

Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com>
Comment 169 ByWater Sandboxes 2022-08-11 20:43:09 UTC Comment hidden (obsolete)
Comment 170 Lisette Scheer 2022-08-11 20:43:56 UTC
Worked great! 
Lisette
Comment 171 Owen Leonard 2022-08-12 12:33:55 UTC
It looks like custom pages in the staff interface require "tools => '*'" permission. I don't know if it's intentional, but I would think that pages should require only basic staff access permission.

It would certainly be interesting to include custom permission settings for custom pages, but without such a capability I think general access is a sensible default.

One thing which is potentially confusing: It doesn't look like the library choice has any bearing on the behavior of the page? I wonder if users might assume that a page created with a specific library specified will only be viewable to users logged in at that library?
Comment 172 Aleisha Amohia 2022-08-15 05:37:16 UTC
Created attachment 139111 [details] [review]
Bug 15326: (follow-up) Fix staff permissions and consider library limits

To test:
1. Take note of what your logged in library is
2. Add a new page that can be viewed on the OPAC and staff interface.
Limit the library to a different library, not your logged in library
3. Use a News item to create a hyperlink to your new page on the OPAC
and staff interface.
4. Confirm that a page error shows if you try to view the new page.
5. Edit the new page and set the library to All libraries.
6. Try to go to the new page again and confirm it shows.
7. Log out and log back into the staff interface as a staff user that
isn't a superlibrarian
8. Confirm you can view the new page as this user

Sponsored-by: Horowhenua Libraries Trust
Comment 173 Owen Leonard 2022-08-15 12:20:33 UTC
Created attachment 139123 [details] [review]
Bug 15326: Using AdditionalContents for custom pages on OPAC

This page utilises the Additional Contents feature to add custom pages
to the staff client and the OPAC in the user's desired language.

To test:
1. Apply patch and restart services
2. In the staff client, go to Tools, then go to the new 'Pages' page
3. Add a new page to display on both the staff client and OPAC.
4. Confirm the URLs in the Page URL column work as expected.
5. Confirm that any pages made for the staff client only do not show in
the OPAC, and that any pages made for the OPAC only do not show in the
staff client.
6. Confirm that pages do not show on the OPAC main page where news items
show. Confirm news items show on the OPAC main page as expected.

Sponsored-by: Chartered Accountants Australia and New Zealand

Signed-off-by: Thibault Kero <thibault.keromnes@univ-paris8.fr>

Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com>

Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 174 Owen Leonard 2022-08-15 12:20:42 UTC
Created attachment 139124 [details] [review]
Bug 15326: (follow-up) Hide RSS feed if no news items

If there are pages but no news items showing on the OPAC, the RSS feed container
should not show.

Sponsored-by: Horowhenua Libraries Trust

Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 175 Owen Leonard 2022-08-15 12:20:52 UTC
Created attachment 139125 [details] [review]
Bug 15326: (follow-up) Fix staff permissions and consider library limits

To test:
1. Take note of what your logged in library is
2. Add a new page that can be viewed on the OPAC and staff interface.
Limit the library to a different library, not your logged in library
3. Use a News item to create a hyperlink to your new page on the OPAC
and staff interface.
4. Confirm that a page error shows if you try to view the new page.
5. Edit the new page and set the library to All libraries.
6. Try to go to the new page again and confirm it shows.
7. Log out and log back into the staff interface as a staff user that
isn't a superlibrarian
8. Confirm you can view the new page as this user

Sponsored-by: Horowhenua Libraries Trust

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 176 Kyle M Hall 2022-08-16 10:54:11 UTC
Created attachment 139172 [details] [review]
Bug 15326: Using AdditionalContents for custom pages on OPAC

This page utilises the Additional Contents feature to add custom pages
to the staff client and the OPAC in the user's desired language.

To test:
1. Apply patch and restart services
2. In the staff client, go to Tools, then go to the new 'Pages' page
3. Add a new page to display on both the staff client and OPAC.
4. Confirm the URLs in the Page URL column work as expected.
5. Confirm that any pages made for the staff client only do not show in
the OPAC, and that any pages made for the OPAC only do not show in the
staff client.
6. Confirm that pages do not show on the OPAC main page where news items
show. Confirm news items show on the OPAC main page as expected.

Sponsored-by: Chartered Accountants Australia and New Zealand

Signed-off-by: Thibault Kero <thibault.keromnes@univ-paris8.fr>

Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com>

Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 177 Kyle M Hall 2022-08-16 10:54:25 UTC
Created attachment 139173 [details] [review]
Bug 15326: (follow-up) Hide RSS feed if no news items

If there are pages but no news items showing on the OPAC, the RSS feed container
should not show.

Sponsored-by: Horowhenua Libraries Trust

Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 178 Kyle M Hall 2022-08-16 10:54:32 UTC
Created attachment 139174 [details] [review]
Bug 15326: (follow-up) Fix staff permissions and consider library limits

To test:
1. Take note of what your logged in library is
2. Add a new page that can be viewed on the OPAC and staff interface.
Limit the library to a different library, not your logged in library
3. Use a News item to create a hyperlink to your new page on the OPAC
and staff interface.
4. Confirm that a page error shows if you try to view the new page.
5. Edit the new page and set the library to All libraries.
6. Try to go to the new page again and confirm it shows.
7. Log out and log back into the staff interface as a staff user that
isn't a superlibrarian
8. Confirm you can view the new page as this user

Sponsored-by: Horowhenua Libraries Trust

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 179 Tomás Cohen Arazi 2022-08-16 18:41:50 UTC
:-D
Comment 180 Tomás Cohen Arazi 2022-08-16 19:00:43 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 181 Aleisha Amohia 2022-08-16 21:09:40 UTC
YAY! Over the years this development has been sponsored by Region Halland, Chartered Accountants Australia and New Zealand, and Horowhenua Libraries Trust. I'm sure they'll all be so pleased this has been pushed. Thanks all
Comment 182 Tomás Cohen Arazi 2022-08-16 23:20:53 UTC
(In reply to Aleisha Amohia from comment #181)
> YAY! Over the years this development has been sponsored by Region Halland,
> Chartered Accountants Australia and New Zealand, and Horowhenua Libraries
> Trust. I'm sure they'll all be so pleased this has been pushed. Thanks all

Yeah, it was out of radar, and I was very happy about pushing it when noticed the QA team approved it.

Only the HLT got credited on the patches, though. If possible, please pm me the right names for the sponsors so I add them when the release happens.

Thanks and congrats!
Comment 183 Marcel de Rooy 2022-08-17 11:39:20 UTC
Great to see this got pushed while making use of the additional contents functionality that wasnt there at the start.
Comment 184 Marcel de Rooy 2022-08-17 11:52:09 UTC
We suffer here from a similar issue as on bug 31370 (for the preview button).

The URL shown is the one belonging to 'default'. But when you add another langauge, you will create another record (another idnew) with another URL which is not shown on the list view. But in contrast to the content, this id is only visible in the address bar which could be considered *less* user friendly.

What I personally would like, is a URL that works for all languages. If the language is found, show it. If it is not found, fall back to default. In that way you would only need one umbrella URL for page and translations.
Comment 185 Marcel de Rooy 2022-08-17 12:21:45 UTC
With reference to the previous comment, I think we should consider bug 31383
Comment 186 Marcel de Rooy 2022-08-17 12:27:31 UTC
(In reply to Marcel de Rooy from comment #184)
> But in contrast to the content, this id
> is only visible in the address bar which could be considered *less* user
> friendly.

I need to add that is not shown at all actually. But you could add it yourself on the address bar if you know it.
Comment 187 Marcel de Rooy 2022-08-17 13:54:27 UTC
(In reply to Marcel de Rooy from comment #184)
> What I personally would like, is a URL that works for all languages. If the
> language is found, show it. If it is not found, fall back to default. In
> that way you would only need one umbrella URL for page and translations.

See my proposal on bug 31385
Comment 188 Tomás Cohen Arazi 2022-08-17 14:07:29 UTC
(In reply to Marcel de Rooy from comment #187)
> (In reply to Marcel de Rooy from comment #184)
> > What I personally would like, is a URL that works for all languages. If the
> > language is found, show it. If it is not found, fall back to default. In
> > that way you would only need one umbrella URL for page and translations.
> 
> See my proposal on bug 31385

Thanks! Can you take a look, Kyle?
Comment 189 David Cook 2022-08-22 03:28:51 UTC
For documentation team, might want to look at Bug 7840
Comment 190 Lucas Gass 2022-10-03 22:18:49 UTC
Very nice improvement that will not be backported to 22.05.x :)