Attachment 88246 Details for Bug 22664 – Bug 22664: More making acquisitions links more easily clickable

[patch] Bug 22664: More making acquisitions links more easily clickable

Bug-22664-More-making-acquisitions-links-more-easi.patch (text/plain), 4.28 KB, created by Liz Rea on 2019-04-18 01:16:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2019-04-18 01:16:23 UTC

Size: 4.28 KB

patch

obsolete

>From a977e12191155ea95d351e274887ff3e256a2959 Mon Sep 17 00:00:00 2001
>From: Liz Rea <wizzyrea@gmail.com>
>Date: Wed, 17 Apr 2019 05:20:23 +0000
>Subject: [PATCH] Bug 22664: More making acquisitions links more easily
> clickable
>
>To test:
>
>* create a basket with an order from a staged record, and an order from
>a suggestion
>* add that basket to a basket group when you close it.
>* note that the links to the basket in the first column, the link to the
>basket group in the second column, and the link to
>the suggester in the summary column are very small (only the ID# is
>linked)
>* apply this patch, restart the things
>* refresh the page, note that the previously ogled links are now bigger
>and easier to find and click, and that the links work and such
>* rejoice.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>index b34894d7d9..0a319f1938 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
>@@ -129,10 +129,10 @@
>         <tbody class="filterclass">
>         [% FOREACH loop_order IN loop_orders %]
>             <tr>
>-                <td class="basketfilterclass">[% loop_order.basketname | html %] (<a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% loop_order.basketno | uri %]">[% loop_order.basketno | html %]</a>)</td>
>+                <td class="basketfilterclass"><a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% loop_order.basketno | uri %]">[% loop_order.basketname | html %] ([% loop_order.basketno | html %])</a></td>
>                 <td>
>                   [% IF loop_order.basketgroupid %]
>-                    [% loop_order.basketgroupname | html %] (<a href="/cgi-bin/koha/acqui/basketgroup.pl?op=add&amp;booksellerid=[% booksellerid | uri %]&amp;basketgroupid=[% loop_order.basketgroupid | uri %]">[% loop_order.basketgroupid | html %]</a>)
>+                  <a href="/cgi-bin/koha/acqui/basketgroup.pl?op=add&amp;booksellerid=[% booksellerid | uri %]&amp;basketgroupid=[% loop_order.basketgroupid | uri %]">[% loop_order.basketgroupname | html %] ([% loop_order.basketgroupid | html %])</a>
>                   [% ELSE %]
>                     No basket group
>                   [% END %]
>@@ -150,8 +150,7 @@
>                 [% END %]
>                 [% IF ( loop_order.suggestionid ) %]
>                     <br/>
>-                    Suggested by: [% loop_order.surnamesuggestedby | html %][% IF ( loop_order.firstnamesuggestedby ) %],Â [% loop_order.firstnamesuggestedby | html %] [% END %]
>-                    (<a href="/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=[% loop_order.suggestionid | uri %]&amp;op=show">suggestion #[% loop_order.suggestionid | html %]</a>)
>+                    Suggested by: <a href="/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=[% loop_order.suggestionid | uri %]&amp;op=show">[% loop_order.surnamesuggestedby | html %][% IF ( loop_order.firstnamesuggestedby ) %],Â [% loop_order.firstnamesuggestedby | html %] [% END %]( #[% loop_order.suggestionid | html %])</a>
>                 [% END %]
>                 <br />
>                 [% IF ( loop_order.order_internalnote ) %]
>@@ -276,10 +275,10 @@
>     <tbody class="filterclass">
>         [% FOREACH order IN loop_received %]
>             <tr>
>-                <td>[% order.basketname | html %] (<a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% order.basketno | uri %]">[% order.basketno | html %]</a>)</td>
>+                <td><a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% order.basketno | uri %]"> [% order.basketname | html %] ([% order.basketno | html %])</a></td>
>                 <td>
>                   [% IF order.basketgroupid %]
>-                    [% order.basketgroupname | html %] (<a href="/cgi-bin/koha/acqui/basketgroup.pl?op=add&amp;booksellerid=[% booksellerid | uri %]&amp;basketgroupid=[% order.basketgroupid | uri %]">[% order.basketgroupid | html %]</a>)
>+                  <a href="/cgi-bin/koha/acqui/basketgroup.pl?op=add&amp;booksellerid=[% booksellerid | uri %]">[% order.basketgroupname | html %] ([% order.basketgroupid | html %])</a>
>                   [% ELSE %]
>                     No basket group
>                   [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22664: 87546 | 87547 | 87549 | 88159 | 88246 | 88290 | 88291 | 88684 | 88685