Attachment 88879 Details for Bug 8000 – Bug 8000: (QA follow-up) Two lastminute fixes

[patch] Bug 8000: (QA follow-up) Two lastminute fixes

Bug-8000-QA-follow-up-Two-lastminute-fixes.patch (text/plain), 1.89 KB, created by Marcel de Rooy on 2019-04-26 10:21:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-04-26 10:21:19 UTC

Size: 1.89 KB

patch

obsolete

>From 98e6d2401ee36425362e791e0e1871604b7196ae Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 26 Apr 2019 09:05:01 +0000
>Subject: [PATCH] Bug 8000: (QA follow-up) Two lastminute fixes
>Content-Type: text/plain; charset=utf-8
>
>[1] Number of tests Letters.t
>[2] Resolving uninitialized warn on Letters, L1327
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/Letters.pm            | 2 +-
> t/db_dependent/Letters.t | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 2ce5db359c..b8175f5521 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -1324,7 +1324,7 @@ sub _send_message_by_email {
> 
>     $sendmail_params{'Auth'} = {user => $username, pass => $password, method => $method} if $username;
> 
>-    _update_message_to_address($message->{'message_id'},$sendmail_params{To}) if $message->{to_address} ne $sendmail_params{To}; #if initial message address was empty, coming here means that a to address was found and queue should be updated; same if to address was overriden by create_message_headers
>+    _update_message_to_address($message->{'message_id'},$sendmail_params{To}) if !$message->{to_address} || $message->{to_address} ne $sendmail_params{To}; #if initial message address was empty, coming here means that a to address was found and queue should be updated; same if to address was overriden by create_message_headers
> 
>     if ( Mail::Sendmail::sendmail( %sendmail_params ) ) {
>         _set_message_status( { message_id => $message->{'message_id'},
>diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t
>index 8bd76fca4a..41f2a05fb8 100644
>--- a/t/db_dependent/Letters.t
>+++ b/t/db_dependent/Letters.t
>@@ -18,7 +18,7 @@
> # along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>-use Test::More tests => 67;
>+use Test::More tests => 69;
> use Test::MockModule;
> use Test::Warn;
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 8000: 21976 | 22315 | 24784 | 25917 | 25919 | 25920 | 25923 | 25924 | 25925 | 25926 | 25927 | 25928 | 25939 | 25950 | 25951 | 26446 | 37463 | 37464 | 37465 | 37466 | 37467 | 37468 | 37469 | 37472 | 37473 | 37474 | 37475 | 37476 | 37477 | 37478 | 37481 | 37482 | 37483 | 37484 | 37485 | 37486 | 37487 | 39985 | 39986 | 39987 | 39988 | 39989 | 39990 | 39991 | 39992 | 40215 | 40216 | 40217 | 40218 | 40219 | 40220 | 40221 | 40222 | 40223 | 40224 | 40225 | 40226 | 40227 | 40228 | 40229 | 40230 | 46354 | 46355 | 46356 | 46357 | 46358 | 46359 | 46360 | 46361 | 46362 | 49991 | 49992 | 49993 | 49998 | 49999 | 50000 | 55940 | 58434 | 62863 | 67155 | 70086 | 70087 | 70484 | 74110 | 74111 | 74848 | 80370 | 81487 | 81488 | 81589 | 81590 | 81591 | 84801 | 84802 | 84803 | 84804 | 84805 | 86861 | 86862 | 86863 | 86864 | 86865 | 88874 | 88875 | 88876 | 88877 | 88878 | 88879