Bugzilla – Attachment 93201 Details for
Bug 23602
Library limitations should display in the item types table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23602: (follow-up) Correct terminology, add tooltip
Bug-23602-follow-up-Correct-terminology-add-toolti.patch (text/plain), 3.41 KB, created by
Martin Renvoize (ashimema)
on 2019-09-27 12:16:32 UTC
(
hide
)
Description:
Bug 23602: (follow-up) Correct terminology, add tooltip
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-09-27 12:16:32 UTC
Size:
3.41 KB
patch
obsolete
>From 887b53fb93f61c76e9a2dc86470e62185ca569ca Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 13 Sep 2019 16:13:33 +0000 >Subject: [PATCH] Bug 23602: (follow-up) Correct terminology, add tooltip > >This follow-up changes the use of "branch" to the Koha standard >"library." The patch also adds the use of a Bootstrap tooltip for >showing an item type's library limitations in the main table of item >types. > >To test, apply the patch and go to Administration -> Item types. > >In the table of item types, find one with library limitations. Hovering >over the "# library limitations" test should trigger a Bootstrap-styled >tooltip showing the library name and code. > >Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/modules/admin/itemtypes.tt | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >index 715a71b716..a1b4f1ff8b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >@@ -283,7 +283,7 @@ Item types administration > [% END %] > </select> > </li> >- <li><label for="branches">Libraries limitation: </label> >+ <li><label for="branches">Library limitation: </label> > <select id="branches" name="branches" multiple size="10"> > <option value="">All libraries</option> > [% FOREACH branch IN branches_loop %] >@@ -359,7 +359,7 @@ Item types administration > <th>Default replacement cost</th> > <th>Processing fee (when lost)</th> > <th>Checkin message</th> >- <th>Branches limitations</th> >+ <th>Library limitations</th> > <th>Actions</th> > </thead> > [% FOREACH itemtype IN itemtypes %] >@@ -416,13 +416,13 @@ Item types administration > [% IF itemtype.branches.size > 0 %] > [% branches_str = "" %] > [% FOREACH branch IN itemtype.branches %] >- [% branches_str = branches_str _ " " _ branch.branchname _ "(" _ branch.branchcode _ ")" %] >+ [% branches_str = branches_str _ " " _ branch.branchname _ " (" _ branch.branchcode _ ")" %] > [% END %] >- <span href="#" title="[% branches_str | html %]"> >+ <span class="library_limitation" title="[% branches_str | html %]"> > [% IF itemtype.branches.size > 1 %] >- [% itemtype.branches.size | html %] branches limitations >+ [% itemtype.branches.size | html %] library limitations > [% ELSE %] >- [% itemtype.branches.size | html %] branch limitation >+ [% itemtype.branches.size | html %] library limitation > [% END %] > [% ELSE %] > No limitation >@@ -475,6 +475,7 @@ Item types administration > $("#itemtype").on("blur",function(){ > toUC(this); > }); >+ $(".library_limitation").tooltip(); > }); > </script> > [% END %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23602
:
92800
|
92815
|
92816
|
93044
|
93046
|
93200
| 93201 |
93202
|
93205