With the introduction of bug 15497 itemtypes can now be limited to select branches. We should display the selected branch list in the itemtype summary table.
I missed this during my QA run on the original bug.. any chance of a quick followup Agustin.. hopefully it's a trivial request.
Created attachment 92800 [details] [review] Bug 23602: Display branch limitations in itemtype table This patch adds a column in itemtype table to display branch limitations. To test: 1) Open item types admin page. CHECK => there is no column for branch limitations, even if you add a limitation in an item type. 2) Apply this patch SUCCESS => A new column appears that displays branch limitations per item type 3) Sign off
Created attachment 92815 [details] [review] Bug 23602: Display branch limitations in itemtype table This patch adds a column in itemtype table to display branch limitations. To test: 1) Open item types admin page. CHECK => there is no column for branch limitations, even if you add a limitation in an item type. 2) Apply this patch SUCCESS => A new column appears that displays branch limitations per item type 3) Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 92816 [details] [review] Bug 23602: (follow-up) Correct terminology, add tooltip This follow-up changes the use of "branch" to the Koha standard "library." The patch also adds the use of a Bootstrap tooltip for showing an item type's library limitations in the main table of item types. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code.
Created attachment 93044 [details] [review] Bug 23602: Display branch limitations in itemtype table This patch adds a column in itemtype table to display branch limitations. To test: 1) Open item types admin page. CHECK => there is no column for branch limitations, even if you add a limitation in an item type. 2) Apply this patch SUCCESS => A new column appears that displays branch limitations per item type 3) Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 93046 [details] [review] Bug 23602: (follow-up) Correct terminology, add tooltip This follow-up changes the use of "branch" to the Koha standard "library." The patch also adds the use of a Bootstrap tooltip for showing an item type's library limitations in the main table of item types. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 93200 [details] [review] Bug 23602: Display branch limitations in itemtype table This patch adds a column in itemtype table to display branch limitations. To test: 1) Open item types admin page. CHECK => there is no column for branch limitations, even if you add a limitation in an item type. 2) Apply this patch SUCCESS => A new column appears that displays branch limitations per item type 3) Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 93201 [details] [review] Bug 23602: (follow-up) Correct terminology, add tooltip This follow-up changes the use of "branch" to the Koha standard "library." The patch also adds the use of a Bootstrap tooltip for showing an item type's library limitations in the main table of item types. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 93202 [details] [review] Bug 23602: (follow-up) Improve tooltip formatting This follow-up changes the formatting of the tooltip to add a newline for library limit. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code, one per line. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 93205 [details] [review] Bug 23602: (follow-up) Improve tooltip formatting This follow-up changes the formatting of the tooltip to add a newline for library limit. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code, one per line. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Passing QA :)
Nice work! Pushed to master for 19.11.00
Depends on Bug 15497 not in 19.05.x
Augustin, can you please have a look at bug 23602? It looks like this patch set broke the display of the item type in the table. This part in the template does no longer seem to work: [% UNLESS Koha.Preference('noItemTypeImages') %] <td> [% SET image_location = itemtype.image_location('intranet') %] [% IF image_location %]<img src="[% image_location | html %]" alt="" />[% ELSE %] [% END %] </td> [% END %]