Bugzilla – Attachment 94543 Details for
Bug 23867
18.12.00.051 fails with "Truncated incorrect DOUBLE value"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23867: Resolve "truncated incorrect double" for empty string
Bug-23867-Resolve-truncated-incorrect-double-for-e.patch (text/plain), 1.42 KB, created by
Marcel de Rooy
on 2019-10-22 12:31:54 UTC
(
hide
)
Description:
Bug 23867: Resolve "truncated incorrect double" for empty string
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-10-22 12:31:54 UTC
Size:
1.42 KB
patch
obsolete
>From 2b0032276f780fd6932da907e820cbb811277b89 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 22 Oct 2019 12:29:40 +0000 >Subject: [PATCH] Bug 23867: Resolve "truncated incorrect double" for empty > string >Content-Type: text/plain; charset=utf-8 > >Updatedatabase, rev. 18.12.00.051 >Solved by testing the value of the pref first. >Tested by copying the change in a new atomic update with XXX. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > installer/data/mysql/updatedatabase.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index cf00117a53..765fa77178 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -18077,7 +18077,8 @@ VALUES > > $DBversion = '18.12.00.051'; > if( CheckVersion( $DBversion ) ) { >- $dbh->do( "UPDATE borrowers SET login_attempts = ? WHERE login_attempts > ?", undef, C4::Context->preference('FailedLoginAttempts'), C4::Context->preference('FailedLoginAttempts') ); >+ my $failed_attempts = C4::Context->preference('FailedLoginAttempts'); >+ $dbh->do( "UPDATE borrowers SET login_attempts = ? WHERE login_attempts > ?", undef, $failed_attempts, $failed_attempts ) if $failed_attempts && $failed_attempts > 0; > SetVersion( $DBversion ); > print "Upgrade to $DBversion done (Bug 21336 - Reset login_attempts)\n"; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23867
:
94543
|
94546