Bug 23867 - 18.12.00.051 fails with "Truncated incorrect DOUBLE value"
Summary: 18.12.00.051 fails with "Truncated incorrect DOUBLE value"
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on: 21336
Blocks:
  Show dependency treegraph
 
Reported: 2019-10-22 10:41 UTC by Jonathan Druart
Modified: 2019-11-08 15:46 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:
19.11.00,19.05.x


Attachments
Bug 23867: Resolve "truncated incorrect double" for empty string (1.42 KB, patch)
2019-10-22 12:31 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 23867: Resolve "truncated incorrect double" for empty string (1.46 KB, patch)
2019-10-22 12:52 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2019-10-22 10:41:02 UTC
DBD::mysql::db do failed: Truncated incorrect DOUBLE value: '' [for Statement "UPDATE borrowers SET login_attempts = ? WHERE login_attempts > ?"] at installer/data/mysql/updatedatabase.pl line 18091.
Comment 1 Marcel de Rooy 2019-10-22 12:10:06 UTC
Trivial patch coming
Comment 2 Marcel de Rooy 2019-10-22 12:31:54 UTC
Created attachment 94543 [details] [review]
Bug 23867: Resolve "truncated incorrect double" for empty string

Updatedatabase, rev. 18.12.00.051
Solved by testing the value of the pref first.
Tested by copying the change in a new atomic update with XXX.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Jonathan Druart 2019-10-22 12:52:36 UTC
Created attachment 94546 [details] [review]
Bug 23867: Resolve "truncated incorrect double" for empty string

Updatedatabase, rev. 18.12.00.051
Solved by testing the value of the pref first.
Tested by copying the change in a new atomic update with XXX.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2019-10-22 12:52:53 UTC
Trivial, skipping QA.
Comment 5 Martin Renvoize 2019-10-22 13:13:58 UTC
Nice work!

Pushed to master for 19.11.00
Comment 6 Fridolin SOMERS 2019-11-08 15:46:36 UTC
Pushed to 19.05.x for 19.05.05