Bugzilla – Attachment 9613 Details for
Bug 7703
Don't block bulk hold action on search results if some items can't be placed on hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7703 - Don't block bulk hold action on search results if some items can't be placed on hold
Bug-7703---Dont-block-bulk-hold-action-on-search-r.patch (text/plain), 2.56 KB, created by
Kyle M Hall
on 2012-05-16 12:03:20 UTC
(
hide
)
Description:
Bug 7703 - Don't block bulk hold action on search results if some items can't be placed on hold
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2012-05-16 12:03:20 UTC
Size:
2.56 KB
patch
obsolete
>From aaea03643a9d40c0e6c3fa59f92788047e72d83e Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 16 May 2012 08:01:06 -0400 >Subject: [PATCH] Bug 7703 - Don't block bulk hold action on search results if some items can't be placed on hold > >In the staff client if you check multiple lines in search results and click >the button to "place hold" you might be blocked from proceeding because >"One or more selected items cannot be placed on hold." The next stage of the >holds process is perfectly capable of warning the user about such problems. >The user should not have to search back through the list of items they >checked to find which one to un-check. > >Fixed by not disabling the submit button in the event that one >of the records has no holdable items. Updated text of submit >buttons. >--- > .../prog/en/modules/reserve/request.tt | 6 +++--- > reserve/request.pl | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index eba6756..e9cb05d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -550,11 +550,11 @@ function checkMultiHold() { > <fieldset class="action"> > [% IF ( borrowernumber ) %] > [% IF ( override_required ) %] >- <input type="submit" class="warning" value="Place hold" /> >+ <input type="submit" class="warning" value="Place holds" /> > [% ELSIF ( none_available ) %] >- <input type="submit" disabled="disabled" value="Place hold" /> >+ <input type="submit" value="Place holds on holdable items" /> > [% ELSE %] >- <input type="submit" value="Place hold" /> >+ <input type="submit" value="Place holds" /> > [% END %] > [% END %] > </fieldset> >diff --git a/reserve/request.pl b/reserve/request.pl >index ff01850..d700ed4 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -466,7 +466,7 @@ foreach my $biblionumber (@biblionumbers) { > } > elsif ( C4::Context->preference('AllowHoldPolicyOverride') ) { > >-# If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules >+ # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules > $item->{override} = 1; > $num_override++; > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7703
:
9613
|
14360
|
14435
|
15290
|
19114
|
19115
|
28144
|
52166
|
52167
|
52168
|
52295
|
52296
|
123575
|
123576
|
123577
|
123812
|
123813
|
123814
|
124233
|
124234
|
124235