Bugzilla – Attachment 9760 Details for
Bug 7127
Templates must be valid XHTML
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7127 - Templates must be valid XHTML
Bug-7127---Templates-must-be-valid-XHTML.patch (text/plain), 5.13 KB, created by
Owen Leonard
on 2012-05-24 14:20:20 UTC
(
hide
)
Description:
Bug 7127 - Templates must be valid XHTML
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2012-05-24 14:20:20 UTC
Size:
5.13 KB
patch
obsolete
>From 13051a05ba4b13236c49965cd7441fc90eb0e1f0 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 24 May 2012 10:17:31 -0400 >Subject: [PATCH] Bug 7127 - Templates must be valid XHTML >Content-Type: text/plain; charset="utf-8" > >Fixing markup errors on OPAC detail page and OPAC results. >Also conditionally including ratings JS on OPAC detail. >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 12 ++++++------ > .../opac-tmpl/prog/en/modules/opac-results.tt | 6 +++--- > 2 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index e7cc4a3..3c45aff 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -9,8 +9,8 @@ > {lang: '[% lang %]'} > </script> > [% END %] >-<script type="text/javascript" src="/opac-tmpl/prog/en/lib/jquery/plugins/jquery.rating.js"></script> >-<link rel="stylesheet" type="text/css" href="/opac-tmpl/prog/en/css/jquery.rating.css" /> >+[% IF ( OpacStarRatings != 'disable' ) %]<script type="text/javascript" src="/opac-tmpl/prog/en/lib/jquery/plugins/jquery.rating.js"></script> >+<link rel="stylesheet" type="text/css" href="/opac-tmpl/prog/en/css/jquery.rating.css" />[% END %] > > <script type="text/JavaScript" language="JavaScript"> > //<![CDATA[ >@@ -89,7 +89,7 @@ > [% END %] > > $(".branch-info-tooltip-trigger").tooltip({delay: 100, position: "top right"}); >- >+[% IF ( OpacStarRatings != 'disable' ) %] > // ----------------------------------------------------- > // star-ratings code > // ----------------------------------------------------- >@@ -136,7 +136,7 @@ $(function () { > }); > }); > // ----------------------------------------------------- >- >+[% END %] > }); > > [% IF ( OpacBrowseResults && busc ) %] >@@ -563,7 +563,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > <input type="hidden" name='rating_total' id='rating_total' value="[% rating_total %]" /> > <input type="hidden" name='rating_avg_int' id='rating_avg_int' value="[% rating_avg_int %]" /> > >- [% UNLESS ( rating_readonly ) %] <INPUT name="rate_button" type="submit" value="Rate me">[% END %] >+ [% UNLESS ( rating_readonly ) %] <input name="rate_button" type="submit" value="Rate me" />[% END %] > > [% IF ( rating_value ) %] > <span id="rating_value_text">your rating: [% rating_value %], </span> >@@ -574,7 +574,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > <span id="rating_text">average rating: [% rating_avg_int %] ([% rating_total %] votes)</span> > > </div> >- </FORM> >+ </form> > [% END %] > > [% IF ( BakerTaylorContentURL ) %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >index 49303a6..9361419 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >@@ -522,7 +522,7 @@ $(document).ready(function(){ > [% IF ( SEARCH_RESULT.rating_total ) > 0 %] > <span id="rating_total_[% SEARCH_RESULT.biblionumber %]"> ([% SEARCH_RESULT.rating_total %] votes)</span> > [% ELSE %] >- </br> >+ <br /> > [% END %] > > </div> >@@ -600,8 +600,8 @@ $(document).ready(function(){ > [% END %] > [% END %] > >- [% IF ( GoogleJackets ) %][% IF ( SEARCH_RESULT.normalized_isbn ) %]<div style="block" title="[% SEARCH_RESULT.biblionumber |url %]" class="[% SEARCH_RESULT.normalized_isbn %]" id="gbs-thumbnail[% loop.count %]"></div>[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %] >- [% IF OpenLibraryCovers %][% IF SEARCH_RESULT.normalized_isbn %]<div style="block" title="[% SEARCH_RESULT.biblionumber %]" class="[% SEARCH_RESULT.normalized_isbn %]" id="openlibrary-thumbnail[% loop.count %]"></div>[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %] >+ [% IF ( GoogleJackets ) %][% IF ( SEARCH_RESULT.normalized_isbn ) %]<span style="block" title="[% SEARCH_RESULT.biblionumber |url %]" class="[% SEARCH_RESULT.normalized_isbn %]" id="gbs-thumbnail[% loop.count %]"></span>[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %] >+ [% IF OpenLibraryCovers %][% IF SEARCH_RESULT.normalized_isbn %]<span style="block" title="[% SEARCH_RESULT.biblionumber %]" class="[% SEARCH_RESULT.normalized_isbn %]" id="openlibrary-thumbnail[% loop.count %]"></span>[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %] > </a> > [% IF ( BakerTaylorEnabled ) %][% IF ( SEARCH_RESULT.normalized_isbn ) %]<a href="https://[% BakerTaylorBookstoreURL |html %][% SEARCH_RESULT.normalized_isbn %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |html %][% SEARCH_RESULT.normalized_isbn %]" /></a>[% ELSE %]<span class="no-image">No cover image available</span>[% END %][% END %] > </td> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7127
:
6342
|
6702
|
7140
|
7339
|
7444
|
7446
|
7456
|
9760
|
9788