Bugzilla – Attachment 98174 Details for
Bug 24547
Add more action logs for holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24547: Add more action logs for holds
Bug-24547-Add-more-action-logs-for-holds.patch (text/plain), 1.28 KB, created by
Kyle M Hall (khall)
on 2020-01-30 15:30:31 UTC
(
hide
)
Description:
Bug 24547: Add more action logs for holds
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-01-30 15:30:31 UTC
Size:
1.28 KB
patch
obsolete
>From b53261645b515fa743b6b3bd33c08af1aaf73953 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 30 Jan 2020 10:29:05 -0500 >Subject: [PATCH] Bug 24547: Add more action logs for holds > >It seems like ModReserveFill and ModReserveAffect should both produce action logs for holds. > >Test Plan: >1) Apply this patch >2) Place a hold >3) Check in the item to trap the hold >4) Check out the item to fill the hold >5) Check the action logs for that reserve id >6) Note the new logs! >--- > C4/Reserves.pm | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index f2bf8bd5d3..ea12f279f5 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -1026,6 +1026,9 @@ sub ModReserveFill { > } > ); > >+ logaction( 'HOLDS', 'MODIFY', $hold->reserve_id, Dumper($hold->unblessed) ) >+ if C4::Context->preference('HoldsLog'); >+ > # FIXME Must call Koha::Hold->cancel ? => No, should call ->filled and add the correct log > Koha::Old::Hold->new( $hold->unblessed() )->store(); > >@@ -1126,6 +1129,9 @@ sub ModReserveAffect { > CartToShelf( $itemnumber ); > } > >+ logaction( 'HOLDS', 'MODIFY', $hold->reserve_id, Dumper($hold->unblessed) ) >+ if C4::Context->preference('HoldsLog'); >+ > return; > } > >-- >2.21.1 (Apple Git-122.3)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24547
:
98174
|
98215
|
102565
|
102569